Skip to content

libs/guest: new CPUID/MSR interface

Roger Pau Monne xen-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest11 patches 2 repliesIn review
  2. v612 patches 11 repliesSuperseded
  3. v512 patches 10 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v410 patches4 repliesSuperseded
v313 patches24 repliesSuperseded
v221 patches21 repliesSuperseded
v121 patches30 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11libx86: introduce helper to fetch cpuid leaftools/tests/cpu-policy/test-cpu-policy.c xen/arch/x86/cpuid.c xen/include/xen/lib/x86/cpuid.h +1 more+255 -481 reply
2/11libs/guest: allow fetching a specific CPUID leaf from a cpu policytools/include/xenguest.h tools/libs/guest/xg_cpuid_x86.c+29 -00 replies
3/11libx86: introduce helper to fetch msr entrytools/tests/cpu-policy/test-cpu-policy.c xen/include/xen/lib/x86/msr.h xen/lib/x86/msr.c+76 -331 reply
4/11libs/guest: allow fetching a specific MSR entry from a cpu policytools/include/xenguest.h tools/libs/guest/xg_cpuid_x86.c+22 -00 replies
5/11libs/guest: make a cpu policy compatible with older Xen versionstools/include/xenguest.h tools/libs/guest/xg_cpuid_x86.c+36 -180 replies
6/11libs/guest: introduce helper set cpu topology in cpu policytools/include/xenguest.h tools/libs/guest/xg_cpuid_x86.c+91 -830 replies
7/11libs/guest: rework xc_cpuid_xend_policytools/include/xenguest.h tools/libs/guest/xg_cpuid_x86.c+81 -1270 replies
8/11libs/guest: apply a featureset into a cpu policytools/include/xenguest.h tools/libs/guest/xg_cpuid_x86.c+62 -380 replies
9/11libs/{light,guest}: implement xc_cpuid_apply_policy in libxltools/include/xenctrl.h tools/libs/guest/xg_cpuid_x86.c tools/libs/light/libxl_cpuid.c+67 -1570 replies
10/11libs/guest: (re)move xc_cpu_policy_apply_cpuidtools/include/libxl.h tools/include/xenctrl.h tools/include/xenguest.h +3 more+156 -1560 replies
11/11x86/CPUID: shrink max_{,sub}leaf fields according to actual leaf contentstools/include/xenguest.h tools/libs/guest/xg_cpuid_x86.c tools/libs/light/libxl_cpuid.c +3 more+162 -00 replies

Reviews trailers per patch

6 of 11 patches have a Reviewed-by or Acked-by.

PatchJan BeulichAnthony PERARD
1/11
2/11R-b
3/11R-b
4/11R-b
5/11
6/11
7/11
8/11R-b
9/11R-b
10/11R-b
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 00/11] libs/guest: new CPUID/MSR interface

Hello,

The following series introduces a new CPUID/MSR interface for the xenguest library. Such interface handles both CPUID and MSRs using the same opaque object, and provides some helpers for the user to peek or modify such data without exposing the backing type. This is useful for future development as CPUID and MSRs are closely related, so it makes handling those much easier if they are inside the same object (ie: a change to a CPUID bit might expose or hide an MSR).

In this patch series libxl and other in tree users have been switched to use the new interface, so it shouldn't result in any functional change from a user point of view.

Note there are still some missing pieces likely. The way to modify CPUID data is not ideal, as it requires fetching a leaf and modifying it directly. We might want some kind of interface in order to set specific CPUID features more easily, but that's to be discussed, and would be done as a follow up series.

The addition of a helper to generate compatible policies given two inputs has been removed from this iteration, sine Andrew Cooper has posted a patch to set the foundation for that, and further work should be done against that baseline.

Thanks, Roger.

Jan Beulich (1):
x86/CPUID: shrink max_{,sub}leaf fields according to actual leaf
contents

Roger Pau Monne (10):
libx86: introduce helper to fetch cpuid leaf libs/guest: allow fetching a specific CPUID leaf from a cpu policy
libx86: introduce helper to fetch msr entry
libs/guest: allow fetching a specific MSR entry from a cpu policy libs/guest: make a cpu policy compatible with older Xen versions libs/guest: introduce helper set cpu topology in cpu policy libs/guest: rework xc_cpuid_xend_policy
libs/guest: apply a featureset into a cpu policy libs/{light,guest}: implement xc_cpuid_apply_policy in libxl libs/guest: (re)move xc_cpu_policy_apply_cpuid

 tools/include/libxl.h                    |   6 +-
 tools/include/xenctrl.h                  |  44 --
 tools/include/xenguest.h                 |  26 +
 tools/libs/guest/xg_cpuid_x86.c          | 607 ++++++++---------------
 tools/libs/light/libxl_cpuid.c           | 205 +++++++-
 tools/libs/light/libxl_internal.h        |  26 +
 tools/tests/cpu-policy/test-cpu-policy.c | 326 +++++++++++-
 xen/arch/x86/cpuid.c                     |  55 +-
 xen/include/xen/lib/x86/cpuid.h          |  26 +
 xen/include/xen/lib/x86/msr.h            |  20 +-
 xen/lib/x86/cpuid.c                      |  91 ++++
 xen/lib/x86/msr.c                        |  41 +-
 12 files changed, 925 insertions(+), 548 deletions(-)
Signature · 1 line
2.34.1