Skip to content

Staging: rtl8723bs: remove unnecessary enum names and definitions

Marco Cesati linux-staging 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest33 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/33Staging: rtl8723bs: remove named enums in rtw_mlme.hdrivers/staging/rtl8723bs/include/rtw_mlme.h+2 -142 replies
2/33Staging: rtl8723bs: remove named enums in rtw_cmd.hdrivers/staging/rtl8723bs/include/rtw_cmd.h+4 -40 replies
3/33Staging: rtl8723bs: remove named enums in rtw_eeprom.hdrivers/staging/rtl8723bs/include/rtw_eeprom.h+1 -10 replies
4/33Staging: rtl8723bs: remove named enums in hal_com.hdrivers/staging/rtl8723bs/include/hal_com.h+0 -40 replies
5/33Staging: rtl8723bs: remove named enums in rtw_recv.hdrivers/staging/rtl8723bs/include/rtw_recv.h+1 -10 replies
6/33Staging: rtl8723bs: remove named enums in drv_types.hdrivers/staging/rtl8723bs/include/drv_types.h+2 -170 replies
7/33Staging: rtl8723bs: remove named enums in rtw_ht.hdrivers/staging/rtl8723bs/include/rtw_ht.h+3 -30 replies
8/33Staging: rtl8723bs: remove named enums in wlan_bssdef.hdrivers/staging/rtl8723bs/include/wlan_bssdef.h+4 -90 replies
9/33Staging: rtl8723bs: remove named enums in rtw_mp.hdrivers/staging/rtl8723bs/include/rtw_mp.h+0 -980 replies
10/33Staging: rtl8723bs: remove named enums in osdep_service.hdrivers/staging/rtl8723bs/include/osdep_service.h+0 -250 replies
11/33Staging: rtl8723bs: remove named enums in hal_intf.hdrivers/staging/rtl8723bs/include/hal_intf.h+2 -240 replies
12/33Staging: rtl8723bs: remove named enums in rtw_pwrctrl.hdrivers/staging/rtl8723bs/include/rtw_pwrctrl.h+2 -30 replies
13/33Staging: rtl8723bs: remove named enums in rtl8723b_cmd.hdrivers/staging/rtl8723bs/include/rtl8723b_cmd.h+1 -10 replies
14/33Staging: rtl8723bs: remove named enums in hal_com_h2c.hdrivers/staging/rtl8723bs/include/hal_com_h2c.h+0 -600 replies
15/33Staging: rtl8723bs: remove named enums in rtw_wifi_regd.hdrivers/staging/rtl8723bs/include/rtw_wifi_regd.h+0 -70 replies
16/33Staging: rtl8723bs: remove named enums in wifi.hdrivers/staging/rtl8723bs/include/wifi.h+2 -260 replies
17/33Staging: rtl8723bs: remove named enums in rtl8723b_hal.hdrivers/staging/rtl8723bs/include/rtl8723b_hal.h+2 -20 replies
18/33Staging: rtl8723bs: remove named enums in hal_phy.hdrivers/staging/rtl8723bs/include/hal_phy.h+1 -430 replies
19/33Staging: rtl8723bs: remove named enums in rtw_mlme_ext.hdrivers/staging/rtl8723bs/include/rtw_mlme_ext.h+6 -180 replies
20/33Staging: rtl8723bs: remove named enums in rtw_xmit.hdrivers/staging/rtl8723bs/include/rtw_xmit.h+0 -70 replies
21/33Staging: rtl8723bs: remove named enums in rtw_rf.hdrivers/staging/rtl8723bs/include/rtw_rf.h+4 -280 replies
22/33Staging: rtl8723bs: remove named enums in HalPwrSeqCmd.hdrivers/staging/rtl8723bs/include/HalPwrSeqCmd.h+1 -10 replies
23/33Staging: rtl8723bs: remove named enums in hal_com_phycfg.hdrivers/staging/rtl8723bs/include/hal_com_phycfg.h+2 -20 replies
24/33Staging: rtl8723bs: remove named enums in ieee80211.hdrivers/staging/rtl8723bs/include/ieee80211.h+4 -850 replies
25/33Staging: rtl8723bs: remove named enums in rtw_efuse.hdrivers/staging/rtl8723bs/include/rtw_efuse.h+1 -10 replies
26/33Staging: rtl8723bs: remove named enums in odm_interface.hdrivers/staging/rtl8723bs/hal/odm_interface.h+0 -90 replies
27/33Staging: rtl8723bs: remove named enums in HalBtcOutSrc.hdrivers/staging/rtl8723bs/hal/HalBtcOutSrc.h+18 -520 replies
28/33Staging: rtl8723bs: remove named enums in HalBtc8723b1Ant.hdrivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h+4 -40 replies
29/33Staging: rtl8723bs: remove named enums in odm_types.hdrivers/staging/rtl8723bs/hal/odm_types.h+0 -410 replies
30/33Staging: rtl8723bs: remove named enums in odm_DIG.hdrivers/staging/rtl8723bs/hal/odm_DIG.h+0 -160 replies
31/33Staging: rtl8723bs: remove named enums in HalPhyRf.hdrivers/staging/rtl8723bs/hal/HalPhyRf.h+0 -50 replies
32/33Staging: rtl8723bs: remove named enums in odm.hdrivers/staging/rtl8723bs/hal/odm.h+12 -1380 replies
33/33Staging: rtl8723bs: remove named enums in HalBtc8723b2Ant.hdrivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.h+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/33] Staging: rtl8723bs: remove unnecessary enum names and definitions

The staging/rtl8723bs driver includes 82 enum definitions whose names are not referenced in the code. Furthermore, 57 enum definitions are useless, because the enum elements do not appear in the code. This patchset transforms 82 'named' enums in 'anonymous' enums and removes 57 enum definitions.

[PATCH 01/33] Staging: rtl8723bs: remove named enums in rtw_mlme.h [PATCH 02/33] Staging: rtl8723bs: remove named enums in rtw_cmd.h [PATCH 03/33] Staging: rtl8723bs: remove named enums in rtw_eeprom.h [PATCH 04/33] Staging: rtl8723bs: remove named enums in hal_com.h [PATCH 05/33] Staging: rtl8723bs: remove named enums in rtw_recv.h [PATCH 06/33] Staging: rtl8723bs: remove named enums in drv_types.h [PATCH 07/33] Staging: rtl8723bs: remove named enums in rtw_ht.h [PATCH 08/33] Staging: rtl8723bs: remove named enums in wlan_bssdef.h [PATCH 09/33] Staging: rtl8723bs: remove named enums in rtw_mp.h [PATCH 10/33] Staging: rtl8723bs: remove named enums in osdep_service.h [PATCH 11/33] Staging: rtl8723bs: remove named enums in hal_intf.h [PATCH 12/33] Staging: rtl8723bs: remove named enums in rtw_pwrctrl.h [PATCH 13/33] Staging: rtl8723bs: remove named enums in rtl8723b_cmd.h [PATCH 14/33] Staging: rtl8723bs: remove named enums in hal_com_h2c.h [PATCH 15/33] Staging: rtl8723bs: remove named enums in rtw_wifi_regd.h [PATCH 16/33] Staging: rtl8723bs: remove named enums in wifi.h [PATCH 17/33] Staging: rtl8723bs: remove named enums in rtl8723b_hal.h [PATCH 18/33] Staging: rtl8723bs: remove named enums in hal_phy.h [PATCH 19/33] Staging: rtl8723bs: remove named enums in rtw_mlme_ext.h [PATCH 20/33] Staging: rtl8723bs: remove named enums in rtw_xmit.h [PATCH 21/33] Staging: rtl8723bs: remove named enums in rtw_rf.h [PATCH 22/33] Staging: rtl8723bs: remove named enums in HalPwrSeqCmd.h [PATCH 23/33] Staging: rtl8723bs: remove named enums in hal_com_phycfg.h [PATCH 24/33] Staging: rtl8723bs: remove named enums in ieee80211.h [PATCH 25/33] Staging: rtl8723bs: remove named enums in rtw_efuse.h [PATCH 26/33] Staging: rtl8723bs: remove named enums in odm_interface.h [PATCH 27/33] Staging: rtl8723bs: remove named enums in HalBtcOutSrc.h [PATCH 28/33] Staging: rtl8723bs: remove named enums in HalBtc8723b1Ant.h [PATCH 29/33] Staging: rtl8723bs: remove named enums in odm_types.h [PATCH 30/33] Staging: rtl8723bs: remove named enums in odm_DIG.h [PATCH 31/33] Staging: rtl8723bs: remove named enums in HalPhyRf.h [PATCH 32/33] Staging: rtl8723bs: remove named enums in odm.h [PATCH 33/33] Staging: rtl8723bs: remove named enums in HalBtc8723b2Ant.h

 .../staging/rtl8723bs/hal/HalBtc8723b1Ant.h   |   8 +-
 .../staging/rtl8723bs/hal/HalBtc8723b2Ant.h   |   6 +-
 drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h  |  70 +++-----
 drivers/staging/rtl8723bs/hal/HalPhyRf.h      |   5 -
 drivers/staging/rtl8723bs/hal/odm.h           | 150 ++----------------
 drivers/staging/rtl8723bs/hal/odm_DIG.h       |  16 --
 drivers/staging/rtl8723bs/hal/odm_interface.h |   9 --
 drivers/staging/rtl8723bs/hal/odm_types.h     |  41 -----
 .../staging/rtl8723bs/include/HalPwrSeqCmd.h  |   2 +-
 drivers/staging/rtl8723bs/include/drv_types.h |  19 +--
 drivers/staging/rtl8723bs/include/hal_com.h   |   4 -
 .../staging/rtl8723bs/include/hal_com_h2c.h   |  60 -------
 .../rtl8723bs/include/hal_com_phycfg.h        |   4 +-
 drivers/staging/rtl8723bs/include/hal_intf.h  |  26 +--
 drivers/staging/rtl8723bs/include/hal_phy.h   |  44 +----
 drivers/staging/rtl8723bs/include/ieee80211.h |  89 +----------
 .../staging/rtl8723bs/include/osdep_service.h |  25 ---
 .../staging/rtl8723bs/include/rtl8723b_cmd.h  |   2 +-
 .../staging/rtl8723bs/include/rtl8723b_hal.h  |   4 +-
 drivers/staging/rtl8723bs/include/rtw_cmd.h   |   8 +-
 .../staging/rtl8723bs/include/rtw_eeprom.h    |   2 +-
 drivers/staging/rtl8723bs/include/rtw_efuse.h |   2 +-
 drivers/staging/rtl8723bs/include/rtw_ht.h    |   6 +-
 drivers/staging/rtl8723bs/include/rtw_mlme.h  |  16 +-
 .../staging/rtl8723bs/include/rtw_mlme_ext.h  |  24 +--
 drivers/staging/rtl8723bs/include/rtw_mp.h    |  98 ------------
 .../staging/rtl8723bs/include/rtw_pwrctrl.h   |   5 +-
 drivers/staging/rtl8723bs/include/rtw_recv.h  |   2 +-
 drivers/staging/rtl8723bs/include/rtw_rf.h    |  32 +---
 .../staging/rtl8723bs/include/rtw_wifi_regd.h |   7 -
 drivers/staging/rtl8723bs/include/rtw_xmit.h  |   7 -
 drivers/staging/rtl8723bs/include/wifi.h      |  28 +---
 .../staging/rtl8723bs/include/wlan_bssdef.h   |  13 +-
 33 files changed, 82 insertions(+), 752 deletions(-)
Signature · 1 line
2.30.2