Skip to content

Allow signals for IO threads

Jens Axboe io-uring lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 13 repliesIn review
  2. v10 of 6 patches 25 repliesSuperseded

Changes in v2 from the cover letter

- Catch fatal signals in get_signal() for PF_IO_WORKER. This is only a problem for nested signals, like SIGSTOP followed by SIGKILL. We can't have get_signal() calling do_exit() on behalf of the IO threads, they have cleanups to do. Thanks Stefan.

- Move signal masking to when the PF_IO_WORKER thread is created, and since we now handle SIGSTOP, unmask that as well. Thanks Oleg.

- Remove try_to_freeze() parts in IO threads, we don't need those anymore with the calling of get_signal().

- Minor cleanups.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7kernel: don't call do_exit() for PF_IO_WORKER threadskernel/signal.c+9 -02 replies
2/7io_uring: handle signals for IO threads like a normal threadfs/io-wq.c fs/io_uring.c+25 -119 replies
3/7kernel: stop masking signals in create_io_thread()kernel/fork.c+8 -81 reply
4/7Revert "signal: don't allow sending any signals to PF_IO_WORKER threads"kernel/signal.c+0 -30 replies
5/7Revert "kernel: treat PF_IO_WORKER like PF_KTHREAD for ptrace/signals"kernel/ptrace.c kernel/signal.c+3 -30 replies
6/7Revert "kernel: freezer should treat PF_IO_WORKER like PF_KTHREAD for freezing"kernel/freezer.c+1 -10 replies
7/7Revert "signal: don't allow STOP on PF_IO_WORKER threads"kernel/signal.c+1 -20 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchEric W. Biederman
1/7
2/7A-b
3/7A-b
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHSET v2 0/7] Allow signals for IO threads

Hi,

For the v1 posting, see here:

https://lore.kernel.org/io-uring/[email protected]/

I've run this through the usual testing, and it's running long term right now. I've tested the cases that Stefan reported, and we seem fine now.

Changes since v1:

- Catch fatal signals in get_signal() for PF_IO_WORKER. This is only a problem for nested signals, like SIGSTOP followed by SIGKILL. We can't have get_signal() calling do_exit() on behalf of the IO threads, they have cleanups to do. Thanks Stefan.

- Move signal masking to when the PF_IO_WORKER thread is created, and since we now handle SIGSTOP, unmask that as well. Thanks Oleg.

- Remove try_to_freeze() parts in IO threads, we don't need those anymore with the calling of get_signal().

- Minor cleanups.

 fs/io-wq.c       | 24 +++++++++++++++++-------
 fs/io_uring.c    | 12 ++++++++----
 kernel/fork.c    | 16 ++++++++--------
 kernel/freezer.c |  2 +-
 kernel/ptrace.c  |  2 +-
 kernel/signal.c  | 19 ++++++++++++-------
 6 files changed, 47 insertions(+), 28 deletions(-)
Signature · 1 line
Jens Axboe