Skip to content

Get rid of custom made module dependency

Leon Romanovsky linux-rdma netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 18 repliesIn review
  2. v15 patches 4 repliesSuperseded

Changes in v2 from the cover letter

* kbuild spotted that I didn't delete all code in patch #5, so deleted even more ulp_ops derefences.
v1: https://lore.kernel.org/linux-rdma/[email protected]
* Go much deeper and removed useless ULP indirection
v0: https://lore.kernel.org/linux-rdma/[email protected]
-----------------------------------------------------------------------

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select itdrivers/infiniband/hw/bnxt_re/Kconfig+1 -31 reply
2/5RDMA/bnxt_re: Create direct symbolic link between bnxt modulesdrivers/infiniband/hw/bnxt_re/main.c drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt.h +1 more+2 -91 reply
3/5RDMA/bnxt_re: Get rid of custom module reference countingdrivers/infiniband/hw/bnxt_re/main.c+2 -141 reply
4/5net/bnxt: Remove useless check of non-existent ULP iddrivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h+73 -1220 replies
5/5net/bnxt: Use direct API instead of useless indirectiondrivers/infiniband/hw/bnxt_re/main.c drivers/net/ethernet/broadcom/bnxt/bnxt.c drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +1 more+55 -1260 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchDevesh Sharma
1/5A-b
2/5A-b
3/5A-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH rdma-next v2 0/5] Get rid of custom made module dependency

From: Leon Romanovsky <[email protected]>

Changelog:
v2:
* kbuild spotted that I didn't delete all code in patch #5, so deleted even more ulp_ops derefences.
v1: https://lore.kernel.org/linux-rdma/[email protected]
* Go much deeper and removed useless ULP indirection
v0: https://lore.kernel.org/linux-rdma/[email protected]
-----------------------------------------------------------------------

The following series fixes issue spotted in [1], where bnxt_re driver messed with module reference counting in order to implement symbol dependency of bnxt_re and bnxt modules. All of this is done, when in upstream we have only one ULP user of that bnxt module. The simple declaration of exported symbol would do the trick.

This series removes that custom module_get/_put, which is not supposed to be in the driver from the beginning and get rid of nasty indirection logic that isn't relevant for the upstream code.

Such small changes allow us to simplify the bnxt code and my hope that Devesh will continue where I stopped and remove struct bnxt_ulp_ops too.

Thanks

[1] https://lore.kernel.org/linux-rdma/[email protected]

Leon Romanovsky (5):
RDMA/bnxt_re: Depend on bnxt ethernet driver and not blindly select it RDMA/bnxt_re: Create direct symbolic link between bnxt modules RDMA/bnxt_re: Get rid of custom module reference counting net/bnxt: Remove useless check of non-existent ULP id net/bnxt: Use direct API instead of useless indirection

 drivers/infiniband/hw/bnxt_re/Kconfig         |   4 +-
 drivers/infiniband/hw/bnxt_re/main.c          |  93 ++-----
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |   4 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |   1 -
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 245 +++++++-----------
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h |  32 +--
 6 files changed, 119 insertions(+), 260 deletions(-)
Signature · 1 line
2.30.2