Skip to content

More parallel operations for the TDP MMU

Ben Gardon kvm lkml 2 versions – Applied

Status from this message: Applied to kvm/mmu-notifier-queue, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 8 repliesApplied
  2. v113 patches 17 repliesSuperseded

Changes in v2 from the cover letter

-- Rebased patches on top of kvm/queue to incorporate Sean's recent
TLB flushing changes
-- Dropped patch 5: "KVM: x86/mmu: comment for_each_tdp_mmu_root
requires MMU write lock" as the following patch to protect the roots list with RCU adds lockdep which makes the comment somewhat redundant.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/13KVM: x86/mmu: Re-add const qualifier in kvm_tdp_mmu_zap_collapsible_sptesarch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/mmu_internal.h arch/x86/kvm/mmu/tdp_mmu.c +2 more+14 -111 reply
2/13KVM: x86/mmu: Move kvm_mmu_(get|put)_root to TDP MMUarch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/mmu_internal.h arch/x86/kvm/mmu/tdp_mmu.c +1 more+25 -250 replies
3/13KVM: x86/mmu: use tdp_mmu_free_sp to free rootsarch/x86/kvm/mmu/tdp_mmu.c+7 -80 replies
4/13KVM: x86/mmu: Merge TDP MMU put and free rootarch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/tdp_mmu.c arch/x86/kvm/mmu/tdp_mmu.h+28 -400 replies
5/13KVM: x86/mmu: Refactor yield safe root iteratorarch/x86/kvm/mmu/tdp_mmu.c+26 -190 replies
6/13KVM: x86/mmu: Make TDP MMU root refcount atomicarch/x86/kvm/mmu/mmu_internal.h arch/x86/kvm/mmu/tdp_mmu.c arch/x86/kvm/mmu/tdp_mmu.h+14 -60 replies
7/13KVM: x86/mmu: handle cmpxchg failure in kvm_tdp_mmu_get_rootarch/x86/kvm/mmu/tdp_mmu.c arch/x86/kvm/mmu/tdp_mmu.h+9 -150 replies
8/13KVM: x86/mmu: Protect the tdp_mmu_roots list with RCUarch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu/tdp_mmu.c+55 -350 replies
9/13KVM: x86/mmu: Allow zap gfn range to operate under the mmu read lockarch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/tdp_mmu.c arch/x86/kvm/mmu/tdp_mmu.h+102 -452 replies
10/13KVM: x86/mmu: Allow zapping collapsible SPTEs to use MMU read lockarch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/tdp_mmu.c+23 -81 reply
11/13KVM: x86/mmu: Allow enabling / disabling dirty logging under MMU read lockarch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/tdp_mmu.c+61 -170 replies
12/13KVM: x86/mmu: Fast invalidation for TDP MMUarch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/tdp_mmu.h+26 -30 replies
13/13KVM: x86/mmu: Tear down roots in fast invalidation threadarch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/tdp_mmu.c arch/x86/kvm/mmu/tdp_mmu.h+89 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/13] More parallel operations for the TDP MMU

Now that the TDP MMU is able to handle page faults in parallel, it's a relatively small change to expand to other operations. This series allows zapping a range of GFNs, reclaiming collapsible SPTEs (when disabling dirty logging), and enabling dirty logging to all happen under the MMU lock in read mode.

This is partly a cleanup + rewrite of the last few patches of the parallel page faults series. I've incorporated feedback from Sean and Paolo, but the patches have changed so much that I'm sending this as a separate series.

Ran kvm-unit-tests + selftests on an SMP kernel + Intel Skylake, with the TDP MMU enabled and disabled. This series introduces no new failures or warnings.

I know this will conflict horribly with the patches from Sean's series which were just queued, and I'll send a v2 to fix those conflicts + address any feedback on this v1.

Changelog
v2:
-- Rebased patches on top of kvm/queue to incorporate Sean's recent
TLB flushing changes
-- Dropped patch 5: "KVM: x86/mmu: comment for_each_tdp_mmu_root
requires MMU write lock" as the following patch to protect the roots list with RCU adds lockdep which makes the comment somewhat redundant.

Ben Gardon (13):
KVM: x86/mmu: Re-add const qualifier in
kvm_tdp_mmu_zap_collapsible_sptes
KVM: x86/mmu: Move kvm_mmu_(get|put)_root to TDP MMU
KVM: x86/mmu: use tdp_mmu_free_sp to free roots
KVM: x86/mmu: Merge TDP MMU put and free root
KVM: x86/mmu: Refactor yield safe root iterator
KVM: x86/mmu: Make TDP MMU root refcount atomic
KVM: x86/mmu: handle cmpxchg failure in kvm_tdp_mmu_get_root
KVM: x86/mmu: Protect the tdp_mmu_roots list with RCU
KVM: x86/mmu: Allow zap gfn range to operate under the mmu read lock
KVM: x86/mmu: Allow zapping collapsible SPTEs to use MMU read lock
KVM: x86/mmu: Allow enabling / disabling dirty logging under MMU read
lock
KVM: x86/mmu: Fast invalidation for TDP MMU
KVM: x86/mmu: Tear down roots in fast invalidation thread

 arch/x86/include/asm/kvm_host.h |  21 +-
 arch/x86/kvm/mmu/mmu.c          | 115 +++++++---
 arch/x86/kvm/mmu/mmu_internal.h |  27 +--
 arch/x86/kvm/mmu/tdp_mmu.c      | 375 +++++++++++++++++++++++---------
 arch/x86/kvm/mmu/tdp_mmu.h      |  28 ++-
 include/linux/kvm_host.h        |   2 +-
 6 files changed, 407 insertions(+), 161 deletions(-)
Signature · 1 line
2.31.0.208.g409f899ff0-goog