Skip to content

dwarf_loader: improve cus__merging_cu()

Yonghong Song bpf dwarves 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 30 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dwarf_loader: check .debug_abbrev for cross-cu referencesdwarf_loader.c+24 -193 replies
2/2dwarf_loader: check .notes section for lto build infodwarf_loader.c+31 -20 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNick DesaulniersBill WendlingArnaldo Carvalho de Melo
SeriesR-b T-b T-b T-b T-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH dwarves 0/2] dwarf_loader: improve cus__merging_cu()

Function cus__merging_cu() is introduced in Commit 39227909db3c ("dwarf_loader: Permit merging all DWARF CU's for clang LTO built binary") to test whether cross-cu references may happen. The original implementation anticipates compilation flags in dwarf, but later some concerns about binary size surfaced and the decision is to scan .debug_abbrev as a faster way to check cross-cu references. Also putting a note in vmlinux to indicate whether lto is enabled for built or not can provide a much faster way.

This patch set implemented this two approaches, first checking the note (in Patch #2), if not found, then check .debug_abbrev (in Patch #1).

Yonghong Song (2):
dwarf_loader: check .debug_abbrev for cross-cu references
dwarf_loader: check .notes section for lto build info

 dwarf_loader.c | 76 ++++++++++++++++++++++++++++++++++++--------------
 1 file changed, 55 insertions(+), 21 deletions(-)
Signature · 1 line
2.30.2