qemu_iotests: improve debugging options
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest16 patches 1 replyIn review
- v816 patches 5 repliesSuperseded
- v716 patches 5 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 16 patches | 4 replies | Superseded | |
| v5 | 16 patches | 10 replies | Superseded | |
| v4 | 15 patches | 34 replies | Superseded | |
| v3 | 15 patches | 34 replies | Superseded | |
| v2 RFC | 11 patches | 15 replies | Superseded | |
| v1 RFC | 3 patches | 0 replies | Superseded |
Changes in v9 from the cover letter
* Replace ! -z with -n in bash scripts (patch 8), and quote $GDB_OPTIONS in the same if condition [Max]
* Add r-b from Max to all patches except 8, remove r-b from Vladimir on patch 8
Patches in v9 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | python: qemu: add timer parameter for qmp.accept socketpython/ python/ tests/ | +10 | 0 replies | |
| 2/16 | python: Reduce strictness of pylint's duplicate-code checkpython/ | +5 | 0 replies | |
| 3/16 | python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachinepython/ | +3 | 0 replies | |
| 4/16 | docs/devel/testing: add debug section to the QEMU iotests chapterdocs/ | +8 | 0 replies | |
| 5/16 | qemu-iotests: add option to attach gdbservertests/ tests/ tests/ | +25 | 0 replies | |
| 6/16 | qemu-iotests: delay QMP socket timerstests/ | +5 | 0 replies | |
| 7/16 | qemu_iotests: insert gdbserver command line as wrapper for qemu binarytests/ | +2 | 0 replies | |
| 8/16 | qemu-iotests: add gdbserver option to script tests tootests/ tests/ | +13 | 0 replies | |
| 9/16 | docs/devel/testing: add -gdb option to the debugging section of QEMU iotestsdocs/ | +11 | 0 replies | |
| 10/16 | qemu-iotests: extend the check script to prepare supporting valgrind for python teststests/ tests/ tests/ | +16 | 0 replies | |
| 11/16 | qemu-iotests: extend QMP socket timeout when using valgrindtests/ | +3 | 0 replies | |
| 12/16 | qemu-iotests: allow valgrind to read/delete the generated log filetests/ | +11 | 0 replies | |
| 13/16 | qemu-iotests: insert valgrind command line as wrapper for qemu binarytests/ | +5 | 0 replies | |
| 14/16 | docs/devel/testing: add -valgrind option to the debug section of QEMU iotestsdocs/ | +6 | 0 replies | |
| 15/16 | qemu-iotests: add option to show qemu binary logs on stdoutpython/ tests/ tests/ +1 more | +24 | 0 replies | |
| 16/16 | docs/devel/testing: add -p option to the debug section of QEMU iotestsdocs/ | +4 | 0 replies |
Reviews trailers per patch
15 of 16 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Sementsov-Ogievskiy | John Snow | Max Reitz |
|---|---|---|---|
| 1/16 | R-b | R-b A-b | R-b |
| 2/16 | R-b | A-b | R-b |
| 3/16 | R-b | R-b A-b | R-b |
| 4/16 | R-b | R-b | |
| 5/16 | R-b | R-b | |
| 6/16 | R-b | ||
| 7/16 | R-b | R-b | |
| 8/16 | |||
| 9/16 | R-b | R-b | |
| 10/16 | R-b | R-b | |
| 11/16 | R-b | R-b | |
| 12/16 | R-b | R-b | |
| 13/16 | R-b | R-b | |
| 14/16 | R-b | R-b | |
| 15/16 | R-b | R-b | |
| 16/16 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v9 00/16] qemu_iotests: improve debugging options
This series adds the option to attach gdbserver and valgrind to the QEMU binary running in qemu_iotests.
It also allows to redirect QEMU binaries output of the python tests to the stdout, instead of a log file.
Patches 1-9 introduce the -gdb option to both python and bash tests, 10-14 extend the already existing -valgrind flag to work also on python tests, and patch 15-16 introduces -p to enable logging to stdout.
In particular, patches 1,6,8,11 focus on extending the QMP socket timers when using gdb/valgrind, otherwise the python tests will fail due to delays in the QMP responses.
---
v9:
* Replace ! -z with -n in bash scripts (patch 8), and quote $GDB_OPTIONS in the same if condition [Max]
* Add r-b from Max to all patches except 8, remove r-b from Vladimir on patch 8
Emanuele Giuseppe Esposito (15):
python: qemu: add timer parameter for qmp.accept socket
python: qemu: pass the wrapper field from QEMUQtestmachine to
QEMUMachine
docs/devel/testing: add debug section to the QEMU iotests chapter
qemu-iotests: add option to attach gdbserver
qemu-iotests: delay QMP socket timers
qemu_iotests: insert gdbserver command line as wrapper for qemu binary
qemu-iotests: add gdbserver option to script tests too docs/devel/testing: add -gdb option to the debugging section of QEMU
iotests
qemu-iotests: extend the check script to prepare supporting valgrind
for python tests
qemu-iotests: extend QMP socket timeout when using valgrind
qemu-iotests: allow valgrind to read/delete the generated log file
qemu-iotests: insert valgrind command line as wrapper for qemu binary docs/devel/testing: add -valgrind option to the debug section of QEMU
iotests
qemu-iotests: add option to show qemu binary logs on stdout docs/devel/testing: add -p option to the debug section of QEMU iotests
John Snow (1):
python: Reduce strictness of pylint's duplicate-code check
docs/devel/testing.rst | 29 ++++++++++++++++++++ python/qemu/machine/machine.py | 16 +++++++---- python/qemu/machine/qtest.py | 9 ++++--- python/setup.cfg | 5 ++++ tests/qemu-iotests/check | 15 ++++++++--- tests/qemu-iotests/common.qemu | 7 ++++- tests/qemu-iotests/common.rc | 8 +++++- tests/qemu-iotests/iotests.py | 49 ++++++++++++++++++++++++++++++++-- tests/qemu-iotests/testenv.py | 23 ++++++++++++++-- 9 files changed, 143 insertions(+), 18 deletions(-)
Signature · 1 line
2.31.1