Skip to content

qemu_iotests: improve debugging options

Emanuele Giuseppe Esposito qemu-devel 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest16 patches 1 replyIn review
  2. v816 patches 5 repliesSuperseded
  3. v716 patches 5 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v616 patches4 repliesSuperseded
v516 patches10 repliesSuperseded
v415 patches34 repliesSuperseded
v315 patches34 repliesSuperseded
v2 RFC11 patches15 repliesSuperseded
v1 RFC3 patches0 repliesSuperseded

Changes in v9 from the cover letter

* Replace ! -z with -n in bash scripts (patch 8), and quote $GDB_OPTIONS in the same if condition [Max]
* Add r-b from Max to all patches except 8, remove r-b from Vladimir on patch 8

Patches in v9 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16python: qemu: add timer parameter for qmp.accept socketpython/qemu/machine/machine.py python/qemu/machine/qtest.py tests/qemu-iotests/iotests.py+10 -50 replies
2/16python: Reduce strictness of pylint's duplicate-code checkpython/setup.cfg+5 -00 replies
3/16python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachinepython/qemu/machine/qtest.py+3 -10 replies
4/16docs/devel/testing: add debug section to the QEMU iotests chapterdocs/devel/testing.rst+8 -00 replies
5/16qemu-iotests: add option to attach gdbservertests/qemu-iotests/check tests/qemu-iotests/iotests.py tests/qemu-iotests/testenv.py+25 -30 replies
6/16qemu-iotests: delay QMP socket timerstests/qemu-iotests/iotests.py+5 -10 replies
7/16qemu_iotests: insert gdbserver command line as wrapper for qemu binarytests/qemu-iotests/iotests.py+2 -10 replies
8/16qemu-iotests: add gdbserver option to script tests tootests/qemu-iotests/common.qemu tests/qemu-iotests/common.rc+13 -20 replies
9/16docs/devel/testing: add -gdb option to the debugging section of QEMU iotestsdocs/devel/testing.rst+11 -00 replies
10/16qemu-iotests: extend the check script to prepare supporting valgrind for python teststests/qemu-iotests/check tests/qemu-iotests/iotests.py tests/qemu-iotests/testenv.py+16 -30 replies
11/16qemu-iotests: extend QMP socket timeout when using valgrindtests/qemu-iotests/iotests.py+3 -30 replies
12/16qemu-iotests: allow valgrind to read/delete the generated log filetests/qemu-iotests/iotests.py+11 -00 replies
13/16qemu-iotests: insert valgrind command line as wrapper for qemu binarytests/qemu-iotests/iotests.py+5 -10 replies
14/16docs/devel/testing: add -valgrind option to the debug section of QEMU iotestsdocs/devel/testing.rst+6 -00 replies
15/16qemu-iotests: add option to show qemu binary logs on stdoutpython/qemu/machine/machine.py tests/qemu-iotests/check tests/qemu-iotests/iotests.py +1 more+24 -60 replies
16/16docs/devel/testing: add -p option to the debug section of QEMU iotestsdocs/devel/testing.rst+4 -00 replies

Reviews trailers per patch

15 of 16 patches have a Reviewed-by or Acked-by.

PatchVladimir Sementsov-OgievskiyJohn SnowMax Reitz
1/16R-b R-b A-b R-b
2/16R-b A-b R-b
3/16R-b R-b A-b R-b
4/16R-b R-b
5/16R-b R-b
6/16R-b
7/16R-b R-b
8/16
9/16R-b R-b
10/16R-b R-b
11/16R-b R-b
12/16R-b R-b
13/16R-b R-b
14/16R-b R-b
15/16R-b R-b
16/16R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v9 thread

Cover letter [PATCH v9 00/16] qemu_iotests: improve debugging options

This series adds the option to attach gdbserver and valgrind to the QEMU binary running in qemu_iotests.
It also allows to redirect QEMU binaries output of the python tests to the stdout, instead of a log file.

Patches 1-9 introduce the -gdb option to both python and bash tests, 10-14 extend the already existing -valgrind flag to work also on python tests, and patch 15-16 introduces -p to enable logging to stdout.

In particular, patches 1,6,8,11 focus on extending the QMP socket timers when using gdb/valgrind, otherwise the python tests will fail due to delays in the QMP responses.

---
v9:
* Replace ! -z with -n in bash scripts (patch 8), and quote $GDB_OPTIONS in the same if condition [Max]
* Add r-b from Max to all patches except 8, remove r-b from Vladimir on patch 8

Emanuele Giuseppe Esposito (15):
python: qemu: add timer parameter for qmp.accept socket
python: qemu: pass the wrapper field from QEMUQtestmachine to
QEMUMachine
docs/devel/testing: add debug section to the QEMU iotests chapter
qemu-iotests: add option to attach gdbserver
qemu-iotests: delay QMP socket timers
qemu_iotests: insert gdbserver command line as wrapper for qemu binary
qemu-iotests: add gdbserver option to script tests too docs/devel/testing: add -gdb option to the debugging section of QEMU
iotests
qemu-iotests: extend the check script to prepare supporting valgrind
for python tests
qemu-iotests: extend QMP socket timeout when using valgrind
qemu-iotests: allow valgrind to read/delete the generated log file
qemu-iotests: insert valgrind command line as wrapper for qemu binary docs/devel/testing: add -valgrind option to the debug section of QEMU
iotests
qemu-iotests: add option to show qemu binary logs on stdout docs/devel/testing: add -p option to the debug section of QEMU iotests

John Snow (1):
python: Reduce strictness of pylint's duplicate-code check

 docs/devel/testing.rst         | 29 ++++++++++++++++++++
 python/qemu/machine/machine.py | 16 +++++++----
 python/qemu/machine/qtest.py   |  9 ++++---
 python/setup.cfg               |  5 ++++
 tests/qemu-iotests/check       | 15 ++++++++---
 tests/qemu-iotests/common.qemu |  7 ++++-
 tests/qemu-iotests/common.rc   |  8 +++++-
 tests/qemu-iotests/iotests.py  | 49 ++++++++++++++++++++++++++++++++--
 tests/qemu-iotests/testenv.py  | 23 ++++++++++++++--
 9 files changed, 143 insertions(+), 18 deletions(-)
Signature · 1 line
2.31.1