Skip to content

iio: Use IRQF_NO_AUTOEN

Jonathan Cameron linux-iio 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7iio:adc:ad7766: Use new IRQF_NO_AUTOEN to reduce boilerplatedrivers/iio/adc/ad7766.c+7 -82 replies
2/7iio:adc:exynos-adc: Use new IRQF_NO_AUTOEN flag rather than separate irq_disable()drivers/iio/adc/exynos_adc.c+2 -23 replies
3/7iio:adc:nau7802: Use IRQF_NO_AUTOEN instead of request then disabledrivers/iio/adc/nau7802.c+3 -32 replies
4/7iio:adc:sun4i-gpadc: Use new IRQF_NO_AUTOEN flag instead of request then disabledrivers/iio/adc/sun4i-gpadc-iio.c+2 -22 replies
5/7iio:chemical:scd30: Use IRQF_NO_AUTOEN to avoid irq request then disabledrivers/iio/chemical/scd30_core.c+8 -82 replies
6/7iio:imu:adis: Use IRQF_NO_AUTOEN instead of irq request then disabledrivers/iio/imu/adis16460.c drivers/iio/imu/adis16475.c drivers/iio/imu/adis_trigger.c+11 -93 replies
7/7iio:adc:ad_sigma_delta: Use IRQF_NO_AUTOEN rather than request and disabledrivers/iio/adc/ad_sigma_delta.c+2 -53 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy ShevchenkoBarry SongLars-Peter ClausenKrzysztof KozlowskiNuno Sa
SeriesR-b R-b
1/7R-b
2/7R-b R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] iio: Use IRQF_NO_AUTOEN

From: Jonathan Cameron <[email protected]>

This series is dependant on
cbe16f35bee68 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()") which is available in an immutable tag in the tip tree.
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/tag/?h=irq-no-autoen-2021-03-25
which I'll merge in to the IIO tree if we need it before it's available upstream.

That patch introduces a new IRQF_NO_AUTOEN flag for irq requests to avoid the current dance where we either mark an irq as not to be autoenabled before we know if we can actually request it succesfully, or (as IIO drivers seem to have gone with) we disable the interrupt just after requesting it. In short the flag stops the interrupt being autoenabled in the first place.

So this series applies this magic to IIO :)

Note these are all just compile tested and some of them aren't entirely trivial because of other aspects of the irq flag handling.

Jonathan Cameron (7):
iio:adc:ad7766: Use new IRQF_NO_AUTOEN to reduce boilerplate iio:adc:exynos-adc: Use new IRQF_NO_AUTOEN flag rather than separate
irq_disable()
iio:adc:nau7802: Use IRQF_NO_AUTOEN instead of request then disable iio:adc:sun4i-gpadc: Use new IRQF_NO_AUTOEN flag instead of request
then disable
iio:chemical:scd30: Use IRQF_NO_AUTOEN to avoid irq request then
disable
iio:imu:adis: Use IRQF_NO_AUTOEN instead of irq request then disable iio:adc:ad_sigma_delta: Use IRQF_NO_AUTOEN rather than request and
disable

 drivers/iio/adc/ad7766.c          | 15 +++++++--------
 drivers/iio/adc/ad_sigma_delta.c  |  7 ++-----
 drivers/iio/adc/exynos_adc.c      |  4 ++--
 drivers/iio/adc/nau7802.c         |  6 +++---
 drivers/iio/adc/sun4i-gpadc-iio.c |  4 ++--
 drivers/iio/chemical/scd30_core.c | 16 ++++++++--------
 drivers/iio/imu/adis16460.c       |  4 ++--
 drivers/iio/imu/adis16475.c       |  5 +++--
 drivers/iio/imu/adis_trigger.c    | 11 ++++++-----
 9 files changed, 35 insertions(+), 37 deletions(-)
Signature · 1 line
2.31.1