Cleaning up some of the irqdomain features
Status from this message: The following commit has been merged into the irq/irqchip-next branch of irqchip:
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | irqdomain: Reimplement irq_linear_revmap() with irq_find_mapping()include/ kernel/ | +12 | 2 replies | |
| 2/9 | ARM: PXA: Kill use of irq_create_strict_mappings()arch/ | +11 | 3 replies | |
| 3/9 | irqchip/jcore-aic: Kill use of irq_create_strict_mappings()drivers/ | +2 | 0 replies | |
| 4/9 | sh: intc: Drop the use of irq_create_identity_mapping()drivers/ | +21 | 2 replies | |
| 5/9 | irqdomain: Kill irq_create_strict_mappings()/irq_create_identity_mapping()include/ kernel/ | +0 | 0 replies | |
| 6/9 | mips: netlogic: Use irq_domain_simple_ops for XLP PICarch/ | +1 | 1 reply | |
| 7/9 | irqdomain: Drop references to recusive irqdomain setupkernel/ | +2 | 0 replies | |
| 8/9 | powerpc: Convert irq_domain_add_legacy_isa use to irq_domain_add_legacyarch/ arch/ arch/ +3 more | +10 | 0 replies | |
| 9/9 | irqdomain: Kill irq_domain_add_legacy_isaDocumentation/ include/ | +0 | 0 replies |
Reviews trailers per patch
1 of 9 patches has a Reviewed-by or Acked-by.
| Patch | Geert Uytterhoeven | Thomas Bogendoerfer | Guenter Roeck |
|---|---|---|---|
| 1/9 | |||
| 2/9 | T-b | ||
| 3/9 | |||
| 4/9 | T-b | ||
| 5/9 | |||
| 6/9 | A-b | ||
| 7/9 | |||
| 8/9 | |||
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/9] Cleaning up some of the irqdomain features
The irqdomain subsystem has grown quite a lot over the years, and some of its features are either oddly used or just pretty useless. Some other helpers expose internals that are likely to change soon.
Here are the bits that I'm trying to get rid of:
- irq_linear_revmap exposes the internals of the domains, and only works for linear domains. The supposed speed improvement really isn't an argument, as it gets in the way of more significant optimisations. Reimplemented in terms of irq_find_mapping, which always works, and will eventually go at some point.
- irq_create_strict_mappings is just a way to constraint the allocation of irqdescs into a given range, which is better served by creating a legacy irqdomain, and shows that the platform really needs to catch up with the 21st century.
- irq_create_identity mapping is just a variation on the above, with irq==hwirq, although the way it is used is a gross hack in the SH code that needs to go.
- irq_domain_add_legacy_isa is, as the names shows, a variation on irq_domain_add_legacy with a reservation of 16 interrupts. This is only used in the PPC code.
The patches address all of the above, touching some of the ARM, PPC, and SH code that is affected. Another couple of patches address a MIPS platform that could use the generic code, and clean some of the comments in the irqdomain code.
Unless anyone shouts, I'd like to take this into 5.13, as it is the basis of some further (and deeper) changes in the way irqdomains work.
M.
Marc Zyngier (9):
irqdomain: Reimplement irq_linear_revmap() with irq_find_mapping()
ARM: PXA: Kill use of irq_create_strict_mappings() irqchip/jcore-aic: Kill use of irq_create_strict_mappings()
sh: intc: Drop the use of irq_create_identity_mapping()
irqdomain: Kill
irq_create_strict_mappings()/irq_create_identity_mapping()
mips: netlogic: Use irq_domain_simple_ops for XLP PIC
irqdomain: Drop references to recusive irqdomain setup
powerpc: Convert irq_domain_add_legacy_isa use to
irq_domain_add_legacy
irqdomain: Kill irq_domain_add_legacy_isa
Documentation/core-api/irq/irq-domain.rst | 1 - arch/arm/mach-pxa/pxa_cplds_irqs.c | 24 +++++------ arch/mips/netlogic/common/irq.c | 6 +-- arch/powerpc/include/asm/irq.h | 4 +- arch/powerpc/platforms/ps3/interrupt.c | 4 +- arch/powerpc/sysdev/i8259.c | 3 +- arch/powerpc/sysdev/mpic.c | 2 +- arch/powerpc/sysdev/tsi108_pci.c | 3 +- arch/powerpc/sysdev/xics/xics-common.c | 2 +- drivers/irqchip/irq-jcore-aic.c | 4 +- drivers/sh/intc/core.c | 50 ++++++++++------------- include/linux/irqdomain.h | 42 ++++--------------- kernel/irq/irqdomain.c | 49 +++------------------- 13 files changed, 59 insertions(+), 135 deletions(-)
Signature · 1 line
2.29.2