Skip to content

BCM2711 sdhci-iproc improvements

Nicolas Saenz Julienne linux-arm-kernel linux-devicetree linux-mmc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: mmc: iproc-sdhci: Convert to json-schemaDocumentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt+63 -373 replies
2/3mmc: sdhci-iproc: Cap min clock frequency on BCM2711drivers/mmc/host/sdhci-iproc.c+18 -03 replies
3/3mmc: sdhci-iproc: Set SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN on BCM2711drivers/mmc/host/sdhci-iproc.c+2 -10 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] BCM2711 sdhci-iproc improvements

This is a follow-up series to "BCM2711's sdhci-iproc CMD timeouts"[1], but since much most of the patches changed I decided to start counting patch revisions from scratch.

This series tries to address rather odd behavior from BCM2711's integration of sdhci-iproc (Raspberry Pi 4's SoC). The controller will timeout on SDHCI CMDs under the following conditions:

- No SD card plugged in (the card polling thread is running, CD irq disabled).
- BCM2711's VPU clock configured at 500MHz or more, lower clocks are OK.

There is no specific command that will time out, it seems random.

As an extra to this I also include a small fix, and convert the controller's bindings to yaml.

Regards,
Nicolas

[1] https://lore.kernel.org/linux-mmc/[email protected]/

---

Nicolas Saenz Julienne (3):
dt-bindings: mmc: iproc-sdhci: Convert to json-schema
mmc: sdhci-iproc: Cap min clock frequency on BCM2711
mmc: sdhci-iproc: Set SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN on BCM2711

 .../bindings/mmc/brcm,iproc-sdhci.yaml        | 63 +++++++++++++++++++
 .../bindings/mmc/brcm,sdhci-iproc.txt         | 37 -----------
 drivers/mmc/host/sdhci-iproc.c                | 21 ++++++-
 3 files changed, 83 insertions(+), 38 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml
 delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt
Signature · 1 line
2.30.2