Skip to content

Add support for ECDSA-signed kernel modules

Stefan Berger keyrings linux-integrity linux-security-module lkml 7 versions – Applied

Status from this message: I applied the fixes and squashed them to appriopriate commits.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 10 repliesApplied
  2. v5 posting 2/22 patches 6 repliesSuperseded
  3. v5 posting 1/22 patches 1 replySuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v42 patches3 repliesSuperseded
v32 patches2 repliesSuperseded
v22 patches9 repliesSuperseded
v12 patches4 repliesSuperseded

Changes in v6 from the cover letter

- Patch 2/4 is fixing V4's 1/2 and 4/4 is fixing V4's 2/2. Both fixup patches to be squashed.

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/4certs: Trigger creation of RSA module signing key if it's not an RSA keycerts/Makefile+5 -00 replies
2/4certs: Check whether openssl tool is availablecerts/Makefile+3 -00 replies
3/4certs: Add support for using elliptic curve keys for signing modulescerts/Kconfig certs/Makefile crypto/asymmetric_keys/pkcs7_parser.c+42 -00 replies
4/4certs: Adjustment due to 'Check whether openssl tool is available'certs/Makefile+5 -05 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchJarkko SakkinenMimi Zohar
1/4R-b T-b
2/4
3/4A-b T-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/4] Add support for ECDSA-signed kernel modules

This series adds support for ECDSA-signed kernel modules. It also attempts to address a kbuild issue where a developer created an ECDSA key for signing kernel modules and then builds an older version of the kernel, when bisecting the kernel for example, that does not support ECDSA keys.

The first patch addresses the kbuild issue of needing to delete that ECDSA key if it is in certs/signing_key.pem and trigger the creation of an RSA key. However, for this to work this patch would have to be backported to previous versions of the kernel but would also only work for the developer if he/she used a stable version of the kernel to which this patch was applied. So whether this patch actually achieves the wanted effect is not always guaranteed.

The 2nd patch adds the support for the ECSDA-signed kernel modules.

This patch depends on the ECDSA support series currently queued here:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/log/?h=ecc

Stefan

v6:
- Patch 2/4 is fixing V4's 1/2 and 4/4 is fixing V4's 2/2. Both fixup patches to be squashed.

v5:
- do not touch the key files if openssl is not installed; likely addresses an issue pointed out by kernel test robot

v4:
- extending 'depends on' with MODULES to (IMA_APPRAISE_MODSIG && MODULES)

v3:
- added missing OIDs for ECDSA signed hashes to pkcs7_sig_note_pkey_algo
- added recommendation to use string hash to Kconfig help text

v2:
- Adjustment to ECDSA key detector string in 2/2
- Rephrased cover letter and patch descriptions with Mimi

Stefan Berger (4):
certs: Trigger creation of RSA module signing key if it's not an RSA
key
certs: Check whether openssl tool is available
certs: Add support for using elliptic curve keys for signing modules
certs: Adjustment due to 'Check whether openssl tool is available'

 certs/Kconfig                         | 26 ++++++++++++++++++++++++++
 certs/Makefile                        | 21 +++++++++++++++++++++
 crypto/asymmetric_keys/pkcs7_parser.c |  8 ++++++++
 3 files changed, 55 insertions(+)
Signature · 1 line
2.29.2