Skip to content

USB: serial: TIOCSSERIAL fixes and generic support

Johan Hovold linux-usb lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24USB: serial: ark3116: fix TIOCGSERIAL implementationdrivers/usb/serial/ark3116.c+3 -20 replies
2/24USB: serial: f81232: fix TIOCGSERIAL implementationdrivers/usb/serial/f81232.c+3 -10 replies
3/24USB: serial: f81534: fix TIOCGSERIAL implementationdrivers/usb/serial/f81534.c+3 -10 replies
4/24USB: serial: ftdi_sio: fix TIOCGSERIAL implementationdrivers/usb/serial/ftdi_sio.c+4 -00 replies
5/24USB: serial: io_edgeport: fix TIOCGSERIAL implementationdrivers/usb/serial/io_edgeport.c+4 -80 replies
6/24USB: serial: io_ti: fix TIOCGSERIAL implementationdrivers/usb/serial/io_ti.c+4 -80 replies
7/24USB: serial: mos7720: fix TIOCGSERIAL implementationdrivers/usb/serial/mos7720.c+4 -80 replies
8/24USB: serial: mos7840: fix TIOCGSERIAL implementationdrivers/usb/serial/mos7840.c+4 -80 replies
9/24USB: serial: opticon: fix TIOCGSERIAL implementationdrivers/usb/serial/opticon.c+3 -60 replies
10/24USB: serial: pl2303: fix TIOCGSERIAL implementationdrivers/usb/serial/pl2303.c+3 -20 replies
11/24USB: serial: quatech2: fix TIOCGSERIAL implementationdrivers/usb/serial/quatech2.c+3 -60 replies
12/24USB: serial: ssu100: fix TIOCGSERIAL implementationdrivers/usb/serial/ssu100.c+3 -60 replies
13/24USB: serial: ti_usb_3410_5052: fix TIOCGSERIAL implementationdrivers/usb/serial/ti_usb_3410_5052.c+2 -20 replies
14/24USB: serial: ti_usb_3410_5052: fix TIOCSSERIAL permission checkdrivers/usb/serial/ti_usb_3410_5052.c+7 -20 replies
15/24USB: serial: usb_wwan: fix TIOCSSERIAL jiffies conversionsdrivers/usb/serial/usb_wwan.c+5 -40 replies
16/24USB: serial: usb_wwan: fix unprivileged TIOCCSERIALdrivers/usb/serial/usb_wwan.c+0 -20 replies
17/24USB: serial: usb_wwan: fix TIOCGSERIAL implementationdrivers/usb/serial/usb_wwan.c+0 -20 replies
18/24USB: serial: whiteheat: fix TIOCGSERIAL implementationdrivers/usb/serial/whiteheat.c+2 -60 replies
19/24USB: serial: fix return value for unsupported ioctlsdrivers/usb/serial/usb-serial.c+3 -30 replies
20/24USB: serial: add generic support for TIOCSSERIALdrivers/usb/serial/ark3116.c drivers/usb/serial/f81232.c drivers/usb/serial/f81534.c +16 more+70 -2260 replies
21/24USB: serial: stop reporting legacy UART typesdrivers/usb/serial/ark3116.c drivers/usb/serial/f81232.c drivers/usb/serial/f81534.c +8 more+0 -580 replies
22/24USB: serial: ftdi_sio: ignore baud_base changesdrivers/usb/serial/ftdi_sio.c+0 -40 replies
23/24USB: serial: ftdi_sio: simplify TIOCGSERIAL permission checkdrivers/usb/serial/ftdi_sio.c+1 -120 replies
24/24USB: serial: ftdi_sio: clean up TIOCSSERIALdrivers/usb/serial/ftdi_sio.c+7 -60 replies

Reviews trailers per patch

None of the 24 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGreg Kroah-Hartman
SeriesR-b
1/24
2/24
3/24
4/24
5/24
6/24
7/24
8/24
9/24
10/24
11/24
12/24
13/24
14/24
15/24
16/24
17/24
18/24
19/24
20/24
21/24
22/24
23/24
24/24

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/24] USB: serial: TIOCSSERIAL fixes and generic support

TIOCSSERIAL is a horrid, underspecified, legacy interface which for most serial devices is only useful for setting the close_delay and closing_wait parameters.

This series fixes up the various USB serial driver implementations, before adding generic support to core for the benefit of all USB serial drivers.

Johan

Johan Hovold (24):
USB: serial: ark3116: fix TIOCGSERIAL implementation
USB: serial: f81232: fix TIOCGSERIAL implementation
USB: serial: f81534: fix TIOCGSERIAL implementation
USB: serial: ftdi_sio: fix TIOCGSERIAL implementation
USB: serial: io_edgeport: fix TIOCGSERIAL implementation
USB: serial: io_ti: fix TIOCGSERIAL implementation
USB: serial: mos7720: fix TIOCGSERIAL implementation
USB: serial: mos7840: fix TIOCGSERIAL implementation
USB: serial: opticon: fix TIOCGSERIAL implementation
USB: serial: pl2303: fix TIOCGSERIAL implementation
USB: serial: quatech2: fix TIOCGSERIAL implementation
USB: serial: ssu100: fix TIOCGSERIAL implementation
USB: serial: ti_usb_3410_5052: fix TIOCGSERIAL implementation
USB: serial: ti_usb_3410_5052: fix TIOCSSERIAL permission check
USB: serial: usb_wwan: fix TIOCSSERIAL jiffies conversions
USB: serial: usb_wwan: fix unprivileged TIOCCSERIAL
USB: serial: usb_wwan: fix TIOCGSERIAL implementation
USB: serial: whiteheat: fix TIOCGSERIAL implementation
USB: serial: fix return value for unsupported ioctls
USB: serial: add generic support for TIOCSSERIAL
USB: serial: stop reporting legacy UART types
USB: serial: ftdi_sio: ignore baud_base changes
USB: serial: ftdi_sio: simplify TIOCGSERIAL permission check
USB: serial: ftdi_sio: clean up TIOCSSERIAL

 drivers/usb/serial/ark3116.c          | 13 ------
 drivers/usb/serial/f81232.c           | 11 ++---
 drivers/usb/serial/f81534.c           |  7 +---
 drivers/usb/serial/ftdi_sio.c         | 35 ++++------------
 drivers/usb/serial/io_edgeport.c      | 22 ----------
 drivers/usb/serial/io_ti.c            | 24 -----------
 drivers/usb/serial/mos7720.c          | 18 --------
 drivers/usb/serial/mos7840.c          | 23 -----------
 drivers/usb/serial/opticon.c          | 18 --------
 drivers/usb/serial/option.c           |  2 -
 drivers/usb/serial/pl2303.c           | 13 ------
 drivers/usb/serial/quatech2.c         | 16 --------
 drivers/usb/serial/ssu100.c           | 16 --------
 drivers/usb/serial/ti_usb_3410_5052.c | 38 +----------------
 drivers/usb/serial/usb-serial.c       | 59 +++++++++++++++++++++++----
 drivers/usb/serial/usb-wwan.h         |  4 --
 drivers/usb/serial/usb_wwan.c         | 45 --------------------
 drivers/usb/serial/whiteheat.c        | 17 +-------
 include/linux/usb/serial.h            |  2 +-
 19 files changed, 69 insertions(+), 314 deletions(-)
Signature · 1 line
2.26.3