Skip to content

tty.h cleanups

Greg Kroah-Hartman lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13tty: create internal tty.h filedrivers/tty/n_tty.c drivers/tty/pty.c drivers/tty/tty.h +5 more+27 -120 replies
2/13tty: tty.h: remove tty_info()drivers/tty/tty.h+0 -10 replies
3/13tty: remove tty_err()drivers/tty/n_tty.c drivers/tty/tty.h drivers/tty/tty_io.c+2 -30 replies
4/13tty: remove tty_notice()drivers/tty/tty.h drivers/tty/tty_io.c+3 -40 replies
5/13tty: remove tty_warn()drivers/tty/n_tty.c drivers/tty/tty.h drivers/tty/tty_io.c +2 more+8 -92 replies
6/13tty: remove tty_info_ratelimited()drivers/tty/tty.h drivers/tty/tty_io.c+1 -40 replies
7/13tty: remove tty_debug()drivers/tty/pty.c drivers/tty/tty.h drivers/tty/tty_io.c +3 more+12 -170 replies
8/13tty: audit: move some local functions out of tty.hdrivers/tty/tty.h drivers/tty/tty_audit.c include/linux/tty.h+15 -100 replies
9/13tty: move some internal tty lock enums and functions out of tty.hdrivers/tty/tty.h drivers/tty/tty_buffer.c drivers/tty/tty_mutex.c +1 more+28 -270 replies
10/13tty: make tty_release_redirect() staticdrivers/tty/tty_io.c include/linux/tty.h+1 -30 replies
11/13tty: move some tty-only functions to drivers/tty/tty.hdrivers/tty/tty.h drivers/tty/tty_ioctl.c include/linux/tty.h+18 -160 replies
12/13tty: remove tty_driver_name()drivers/tty/tty_io.c include/linux/tty.h+0 -80 replies
13/13tty: clean include/linux/tty.h updrivers/tty/n_gsm.c drivers/tty/n_hdlc.c drivers/tty/tty.h +1 more+39 -341 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] tty.h cleanups

Turns out there is a lot of tty-internal stuff in include/linux/tty.h that do not belong there. Create a internal-to-the-tty-layer .h file for these types of things and move function prototypes to it instead of being in the system-wide header file.

Along the way clean up the use of some old tty-only debugging macros and use the in-kernel dev_*() calls instead.

Greg Kroah-Hartman (13):
tty: create internal tty.h file
tty: tty.h: remove tty_info()
tty: remove tty_err()
tty: remove tty_notice()
tty: remove tty_warn()
tty: remove tty_info_ratelimited()
tty: remove tty_debug()
tty: audit: move some local functions out of tty.h
tty: move some internal tty lock enums and functions out of tty.h
tty: make tty_release_redirect() static
tty: move some tty-only functions to drivers/tty/tty.h
tty: remove tty_driver_name()
tty: clean include/linux/tty.h up

 drivers/tty/n_gsm.c       |   1 +
 drivers/tty/n_hdlc.c      |   1 +
 drivers/tty/n_tty.c       |   5 +-
 drivers/tty/pty.c         |   3 +-
 drivers/tty/tty.h         | 103 ++++++++++++++++++++++++++++++++++++++
 drivers/tty/tty_audit.c   |   1 +
 drivers/tty/tty_buffer.c  |   2 +-
 drivers/tty/tty_io.c      |  43 +++++++---------
 drivers/tty/tty_ioctl.c   |   3 +-
 drivers/tty/tty_jobctrl.c |   7 +--
 drivers/tty/tty_ldisc.c   |   3 +-
 drivers/tty/tty_mutex.c   |   1 +
 drivers/tty/tty_port.c    |   5 +-
 include/linux/tty.h       | 100 ------------------------------------
 14 files changed, 142 insertions(+), 136 deletions(-)
 create mode 100644 drivers/tty/tty.h
Signature · 1 line
2.31.1