Skip to content

drivers: introduce mlx5 crypto PMD

Shiri Kuzin dpdk-dev 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest16 patches 29 repliesIn review
  2. v716 patches 0 repliesSuperseded
  3. v615 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v515 patches7 repliesSuperseded
v124 patches1 replySuperseded

Changes in v8 from the cover letter

- Add a test case that was removed by error.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16drivers: introduce mlx5 crypto PMDMAINTAINERS doc/guides/cryptodevs/features/mlx5.ini doc/guides/cryptodevs/index.rst +10 more+450 -102 replies
2/16crypto/mlx5: add DEK object managementdrivers/crypto/mlx5/meson.build drivers/crypto/mlx5/mlx5_crypto.c drivers/crypto/mlx5/mlx5_crypto.h +1 more+239 -165 replies
3/16crypto/mlx5: add session operationsdoc/guides/cryptodevs/features/mlx5.ini doc/guides/cryptodevs/mlx5.rst drivers/crypto/mlx5/mlx5_crypto.c+182 -56 replies
4/16crypto/mlx5: add basic operationsdrivers/crypto/mlx5/mlx5_crypto.c drivers/crypto/mlx5/mlx5_crypto.h+20 -72 replies
5/16crypto/mlx5: add queue pairs operationsdrivers/crypto/mlx5/mlx5_crypto.c drivers/crypto/mlx5/mlx5_crypto.h+137 -30 replies
6/16crypto/mlx5: add dev stop and start operationsdrivers/crypto/mlx5/mlx5_crypto.c+15 -22 replies
7/16crypto/mlx5: add memory region managementdoc/guides/cryptodevs/mlx5.rst drivers/crypto/mlx5/mlx5_crypto.c drivers/crypto/mlx5/mlx5_crypto.h+72 -00 replies
8/16crypto/mlx5: create login object using DevXdoc/guides/cryptodevs/mlx5.rst drivers/crypto/mlx5/mlx5_crypto.c drivers/crypto/mlx5/mlx5_crypto.h+170 -00 replies
9/16crypto/mlx5: add keytag devargdoc/guides/cryptodevs/mlx5.rst drivers/crypto/mlx5/mlx5_crypto.c drivers/crypto/mlx5/mlx5_crypto.h+37 -230 replies
10/16crypto/mlx5: add maximum segments devargdoc/guides/cryptodevs/mlx5.rst drivers/crypto/mlx5/mlx5_crypto.c drivers/crypto/mlx5/mlx5_crypto.h+39 -40 replies
11/16crypto/mlx5: add WQE set initializationdrivers/crypto/mlx5/mlx5_crypto.c drivers/crypto/mlx5/mlx5_crypto.h+87 -60 replies
12/16crypto/mlx5: add enqueue and dequeue operationsdoc/guides/cryptodevs/features/mlx5.ini drivers/crypto/mlx5/mlx5_crypto.c drivers/crypto/mlx5/mlx5_crypto.h+290 -40 replies
13/16crypto/mlx5: add statistic get and reset operationsdrivers/crypto/mlx5/mlx5_crypto.c+37 -30 replies
14/16test/crypto: add mlx5 crypto driverapp/test/test_cryptodev.c app/test/test_cryptodev.h doc/guides/cryptodevs/mlx5.rst+12 -01 reply
15/16test/crypto: add data-unit and wrapped vectorsapp/test/test_cryptodev.h app/test/test_cryptodev_aes_test_vectors.h app/test/test_cryptodev_blockcipher.c +1 more+1352 -23 replies
16/16test/crypto: add AES-XTS multi segment OOP testsapp/test/test_cryptodev_aes_test_vectors.h+64 -01 reply

Reviews trailers per patch

11 of 16 patches have a Reviewed-by or Acked-by.

PatchMatan Azrad
1/16A-b
2/16A-b
3/16A-b
4/16A-b
5/16A-b
6/16A-b
7/16A-b
8/16A-b
9/16
10/16
11/16
12/16
13/16
14/16A-b
15/16A-b
16/16A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [dpdk-dev] [PATCH v8 00/16] drivers: introduce mlx5 crypto PMD

v2:
- Add data-path part.

v3:
- Rebase.

v4:
- Rebase + Address the following Akhil comments:
- Set HW feature flag in the capability patch.
- Fix mp object release in session clear.
- Some spelling and word missing in doc.
- Squash data-unit adjustment to the session operations commit.
- Wording: device argument -> devarg.

v5:
- Add mlx5 crypto tests into test library.
- Update documentation according to Akhil comments.
- Fix memory region management.
- Fix multi segment case in data-path code.
- Split documentation to the correct commits according to Akhil comments.
- Rebase to new version.
- Change license to Nvidia license.

v6:
- Rebase to new version.
- Address David's comment and update log accordingly.
- Update testing app commits as suggested by Akhil.

v7:
- Rebase to new version.
- Add scatter gather and OOP test cases.

v8:
- Add a test case that was removed by error.

Shiri Kuzin (11):
drivers: introduce mlx5 crypto PMD crypto/mlx5: add DEK object management crypto/mlx5: add session operations crypto/mlx5: add basic operations crypto/mlx5: add queue pairs operations crypto/mlx5: add dev stop and start operations crypto/mlx5: add memory region management crypto/mlx5: create login object using DevX test/crypto: add mlx5 crypto driver test/crypto: add data-unit and wrapped vectors test/crypto: add AES-XTS multi segment OOP tests

Suanming Mou (5):
crypto/mlx5: add keytag devarg
crypto/mlx5: add maximum segments devarg crypto/mlx5: add WQE set initialization crypto/mlx5: add enqueue and dequeue operations crypto/mlx5: add statistic get and reset operations

 MAINTAINERS                                |    4 +
 app/test/test_cryptodev.c                  |    7 +
 app/test/test_cryptodev.h                  |    4 +-
 app/test/test_cryptodev_aes_test_vectors.h | 1404 ++++++++++++++++++++
 app/test/test_cryptodev_blockcipher.c      |   10 +-
 app/test/test_cryptodev_blockcipher.h      |    2 +
 doc/guides/cryptodevs/features/mlx5.ini    |   37 +
 doc/guides/cryptodevs/index.rst            |    1 +
 doc/guides/cryptodevs/mlx5.rst             |  153 +++
 doc/guides/rel_notes/release_21_08.rst     |    5 +
 drivers/common/mlx5/mlx5_common.h          |    1 +
 drivers/common/mlx5/mlx5_common_pci.c      |   14 +
 drivers/common/mlx5/mlx5_common_pci.h      |   21 +-
 drivers/crypto/meson.build                 |    1 +
 drivers/crypto/mlx5/meson.build            |   27 +
 drivers/crypto/mlx5/mlx5_crypto.c          | 1177 ++++++++++++++++
 drivers/crypto/mlx5/mlx5_crypto.h          |   91 ++
 drivers/crypto/mlx5/mlx5_crypto_dek.c      |  161 +++
 drivers/crypto/mlx5/mlx5_crypto_utils.h    |   19 +
 drivers/crypto/mlx5/version.map            |    3 +
 20 files changed, 3130 insertions(+), 12 deletions(-)
 create mode 100644 doc/guides/cryptodevs/features/mlx5.ini
 create mode 100644 doc/guides/cryptodevs/mlx5.rst
 create mode 100644 drivers/crypto/mlx5/meson.build
 create mode 100644 drivers/crypto/mlx5/mlx5_crypto.c
 create mode 100644 drivers/crypto/mlx5/mlx5_crypto.h
 create mode 100644 drivers/crypto/mlx5/mlx5_crypto_dek.c
 create mode 100644 drivers/crypto/mlx5/mlx5_crypto_utils.h
 create mode 100644 drivers/crypto/mlx5/version.map
Signature · 1 line
2.27.0