Skip to content

Adis IRQ fixes and minor improvements

Nuno Sa linux-iio 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 2 repliesIn review
  2. v29 patches 21 repliesApplied
  3. v17 patches 19 repliesSuperseded

Changes in v3 from the cover letter

* Improved commit description on ("iio: adis16475: do not return ints in
irq handlers");
* Reordered patch 2 and 3 so that patch 3 is easier to apply;
* Re-arranged the error handling on 'spi_sync()' error path.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6iio: adis16475: do not return ints in irq handlersdrivers/iio/imu/adis16475.c+1 -10 replies
2/6iio: adis_buffer: update device page after changing itdrivers/iio/imu/adis_buffer.c+3 -31 reply
3/6iio: adis_buffer: don't push data to buffers on failuredrivers/iio/imu/adis_buffer.c+4 -40 replies
4/6iio: adis: add burst_max_speed_hz variabledrivers/iio/imu/adis_buffer.c include/linux/iio/imu/adis.h+6 -00 replies
5/6iio: adis16475: do not directly change spi 'max_speed_hz'drivers/iio/imu/adis16475.c+2 -50 replies
6/6iio: adis16400: do not directly change spi 'max_speed_hz'drivers/iio/imu/adis16400.c+2 -130 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAlexandru Ardelean
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] Adis IRQ fixes and minor improvements

The primary goal of this series was to fix the return value on some trigger handlers as spotted in [1]. While doing it, I found some minor improvements that I think are simple enough to include in this series.

As for the first 2 patches, I opted to not do any functional change so I'm keeping the 'if (!adis->buffer)' check. However, 'adis-buffer' is allocated in 'update_scan_mode' hook which means we should be sure that the buffer is allocated and the check is really not needed. I did not went into the details but is there any way for the trigger handler to be called before the 'update_scan_mode' hook? If not, I'm happy in sending a v2 where we just remove the 'if'...

Changes in v2:
* Remove the 'if' check for the allocated buffer;
* Make sure the adis 'state_lock' is unlocked on error paths;
* Fixed the commit message on the first 3 patches.
* Dropped ("iio: adis16475: re-set max spi transfer") and added 3 new
patches (last 3 in the series ) to fix a potential race with the spi core as discussed in [2].

Changes in v3:
* Improved commit description on ("iio: adis16475: do not return ints in
irq handlers");
* Reordered patch 2 and 3 so that patch 3 is easier to apply;
* Re-arranged the error handling on 'spi_sync()' error path.

[1]: https://marc.info/?l=linux-iio&m=161815197426882&w=2
[2]: https://marc.info/?l=linux-iio&m=161884696722142&w=2

Nuno Sa (6):
iio: adis16475: do not return ints in irq handlers
iio: adis_buffer: update device page after changing it
iio: adis_buffer: don't push data to buffers on failure
iio: adis: add burst_max_speed_hz variable
iio: adis16475: do not directly change spi 'max_speed_hz'
iio: adis16400: do not directly change spi 'max_speed_hz'

 drivers/iio/imu/adis16400.c   | 15 ++-------------
 drivers/iio/imu/adis16475.c   |  9 +++------
 drivers/iio/imu/adis_buffer.c | 16 ++++++++++------
 include/linux/iio/imu/adis.h  |  2 ++
 4 files changed, 17 insertions(+), 25 deletions(-)
Signature · 1 line
2.31.1