Adis IRQ fixes and minor improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 2 repliesIn review
- v29 patches 21 repliesApplied
- v17 patches 19 repliesSuperseded
Changes in v3 from the cover letter
* Improved commit description on ("iio: adis16475: do not return ints in
irq handlers");
* Reordered patch 2 and 3 so that patch 3 is easier to apply;
* Re-arranged the error handling on 'spi_sync()' error path.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | iio: adis16475: do not return ints in irq handlersdrivers/ | +1 | 0 replies | |
| 2/6 | iio: adis_buffer: update device page after changing itdrivers/ | +3 | 1 reply | |
| 3/6 | iio: adis_buffer: don't push data to buffers on failuredrivers/ | +4 | 0 replies | |
| 4/6 | iio: adis: add burst_max_speed_hz variabledrivers/ include/ | +6 | 0 replies | |
| 5/6 | iio: adis16475: do not directly change spi 'max_speed_hz'drivers/ | +2 | 0 replies | |
| 6/6 | iio: adis16400: do not directly change spi 'max_speed_hz'drivers/ | +2 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Alexandru Ardelean |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/6] Adis IRQ fixes and minor improvements
The primary goal of this series was to fix the return value on some trigger handlers as spotted in [1]. While doing it, I found some minor improvements that I think are simple enough to include in this series.
As for the first 2 patches, I opted to not do any functional change so I'm keeping the 'if (!adis->buffer)' check. However, 'adis-buffer' is allocated in 'update_scan_mode' hook which means we should be sure that the buffer is allocated and the check is really not needed. I did not went into the details but is there any way for the trigger handler to be called before the 'update_scan_mode' hook? If not, I'm happy in sending a v2 where we just remove the 'if'...
Changes in v2:
* Remove the 'if' check for the allocated buffer;
* Make sure the adis 'state_lock' is unlocked on error paths;
* Fixed the commit message on the first 3 patches.
* Dropped ("iio: adis16475: re-set max spi transfer") and added 3 new
patches (last 3 in the series ) to fix a potential race with the spi core as discussed in [2].
Changes in v3:
* Improved commit description on ("iio: adis16475: do not return ints in
irq handlers");
* Reordered patch 2 and 3 so that patch 3 is easier to apply;
* Re-arranged the error handling on 'spi_sync()' error path.
[1]: https://marc.info/?l=linux-iio&m=161815197426882&w=2
[2]: https://marc.info/?l=linux-iio&m=161884696722142&w=2
Nuno Sa (6):
iio: adis16475: do not return ints in irq handlers
iio: adis_buffer: update device page after changing it
iio: adis_buffer: don't push data to buffers on failure
iio: adis: add burst_max_speed_hz variable
iio: adis16475: do not directly change spi 'max_speed_hz'
iio: adis16400: do not directly change spi 'max_speed_hz'
drivers/iio/imu/adis16400.c | 15 ++------------- drivers/iio/imu/adis16475.c | 9 +++------ drivers/iio/imu/adis_buffer.c | 16 ++++++++++------ include/linux/iio/imu/adis.h | 2 ++ 4 files changed, 17 insertions(+), 25 deletions(-)
Signature · 1 line
2.31.1