Skip to content

hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

Philippe Mathieu-Daudé qemu-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest6 patches 3 repliesIn review
  2. v65 patches 3 repliesSuperseded
  3. v56 patches 3 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v49 patches5 repliesSuperseded
v38 patches3 repliesSuperseded
v28 patches2 repliesSuperseded
v14 patches11 repliesSuperseded

Changes in v7 from the cover letter

- Rebased
- Added A-b/R-b tags
- Removed stub (thuth)

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDChw/isa/Kconfig+1 -00 replies
2/6hw/block/fdc: Replace disabled fprintf() by trace eventhw/block/fdc.c hw/block/trace-events+2 -60 replies
3/6hw/block/fdc: Declare shared prototypes in fdc-internal.hMAINTAINERS hw/block/fdc-internal.h hw/block/fdc.c+168 -1220 replies
4/6hw/block/fdc: Extract ISA floppy controllers to fdc-isa.cMAINTAINERS hw/block/Kconfig hw/block/fdc-isa.c +5 more+332 -2740 replies
5/6hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.cMAINTAINERS hw/block/Kconfig hw/block/fdc-sysbus.c +5 more+259 -2220 replies
6/6hw/block/fdc: Add description to floppy controllershw/block/fdc-isa.c hw/block/fdc-sysbus.c+3 -00 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchMark Cave-AylandPaolo BonziniThomas HuthJohn Snow
1/6A-b R-b
2/6A-b R-b A-b R-b
3/6A-b R-b A-b
4/6A-b R-b A-b R-b
5/6A-b R-b A-b R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/6] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers

Hi,

The floppy disc controllers pulls in irrelevant devices (sysbus in an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).

This series clean that by extracting each device in its own file, adding the corresponding Kconfig symbols: FDC_ISA and FDC_SYSBUS.

Since v6:
- Rebased
- Added A-b/R-b tags
- Removed stub (thuth)

Since v5:
- Added stub (thuth)

Since v4:
- Dropped machine patches for later due to DMA jazz issue

Since v3:
- Fix ISA_SUPERIO -> FDC Kconfig dependency (jsnow)

Since v2:
- rebased

Since v1:
- added missing "hw/block/block.h" header (jsnow)
- inlined hardware specific calls (Mark)
- added R-b/A-b tags

Regards,

Phil.

Philippe Mathieu-Daudé (6):
hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC hw/block/fdc: Replace disabled fprintf() by trace event hw/block/fdc: Declare shared prototypes in fdc-internal.h hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c hw/block/fdc: Add description to floppy controllers

 hw/block/fdc-internal.h | 158 ++++++++++
 hw/block/fdc-isa.c      | 320 +++++++++++++++++++++
 hw/block/fdc-sysbus.c   | 251 ++++++++++++++++
 hw/block/fdc.c          | 621 +---------------------------------------
 MAINTAINERS             |   3 +
 hw/block/Kconfig        |  12 +-
 hw/block/meson.build    |   2 +
 hw/block/trace-events   |   3 +
 hw/i386/Kconfig         |   2 +-
 hw/isa/Kconfig          |   7 +-
 hw/mips/Kconfig         |   2 +-
 hw/sparc/Kconfig        |   2 +-
 hw/sparc64/Kconfig      |   2 +-
 13 files changed, 763 insertions(+), 622 deletions(-)
 create mode 100644 hw/block/fdc-internal.h
 create mode 100644 hw/block/fdc-isa.c
 create mode 100644 hw/block/fdc-sysbus.c
Signature · 1 line
2.31.1