Skip to content

KVM: selftests: fix races in dirty log test

Peter Xu kvm lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 0 repliesNew
  2. v32 patches 5 repliesSuperseded

Changes in v4 from the cover letter

- add missing vcpu_handle_sync_stop() call in dirty ring test

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: selftests: Sync data verify of dirty logging with guest synctools/testing/selftests/kvm/dirty_log_test.c+51 -110 replies
2/2KVM: selftests: Wait for vcpu thread before signal setuptools/testing/selftests/kvm/dirty_log_test.c+8 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] KVM: selftests: fix races in dirty log test

v4:
- add missing vcpu_handle_sync_stop() call in dirty ring test

The other solution of patch 2 is here [1]

I got another report that there seems to still be a race, but that one seems extremely hard to trigger, even so far we don't know whether that could be ARM-only. Since current fix should make sense already and fix real problems, IMHO we don't need to wait for that.

Paolo, I still kept the 2nd patch just for completeness, but feel free to ignore the 2nd patch if you prefer the other version, and I'll follow your preference.

Thanks!

[1] https://lore.kernel.org/kvm/[email protected]/

Peter Xu (2):
KVM: selftests: Sync data verify of dirty logging with guest sync
KVM: selftests: Wait for vcpu thread before signal setup

 tools/testing/selftests/kvm/dirty_log_test.c | 70 +++++++++++++++++---
 1 file changed, 59 insertions(+), 11 deletions(-)
Signature · 1 line
2.26.2