Skip to content

arm64: drop pfn_valid_within() and simplify pfn_valid()

Mike Rapoport kvmarm linux-arm-kernel linux-mm lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 17 repliesIn review 2 of 4 applied
  2. v34 patches 1 replySuperseded
  3. v24 patches 43 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches11 repliesSuperseded

Changes in v4 from the cover letter

* rebase on v5.13-rc1

Patches in v4 2 of 4 applied

#Subject and filesSizeRepliesApplied
1/4include/linux/mmzone.h: add documentation for pfn_valid()include/linux/mmzone.h+11 -01 reply
2/4memblock: update initialization of reserved pagesinclude/linux/memblock.h mm/memblock.c+29 -319 repliesApplied
3/4arm64: decouple check whether pfn is in linear map from pfn_valid()arch/arm64/include/asm/memory.h arch/arm64/include/asm/page.h arch/arm64/kvm/mmu.c +3 more+19 -61 replyApplied
4/4arm64: drop pfn_valid_within() and simplify pfn_valid()arch/arm64/Kconfig arch/arm64/mm/init.c+1 -43 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAnshuman KhandualDavid HildenbrandArd BiesheuvelKefeng WangMike Rapoport (Microsoft)
SeriesR-b
1/4R-b A-b
2/4R-b R-b A-b R-b R-b R-b
3/4A-b A-b
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid()

From: Mike Rapoport <[email protected]>

Hi,

These patches aim to remove CONFIG_HOLES_IN_ZONE and essentially hardwire pfn_valid_within() to 1.

The idea is to mark NOMAP pages as reserved in the memory map and restore the intended semantics of pfn_valid() to designate availability of struct page for a pfn.

With this the core mm will be able to cope with the fact that it cannot use NOMAP pages and the holes created by NOMAP ranges within MAX_ORDER blocks will be treated correctly even without the need for pfn_valid_within.

The patches are boot tested on qemu-system-aarch64.

I beleive it would be best to route these via mmotm tree.

v4:
* rebase on v5.13-rc1

v3: Link: https://lore.kernel.org/lkml/[email protected]
* Fix minor issues found by Anshuman
* Freshen up the declaration of pfn_valid() to make it consistent with pfn_is_map_memory()
* Add more Acked-by and Reviewed-by tags, thanks Anshuman and David

v2: Link: https://lore.kernel.org/lkml/[email protected]
* Add check for PFN overflow in pfn_is_map_memory()
* Add Acked-by and Reviewed-by tags, thanks David.

v1: Link: https://lore.kernel.org/lkml/[email protected]
* Add comment about the semantics of pfn_valid() as Anshuman suggested
* Extend comments about MEMBLOCK_NOMAP, per Anshuman
* Use pfn_is_map_memory() name for the exported wrapper for memblock_is_map_memory(). It is still local to arch/arm64 in the end because of header dependency issues.

rfc: Link: https://lore.kernel.org/lkml/[email protected]

Mike Rapoport (4):
include/linux/mmzone.h: add documentation for pfn_valid()
memblock: update initialization of reserved pages
arm64: decouple check whether pfn is in linear map from pfn_valid()
arm64: drop pfn_valid_within() and simplify pfn_valid()

 arch/arm64/Kconfig              |  3 ---
 arch/arm64/include/asm/memory.h |  2 +-
 arch/arm64/include/asm/page.h   |  3 ++-
 arch/arm64/kvm/mmu.c            |  2 +-
 arch/arm64/mm/init.c            | 14 +++++++++++++-
 arch/arm64/mm/ioremap.c         |  4 ++--
 arch/arm64/mm/mmu.c             |  2 +-
 include/linux/memblock.h        |  4 +++-
 include/linux/mmzone.h          | 11 +++++++++++
 mm/memblock.c                   | 28 ++++++++++++++++++++++++++--
 10 files changed, 60 insertions(+), 13 deletions(-)

base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5

Signature · 1 line
2.28.0