scsi/dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 9 repliesIn review
- v43 patches 11 repliesSuperseded
- v32 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 RFC | 2 patches | 5 replies | Superseded | |
| v1 | 1 patch | 8 replies | Superseded |
Changes in v5 from the cover letter
- (2/3) Fixed bug in logical / bitwise and expression
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | scsi: scsi_ioctl: export __scsi_result_to_blk_status()block/ drivers/ include/ | +49 | 0 replies | |
| 2/3 | scsi: scsi_ioctl: add sg_io_to_blk_status()block/ include/ | +21 | 0 replies | |
| 3/3 | dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IOblock/ drivers/ drivers/ +4 more | +156 | 9 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH v5 0/3] scsi/dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath
From: Martin Wilck <[email protected]>
Hello Mike, hello Martin,
here is v5 of my attempt to add retry logic to SG_IO on dm-multipath devices.
Christoph's comment on v4 has been received, but as I'm still confused how to handle the SCSI result / blk_status_t conversion properly, and waiting for more guidance, I want to fix the nasty bug in v4 first.
Regards
Martin
Changes v4->v5:
- (2/3) Fixed bug in logical / bitwise and expression
Changes v3->v4 (thanks to Mike Snitzer):
- Added an additional helper function sg_io_to_blk_status() to scsi_ioctl.c, in order to avoid open-coding handling of the SCSI result code in device-mapper.
- Added a new method dm_sg_io_ioctl_fn() in struct target_type, define only by the multipath target. This allows moving the bulk of the new code to dm-mpath.c, and avoids the wrong limitation of the code to request-based multipath.
Changes v2->v3:
- un-inlined scsi_result_to_blk_status again, and move the helper __scsi_result_to_blk_status to block/scsi_ioctl.c instead (Bart v. Assche)
- open-coded the status/msg/host/driver-byte -> result conversion where the standard SCSI helpers aren't usable (Bart v. Assche)
Changes v1->v2:
- applied modifications from Mike Snitzer
- moved SG_IO dependent code to a separate file, no scsi includes in dm.c any more
- made the new code depend on a configuration option
- separated out scsi changes, made scsi_result_to_blk_status() inline to avoid dependency of dm_mod from scsi_mod (Paolo Bonzini)
Martin Wilck (3):
scsi: scsi_ioctl: export __scsi_result_to_blk_status()
scsi: scsi_ioctl: add sg_io_to_blk_status()
dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO
Martin Wilck (3):
scsi: scsi_ioctl: export __scsi_result_to_blk_status()
scsi: scsi_ioctl: add sg_io_to_blk_status()
dm mpath: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO
block/scsi_ioctl.c | 72 ++++++++++++++++++++++- drivers/md/Kconfig | 11 ++++ drivers/md/dm-core.h | 5 ++ drivers/md/dm-mpath.c | 105 ++++++++++++++++++++++++++++++++++ drivers/md/dm.c | 26 ++++++++- drivers/scsi/scsi_lib.c | 24 +------- include/linux/blkdev.h | 4 ++ include/linux/device-mapper.h | 8 ++- 8 files changed, 226 insertions(+), 29 deletions(-)
Signature · 7 lines
2.32.0 -- dm-devel mailing list [email protected] https://listman.redhat.com/mailman/listinfo/dm-devel