Skip to content

block and nvme passthrough error handling

Keith Busch linux-block linux-nvme 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 7 repliesIn review
  2. v34 patches 12 repliesSuperseded
  3. v25 patches 14 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4block: support polling through blk_execute_rqblock/blk-exec.c+17 -10 replies
2/4nvme: use blk_execute_rq() for passthrough commandsdrivers/nvme/host/core.c drivers/nvme/host/fabrics.c drivers/nvme/host/fabrics.h +5 more+19 -472 replies
3/4block: return errors from blk_execute_rq()block/blk-exec.c include/linux/blkdev.h+8 -31 reply
4/4nvme: use return value from blk_execute_rq()drivers/nvme/host/core.c drivers/nvme/host/ioctl.c drivers/nvme/host/nvme.h +1 more+33 -182 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigMing LeiChaitanya Kulkarni
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCHv4 0/4] block and nvme passthrough error handling

This series has blk_execute_rq() return queueing errors so the caller may know if their request wasn't dispatched, and adds polled hctx support.

Chances since v3:

Added recieved "Reviewed-by:" tags.

Retain the REQ_HIPRI flag for nvme polled passthrough requests (patch 2)

Combined nvme request dispatch with the status decoding into single function (patch 4)

Keith Busch (4):
block: support polling through blk_execute_rq
nvme: use blk_execute_rq() for passthrough commands
block: return errors from blk_execute_rq()
nvme: use return value from blk_execute_rq()

 block/blk-exec.c               | 25 +++++++++++--
 drivers/nvme/host/core.c       | 65 +++++++++++++++-------------------
 drivers/nvme/host/fabrics.c    | 13 ++++---
 drivers/nvme/host/fabrics.h    |  2 +-
 drivers/nvme/host/fc.c         |  2 +-
 drivers/nvme/host/ioctl.c      |  6 +---
 drivers/nvme/host/nvme.h       |  4 +--
 drivers/nvme/host/rdma.c       |  3 +-
 drivers/nvme/host/tcp.c        |  2 +-
 drivers/nvme/target/loop.c     |  2 +-
 drivers/nvme/target/passthru.c |  8 ++---
 include/linux/blkdev.h         |  4 ++-
 12 files changed, 72 insertions(+), 64 deletions(-)
Signature · 1 line
2.25.4