Skip to content

IIO: Alignment fixes part 3 - __aligned(8) used to ensure alignment

Jonathan Cameron linux-iio 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/28 patches 2 repliesIn review
  2. v1 posting 1/211 patches 11 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8iio: adc: at91-sama5d2: Fix buffer alignment in iio_push_to_buffers_with_timestamp()drivers/iio/adc/at91-sama5d2_adc.c+2 -10 replies
2/8iio: adc: hx711: Fix buffer alignment in iio_push_to_buffers_with_timestamp()drivers/iio/adc/hx711.c+2 -20 replies
3/8iio: adc: mxs-lradc: Fix buffer alignment in iio_push_to_buffers_with_timestamp()drivers/iio/adc/mxs-lradc-adc.c+2 -10 replies
4/8iio: adc: ti-ads8688: Fix alignment of buffer in iio_push_to_buffers_with_timestamp()drivers/iio/adc/ti-ads8688.c+2 -10 replies
5/8iio: magn: rm3100: Fix alignment of buffer in iio_push_to_buffers_with_timestamp()drivers/iio/magnetometer/rm3100-core.c+2 -10 replies
6/8iio: light: vcnl4000: Fix buffer alignment in iio_push_to_buffers_with_timestamp()drivers/iio/light/vcnl4000.c+1 -10 replies
7/8iio: light: vcnl4035: Fix buffer alignment in iio_push_to_buffers_with_timestamp()drivers/iio/light/vcnl4035.c+2 -10 replies
8/8iio: prox: isl29501: Fix buffer alignment in iio_push_to_buffers_with_timestamp()drivers/iio/proximity/isl29501.c+1 -10 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNuno Sá
SeriesR-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RESEND 0/8] IIO: Alignment fixes part 3 - __aligned(8) used to ensure alignment

From: Jonathan Cameron <[email protected]>

Resent as none of these have had any comments since being sent out over a month ago. Note these are very straight forward, but I've messed up such things in the past so really appreciate it if someone takes the time to do a quick sanity check.

I have picked up those patches that did get review in first posting and dropped them from this posting.

Cover letter from first posting.

I finally got around to do a manual audit of all the calls to iio_push_to_buffers_with_timestamp() which has the somewhat odd requirements of:
1. 8 byte alignment of the provided buffer.
2. space for an 8 byte naturally aligned timestamp to be inserted at the end.

Unfortunately there were rather a lot of these left, but time to bite the bullet and clean them up.

As discussed previous in
https://lore.kernel.org/linux-iio/[email protected]/
it is not easy to fix the alignment issue without requiring a bounce buffer (see part 4 of the alignment fixes for a proposal for that where it is absolutely necessary).

Part 3 contains the cases where the struct approach in part 2 did not seem appropriate. Normally there are two possible reasons for this.
1. Would have required an additional memset operation to avoid any possibility of leaking kernel data.
2. The location of the timestamp may depend on the channels enabled. This normally happens when the max sizeof channels is greater than 8 bytes.

Once all cases are fixes, I'll take a look at hardening against any accidental reintroductions. Note that on many platforms and usecases the bug in question will never occur.

Cc Eugen Hristev <[email protected]>
Cc Andreas Klinger <[email protected]>
Cc Song Qiang <[email protected]>
Cc Mathieu Othacehe <[email protected]>
Cc Parthiban Nallathambi <[email protected]>

Jonathan Cameron (8):
iio: adc: at91-sama5d2: Fix buffer alignment in
iio_push_to_buffers_with_timestamp()
iio: adc: hx711: Fix buffer alignment in
iio_push_to_buffers_with_timestamp()
iio: adc: mxs-lradc: Fix buffer alignment in
iio_push_to_buffers_with_timestamp()
iio: adc: ti-ads8688: Fix alignment of buffer in
iio_push_to_buffers_with_timestamp()
iio: magn: rm3100: Fix alignment of buffer in
iio_push_to_buffers_with_timestamp()
iio: light: vcnl4000: Fix buffer alignment in
iio_push_to_buffers_with_timestamp()
iio: light: vcnl4035: Fix buffer alignment in
iio_push_to_buffers_with_timestamp()
iio: prox: isl29501: Fix buffer alignment in
iio_push_to_buffers_with_timestamp()

 drivers/iio/adc/at91-sama5d2_adc.c     | 3 ++-
 drivers/iio/adc/hx711.c                | 4 ++--
 drivers/iio/adc/mxs-lradc-adc.c        | 3 ++-
 drivers/iio/adc/ti-ads8688.c           | 3 ++-
 drivers/iio/light/vcnl4000.c           | 2 +-
 drivers/iio/light/vcnl4035.c           | 3 ++-
 drivers/iio/magnetometer/rm3100-core.c | 3 ++-
 drivers/iio/proximity/isl29501.c       | 2 +-
 8 files changed, 14 insertions(+), 9 deletions(-)
Signature · 1 line
2.32.0