Skip to content

iommu/amd: Enable page-selective flushes

Nadav Amit linux-iommu lkml 6 versions – Applied

Status from this message: Applied, thanks Nadav.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 2 repliesApplied
  2. v57 patches 3 repliesSuperseded
  3. v47 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v36 patches19 repliesSuperseded
v24 patches4 repliesSuperseded
v14 patches6 repliesApplied

Changes in v6 from the cover letter

* Remove redundant check on amd_iommu_iotlb_gather_add_page() [Robin]
* Add Robin's reviewed-by tags

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/7iommu/amd: Selective flush on unmapdrivers/iommu/amd/iommu.c+13 -20 replies
2/7iommu/amd: Do not use flush-queue when NpCache is ondrivers/iommu/amd/init.c+6 -10 replies
3/7iommu: Improve iommu_iotlb_gather helpersdrivers/iommu/mtk_iommu.c include/linux/iommu.h+34 -100 replies
4/7iommu: Factor iommu_iotlb_gather_is_disjoint() outinclude/linux/iommu.h+26 -80 replies
5/7iommu/amd: Tailored gather logic for AMDdrivers/iommu/amd/iommu.c+22 -10 replies
6/7iommu/amd: Sync once for scatter-gather operationsdrivers/iommu/amd/iommu.c+12 -30 replies
7/7iommu/amd: Use only natural aligned flushes in a VMdrivers/iommu/amd/iommu.c+42 -50 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchRobin MurphyWill Deacon
1/7
2/7
3/7
4/7R-b A-b
5/7R-b
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/7] iommu/amd: Enable page-selective flushes

From: Nadav Amit <[email protected]>

The previous patch, commit 268aa4548277 ("iommu/amd: Page-specific invalidations for more than one page") was supposed to enable page-selective IOTLB flushes on AMD.

Besides the bug that was already fixed by commit a017c567915f ("iommu/amd: Fix wrong parentheses on page-specific invalidations") there are several remaining matters to enable and benefit from page-selective IOTLB flushes on AMD:

1. Enable selective flushes on unmap (patch 1)
2. Avoid using flush-queue on vIOMMUs (patch 2)
3. Relaxed flushes when gathering, excluding vIOMMUs (patches 3-5)
4. Syncing once on scatter-gather map operations (patch 6)
5. Breaking flushes to naturally aligned ranges on vIOMMU (patch 7)

The main difference in this version is that the logic that flushes vIOMMU was improved based on Robin's feedback. Batching decisions are not based on alignment anymore, but instead the flushing range is broken into naturally aligned regions on sync. Doing so allows us to flush only the entries that we modified with the minimal number of flushes.

Robin, others: your feedback would be highly appreciated to get these patches merge.

Cc Joerg Roedel <[email protected]>
Cc Will Deacon <[email protected]>
Cc Jiajun Cao <[email protected]>
Cc Robin Murphy <[email protected]>
Cc Lu Baolu <[email protected]>

---

v5->v6:
* Remove redundant check on amd_iommu_iotlb_gather_add_page() [Robin]
* Add Robin's reviewed-by tags

v4->v5:
* Rebase on v5.14-rc1
* Change pr_warn() to pr_info() [John Garry]

v3->v4:
* Breaking flushes to naturally aligned ranges on vIOMMU [Robin]
* Removing unnecessary stubs; fixing comment [Robin]
* Removing unused variable [Yong]
* Changing pr_warn_once() to pr_warn() [Robin]
* Improving commit log [Will]

v2->v3:
* Rebase on v5.13-rc5
* Refactoring (patches 4-5) [Robin]
* Rework flush logic (patch 5): more relaxed on native
* Syncing once on scatter-gather operations (patch 6)

v1->v2:
* Rebase on v5.13-rc3

Nadav Amit (6):
iommu/amd: Selective flush on unmap iommu/amd: Do not use flush-queue when NpCache is on
iommu: Factor iommu_iotlb_gather_is_disjoint() out iommu/amd: Tailored gather logic for AMD iommu/amd: Sync once for scatter-gather operations iommu/amd: Use only natural aligned flushes in a VM

Robin Murphy (1):
iommu: Improve iommu_iotlb_gather helpers

 drivers/iommu/amd/init.c  |  7 ++-
 drivers/iommu/amd/iommu.c | 96 +++++++++++++++++++++++++++++++++++----
 drivers/iommu/mtk_iommu.c |  6 +--
 include/linux/iommu.h     | 72 +++++++++++++++++++++++------
 4 files changed, 153 insertions(+), 28 deletions(-)
Signature · 1 line
2.25.1