arm64: dts: rockchip: rk3328: Enable USB3 on some SBCs
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | arm64: dts: rockchip: rk3328: Enable USB3 for Rock64arch/ | +5 | 0 replies | |
| 2/4 | arm64: dts: rockchip: rk3328: Enable USB3 for ROC-RK3328-CCarch/ | +5 | 0 replies | |
| 3/4 | arm64: dts: rockchip: rk3328: Enable USB3 for Rock Pi Earch/ | +5 | 0 replies | |
| 4/4 | arm64: dts: rockchip: rk3328: Enable USB3 Ethernet on NanoPi R2Sarch/ | +32 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] arm64: dts: rockchip: rk3328: Enable USB3 on some SBCs
From: Chen-Yu Tsai <[email protected]>
Hi everyone,
Here are some patches that enable USB3 on RK3328 SBCs that I own. The changes are quite straightforward, except for the NanoPi R2S, which has a USB3 Ethernet chip attached. I am aware that there's already a patch [1] for that. This is my spin on things using the USB device binding, with comments on how the USB ports are arranged, that I had done but couldn't find the time to send out.
The last patch also results in some warnings from checkpatch.pl:
WARNING: DT compatible string "usbbda,8153" appears un-documented --
check ./Documentation/devicetree/bindings/
#88: FILE: arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts:398:
+ compatible = "usbbda,8153";
WARNING: DT compatible string vendor "usbbda" appears un-documented --
check ./Documentation/devicetree/bindings/vendor-prefixes.yaml
#88: FILE: arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts:398:
+ compatible = "usbbda,8153";
At least the first warning should be covered by the USB device binding
Documentation/devicetree/bindings/usb/usb-device.yaml
while we probably should add an exception to vendor-prefixes.yaml for the second warning.
Please let me know what you think.
Regards
ChenYu
[1] https://lore.kernel.org/linux-rockchip/[email protected]/
Cameron Nemo (1):
arm64: dts: rockchip: rk3328: Enable USB3 for Rock64
Chen-Yu Tsai (3):
arm64: dts: rockchip: rk3328: Enable USB3 for ROC-RK3328-CC
arm64: dts: rockchip: rk3328: Enable USB3 for Rock Pi E
arm64: dts: rockchip: rk3328: Enable USB3 Ethernet on NanoPi R2S
.../boot/dts/rockchip/rk3328-nanopi-r2s.dts | 32 +++++++++++++++++++ .../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 5 +++ .../boot/dts/rockchip/rk3328-rock-pi-e.dts | 5 +++ .../arm64/boot/dts/rockchip/rk3328-rock64.dts | 5 +++ 4 files changed, 47 insertions(+)
Signature · 7 lines
2.31.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip