Skip to content

Add support for PMBus in QEMU

Titus Rwantare qemu-arm qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/25 patches 2 repliesIn review
  2. v5 posting 1/25 patches 0 repliesSuperseded
  3. v45 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches6 repliesSuperseded
v25 patches5 repliesSuperseded
v13 patches3 repliesSuperseded

Changes in v5 from the cover letter

- switched to BIT_ULL for flags to enable 32 bit hosts

Patches in v5 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5hw/i2c: add support for PMBushw/arm/Kconfig hw/i2c/Kconfig hw/i2c/meson.build +2 more+2135 -02 replies
2/5hw/misc: add ADM1272 devicehw/arm/Kconfig hw/misc/Kconfig hw/misc/adm1272.c +1 more+550 -00 replies
3/5tests/qtest: add tests for ADM1272 device modeltests/qtest/adm1272-test.c tests/qtest/meson.build+446 -00 replies
4/5hw/misc: add MAX34451 devicehw/arm/Kconfig hw/misc/Kconfig hw/misc/max34451.c +1 more+781 -00 replies
5/5tests/qtest: add tests for MAX34451 device modeltests/qtest/max34451-test.c tests/qtest/meson.build+337 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJoel StanleyHao Wu
1/5R-b R-b
2/5R-b R-b
3/5R-b
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/5] Add support for PMBus in QEMU

Hello,

This patch series adds an interface to start supporting PMBus devices in QEMU. I’ve included two PMBus devices: MAX34451 and ADM1272.

PMBus is a variant of SMBus meant for digital management of power supplies. PMBus adds to the SMBus standard by defining a number of constants and commands used by compliant devices. The specification for PMBus can be found at:

https://pmbus.org/specification-archives/

Currently, the goal for these devices is to emulate basic functionality by reading and writing registers. Timing, and some logical operation is not implemented. This implementation supports nearly all available registers for PMBus including:
- Voltage inputs and outputs
- Current inputs and outputs
- Temperature sensors

Unimplimented registers get passed through to the device model, and device models can opt out of using the standard registers with flags. The included devices make use of these fields and illustrate how to interface with the pmbus class.

Datasheets for sensors:

https://datasheets.maximintegrated.com/en/ds/MAX34451.pdf
https://www.analog.com/media/en/technical-documentation/data-sheets/ADM1272.pdf

Since v4:
- switched to BIT_ULL for flags to enable 32 bit hosts

Since v3:
- added VMState descriptions. Adding PMBusPage info to the vmsd has proven to be tricky, it's a TODO for now.

Since v2:
- bump for feedback
- removed commented out code

Since v1:
- addressed Joel's comments
- split out tests into their own patches

Thanks for reviewing,

Titus Rwantare

Titus Rwantare (5):
hw/i2c: add support for PMBus
hw/misc: add ADM1272 device
tests/qtest: add tests for ADM1272 device model hw/misc: add MAX34451 device tests/qtest: add tests for MAX34451 device model

 include/hw/i2c/pmbus_device.h |  517 +++++++++++
 hw/i2c/pmbus_device.c         | 1612 +++++++++++++++++++++++++++++++++
 hw/misc/adm1272.c             |  544 +++++++++++
 hw/misc/max34451.c            |  775 ++++++++++++++++
 tests/qtest/adm1272-test.c    |  445 +++++++++
 tests/qtest/max34451-test.c   |  336 +++++++
 hw/arm/Kconfig                |    3 +
 hw/i2c/Kconfig                |    4 +
 hw/i2c/meson.build            |    1 +
 hw/misc/Kconfig               |    8 +
 hw/misc/meson.build           |    2 +
 tests/qtest/meson.build       |    2 +
 12 files changed, 4249 insertions(+)
 create mode 100644 include/hw/i2c/pmbus_device.h
 create mode 100644 hw/i2c/pmbus_device.c
 create mode 100644 hw/misc/adm1272.c
 create mode 100644 hw/misc/max34451.c
 create mode 100644 tests/qtest/adm1272-test.c
 create mode 100644 tests/qtest/max34451-test.c
Signature · 1 line
2.32.0.93.g670b81a890-goog