Skip to content

Map register blocks individually

[email protected] linux-cxl lkml 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 0 repliesNew
  2. v25 patches 6 repliesSuperseded
  3. v14 patches 5 repliesSuperseded

Changes in v3 from the cover letter

From Jonathan:
Add Reviews. Thanks!
Add back the kernel doc comment and enhance it a bit Update commit messages with more details. Remove CXL_REGLOC_RBI_MAX
Dan
Add pcim_enable_device() back in because it is needed and is not incompatible with pci_release_mem_regions() like I originally though.
Change cxl_ioremap_block() to devm_cxl_iomap_block()

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cxl/mem: Introduce cxl_decode_register_block()drivers/cxl/pci.c+18 -80 replies
2/5cxl/mem: Reserve all device regions at oncedrivers/cxl/pci.c+11 -70 replies
3/5cxl/mem: Map registers based on capabilitiesdrivers/cxl/core.c drivers/cxl/cxl.h drivers/cxl/pci.c+181 -362 replies
4/5cxl/mem: Reserve individual register block regionsdrivers/cxl/core.c drivers/cxl/pci.c+34 -41 reply
5/5cxl/pci: Add HDM decoder capabilitiesdrivers/cxl/core.c drivers/cxl/cxl.h drivers/cxl/pci.c+166 -60 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchJonathan Cameron
1/5
2/5R-b
3/5R-b R-b
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 0/5] Map register blocks individually

From: Ira Weiny <[email protected]>

Changes for v3:
From Jonathan:
Add Reviews. Thanks!
Add back the kernel doc comment and enhance it a bit Update commit messages with more details. Remove CXL_REGLOC_RBI_MAX
Dan
Add pcim_enable_device() back in because it is needed and is not incompatible with pci_release_mem_regions() like I originally though.
Change cxl_ioremap_block() to devm_cxl_iomap_block()

Add kernel doc comment for cxl_probe_component_regs() Update HDM patch to devm_cxl_iomap_block() call.

Some hardware implementations mix component and device registers into the same BAR and the driver stack is going to have independent mapping implementations for those 2 cases. Furthermore, it will be nice to have finer grained mappings should user space want to map some register blocks.

Unfortunately, the information for the register blocks is contained inside the BARs themselves. Which means the BAR must be mapped, probed, and unmapped prior to the registers being mapped individually.

The series starts by introducing the helper function cxl_decode_register_block(). Then breaks out region reservation and register mapping. Separates mapping the registers into a probe stage and mapping stage. The probe stage creates a list of register blocks which is then iterated to map the individual register blocks.

Once mapping is performed in 2 steps the pci device management is removed and the resource reservation can be done per register block as well.

Finally, mapping the HDM decoder register block is added.

Ben Widawsky (1):
cxl/pci: Add HDM decoder capabilities

Ira Weiny (4):
cxl/mem: Introduce cxl_decode_register_block() cxl/mem: Reserve all device regions at once cxl/mem: Map registers based on capabilities cxl/mem: Reserve individual register block regions

 drivers/cxl/core.c | 193 ++++++++++++++++++++++++++++++++++++++++++---
 drivers/cxl/cxl.h  |  98 ++++++++++++++++++++---
 drivers/cxl/pci.c  | 164 ++++++++++++++++++++++++++++++--------
 3 files changed, 402 insertions(+), 53 deletions(-)
Signature · 1 line
2.28.0.rc0.12.gb6a658bd00c9