Skip to content

RFC Serialize timeout handling and done callback.

Daniel Wagner linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2qla2xxx: Refactor asynchronous command initializationdrivers/scsi/qla2xxx/qla_gbl.h drivers/scsi/qla2xxx/qla_gs.c drivers/scsi/qla2xxx/qla_init.c +5 more+75 -1280 replies
2/2qla2xxx: Do not free resource to early in qla24xx_async_gpsc_sp_done()drivers/scsi/qla2xxx/qla_def.h drivers/scsi/qla2xxx/qla_gbl.h drivers/scsi/qla2xxx/qla_gs.c +2 more+53 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/2] Serialize timeout handling and done callback.

Hi,

We got a customer report where qla2xxx was crashing only if the kernel was booting and ql2xextended_error_logging was set. Loading the module with the log option didn't trigger the crash.

After starring for a long time at the crash report I figured the problem might be a race between the timeout handler and done callback. I've come up with these patches here but unfortunatly, our customer is not able to reproduce the problem in the lab anymore (it was caused by a hardware issue which got fixed). So for these patches I don't have any feedback.

Maybe they make sense to add the driver even if I don't have prove it really address the mentioned bug hence this is marked as RFC.

Thanks,
Daniel

Daniel Wagner (2):
qla2xxx: Refactor asynchronous command initialization
qla2xxx: Do not free resource to early in qla24xx_async_gpsc_sp_done()

 drivers/scsi/qla2xxx/qla_def.h    |  5 ++
 drivers/scsi/qla2xxx/qla_gbl.h    |  4 +-
 drivers/scsi/qla2xxx/qla_gs.c     | 86 ++++++++++-------------------
 drivers/scsi/qla2xxx/qla_init.c   | 91 +++++++++++++------------------
 drivers/scsi/qla2xxx/qla_iocb.c   | 54 +++++++++++++-----
 drivers/scsi/qla2xxx/qla_mbx.c    | 11 ++--
 drivers/scsi/qla2xxx/qla_mid.c    |  5 +-
 drivers/scsi/qla2xxx/qla_mr.c     |  7 +--
 drivers/scsi/qla2xxx/qla_target.c |  6 +-
 9 files changed, 127 insertions(+), 142 deletions(-)
Signature · 1 line
2.29.2