Skip to content

KVM: arm64: selftests: Fix get-reg-list

Andrew Jones kvm kvmarm 3 versions – Applied

Status from this message: Applied to next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 10 repliesApplied
  2. v25 patches 7 repliesSuperseded
  3. v16 patches 1 replySuperseded

Changes in v3 from the cover letter

- Took Ricardo's suggestions in order to avoid needing to update prepare_vcpu_init, finalize_vcpu, and check_supported when adding new register sublists by better associating the sublists with their vcpu feature bits and caps [Ricardo]
- We now dynamically generate the vcpu config name by creating them from its sublist names [drew]

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5KVM: arm64: selftests: get-reg-list: Introduce vcpu configstools/testing/selftests/kvm/aarch64/get-reg-list.c+175 -902 replies
2/5KVM: arm64: selftests: get-reg-list: Prepare to run multiple configs at oncetools/testing/selftests/kvm/aarch64/get-reg-list.c+51 -171 reply
3/5KVM: arm64: selftests: get-reg-list: Provide config selection optiontools/testing/selftests/kvm/aarch64/get-reg-list.c+53 -31 reply
4/5KVM: arm64: selftests: get-reg-list: Remove get-reg-list-svetools/testing/selftests/kvm/.gitignore tools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/aarch64/get-reg-list-sve.c +1 more+21 -151 reply
5/5KVM: arm64: selftests: get-reg-list: Split base and pmu registerstools/testing/selftests/kvm/aarch64/get-reg-list.c+31 -81 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchRicardo Koller
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] KVM: arm64: selftests: Fix get-reg-list

v3:
- Took Ricardo's suggestions in order to avoid needing to update prepare_vcpu_init, finalize_vcpu, and check_supported when adding new register sublists by better associating the sublists with their vcpu feature bits and caps [Ricardo]
- We now dynamically generate the vcpu config name by creating them from its sublist names [drew]

v2:
- Removed some cruft left over from a previous more complex design of the config command line parser
- Dropped the list printing factor out patch as it's not necessary
- Added a 'PASS' output for passing tests to allow testers to feel good
- Changed the "up to date with kernel" comment to reference 5.13.0-rc2

Since KVM commit 11663111cd49 ("KVM: arm64: Hide PMU registers from userspace when not available") the get-reg-list* tests have been failing with

...
... There are 74 missing registers.
The following lines are missing registers:
...

where the 74 missing registers are all PMU registers. This isn't a bug in KVM that the selftest found, even though it's true that a KVM userspace that wasn't setting the KVM_ARM_VCPU_PMU_V3 VCPU flag, but still expecting the PMU registers to be in the reg-list, would suddenly no longer have their expectations met. In that case, the expectations were wrong, though, so that KVM userspace needs to be fixed, and so does this selftest.

We could fix the test with a one-liner since we just need a

  init->features[0] |= 1 << KVM_ARM_VCPU_PMU_V3;

in prepare_vcpu_init(), but that's too easy, so here's a 5 patch patch series instead :-) The reason for all the patches and the heavy diffstat is to prepare for other vcpu configuration testing, e.g. ptrauth and mte. With the refactoring done in this series, we should now be able to easily add register sublists and vcpu configs to the get-reg-list test, as the last patch demonstrates with the pmu fix.

Thanks,
drew

Andrew Jones (5):
KVM: arm64: selftests: get-reg-list: Introduce vcpu configs
KVM: arm64: selftests: get-reg-list: Prepare to run multiple configs
at once
KVM: arm64: selftests: get-reg-list: Provide config selection option
KVM: arm64: selftests: get-reg-list: Remove get-reg-list-sve
KVM: arm64: selftests: get-reg-list: Split base and pmu registers

 tools/testing/selftests/kvm/.gitignore        |   1 -
 tools/testing/selftests/kvm/Makefile          |   1 -
 .../selftests/kvm/aarch64/get-reg-list-sve.c  |   3 -
 .../selftests/kvm/aarch64/get-reg-list.c      | 439 +++++++++++++-----
 4 files changed, 321 insertions(+), 123 deletions(-)
 delete mode 100644 tools/testing/selftests/kvm/aarch64/get-reg-list-sve.c
Signature · 6 lines
2.31.1

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm