Skip to content

IIO: Runtime PM related cleanups.

Jonathan Cameron linux-iio 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 15 repliesIn review
  2. v128 patches 70 repliesSuperseded

Changes in v2 from the cover letter

* Drop all patches since applied.
* Clean up some more unbalanced cases that Mauro pointed out.
* One additional fix for lack of put in an error path.
* Dropped zpa2326 patch for now. The use of runtime pm in that driver is sufficiently odd that it needs a closer look before any changes.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6iio: imu: mpu6050: Balance runtime pm + use pm_runtime_resume_and_get()drivers/iio/imu/inv_mpu6050/inv_mpu_core.c drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c+8 -172 replies
2/6iio: adc: ads1015: Balance runtime pm + pm_runtime_resume_and_get()drivers/iio/adc/ti-ads1015.c+1 -42 replies
3/6iio: chemical: atlas-sensor: Balance runtime pm + pm_runtime_resume_and_get()drivers/iio/chemical/atlas-sensor.c+4 -93 replies
4/6iio: prox: pulsed-light-v2: Fix misbalance runtime pm in error pathdrivers/iio/proximity/pulsedlight-lidar-lite-v2.c+2 -13 replies
5/6iio: prox: pulsed-light-v2: Use pm_runtime_resume_and_get()drivers/iio/proximity/pulsedlight-lidar-lite-v2.c+3 -13 replies
6/6iio: pressure: icp10100: Balance runtime pm + use pm_runtime_resume_and_get()drivers/iio/pressure/icp10100.c+3 -22 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchMatt RanostayMauro Carvalho Chehab
1/6R-b
2/6R-b
3/6A-b R-b
4/6A-b R-b
5/6A-b R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] IIO: Runtime PM related cleanups.

From: Jonathan Cameron <[email protected]>

Changes since v1:
* Drop all patches since applied.
* Clean up some more unbalanced cases that Mauro pointed out.
* One additional fix for lack of put in an error path.
* Dropped zpa2326 patch for now. The use of runtime pm in that driver is sufficiently odd that it needs a closer look before any changes.

Note the unbalanced put is not a bug as such, because the runtime pm core protects against the reference count going negative. However, it is a bad pattern to have copied into new drivers (as it confuses me) so I'd like to clear it out.

Inspired by Mauro's work on similar issues in media and Julia's coccicheck script.

There will be at least one more set of these once this first set have flushed out any mistakes I may have made.

I checked my assumptions around the excess pm_runtime_put_noidle calls in QEMU but may well be missing something even so.

Cc Jean-Baptiste Maneyrol <[email protected]>
Cc Matt Ranostay <[email protected]>

Jonathan Cameron (6):
iio: imu: mpu6050: Balance runtime pm + use
pm_runtime_resume_and_get()
iio: adc: ads1015: Balance runtime pm + pm_runtime_resume_and_get()
iio: chemical: atlas-sensor: Balance runtime pm +
pm_runtime_resume_and_get()
iio: prox: pulsed-light-v2: Fix misbalance runtime pm in error path
iio: prox: pulsed-light-v2: Use pm_runtime_resume_and_get()
iio: pressure: icp10100: Balance runtime pm + use
pm_runtime_resume_and_get()

 drivers/iio/adc/ti-ads1015.c                  |  5 +----
 drivers/iio/chemical/atlas-sensor.c           | 13 ++++---------
 drivers/iio/imu/inv_mpu6050/inv_mpu_core.c    | 19 ++++++-------------
 drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c |  6 ++----
 drivers/iio/pressure/icp10100.c               |  5 +++--
 .../iio/proximity/pulsedlight-lidar-lite-v2.c |  7 +++++--
 6 files changed, 21 insertions(+), 34 deletions(-)
Signature · 1 line
2.31.1