Skip to content

Rename scsi_get_lba() into scsi_get_sector()

Bart Van Assche linux-scsi 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 14 repliesIn review
  2. v27 patches 9 repliesSuperseded
  3. v17 patches 1 replySuperseded

Changes in v3 from the cover letter

- Renamed scsi_get_pos() into scsi_get_sector() as suggested by Damien.
- Split the lpfc and qla2xxx changes into separate patches.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8core: Introduce scsi_get_sector()include/scsi/scsi_cmnd.h+5 -04 replies
2/8iser: Use scsi_get_sector() instead of scsi_get_lba()drivers/infiniband/ulp/iser/iser_verbs.c+1 -11 reply
3/8zfcp: Use scsi_get_sector() instead of scsi_get_lba()drivers/s390/scsi/zfcp_fsf.c+1 -12 replies
4/8isci: Use scsi_get_sector() instead of scsi_get_lba()drivers/scsi/isci/request.c+2 -21 reply
5/8lpfc: Use scsi_get_sector() instead of scsi_get_lba()drivers/scsi/lpfc/lpfc_scsi.c+6 -62 replies
6/8qla2xxx: Use scsi_get_sector() instead of scsi_get_lba()drivers/scsi/qla2xxx/qla_iocb.c drivers/scsi/qla2xxx/qla_isr.c+7 -102 replies
7/8ufs: Fix the tracing codedrivers/scsi/ufs/ufshcd.c include/trace/events/ufs.h+20 -241 reply
8/8core: Remove scsi_get_lba()include/scsi/scsi_cmnd.h+0 -51 reply

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchSagi GrimbergLee DuncanDamien Le MoalBenjamin Block
1/8R-b
2/8R-b R-b
3/8R-b A-b
4/8R-b R-b
5/8
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/8] Rename scsi_get_lba() into scsi_get_sector()

Hi Martin,

This patch series renames scsi_get_lba() into scsi_get_pos(). The name of scsi_get_lba() is confusing since it does not return an LBA but instead the start offset divided by 512.

Please consider this patch series for kernel v5.14.

Thanks,

Bart.

Changes compared to v2:
- Renamed scsi_get_pos() into scsi_get_sector() as suggested by Damien.
- Split the lpfc and qla2xxx changes into separate patches.

Changes compared to v1:
- Changed the "iscsi" prefix into "isci" for patch 4/7.
- Added support for READ(16) and WRITE(16) in patch 6/7.

Bart Van Assche (8):
core: Introduce scsi_get_sector()
iser: Use scsi_get_sector() instead of scsi_get_lba()
zfcp: Use scsi_get_sector() instead of scsi_get_lba()
isci: Use scsi_get_sector() instead of scsi_get_lba()
lpfc: Use scsi_get_sector() instead of scsi_get_lba()
qla2xxx: Use scsi_get_sector() instead of scsi_get_lba()
ufs: Fix the tracing code
core: Remove scsi_get_lba()

 drivers/infiniband/ulp/iser/iser_verbs.c |  2 +-
 drivers/s390/scsi/zfcp_fsf.c             |  2 +-
 drivers/scsi/isci/request.c              |  4 +--
 drivers/scsi/lpfc/lpfc_scsi.c            | 12 ++++-----
 drivers/scsi/qla2xxx/qla_iocb.c          |  9 +++----
 drivers/scsi/qla2xxx/qla_isr.c           |  8 +++---
 drivers/scsi/ufs/ufshcd.c                | 34 +++++++++++-------------
 include/scsi/scsi_cmnd.h                 |  2 +-
 include/trace/events/ufs.h               | 10 +++----
 9 files changed, 38 insertions(+), 45 deletions(-)