Skip to content

ad_sigma_delta: convert all drivers to device-managed

Alexandru Ardelean linux-iio lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 2 repliesIn review
  2. v312 patches 2 repliesSuperseded
  3. v212 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v111 patches3 repliesSuperseded

Changes in v4 from the cover letter

* https://lore.kernel.org/linux-iio/[email protected]/
* patch 'iio: adc: ad7192: handle zero Avdd regulator value'
is now 'iio: adc: ad7192: handle regulator voltage error first'
- now checking the regulator_voltage() return first for an error

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12iio: adc: ad7124: Fix missbalanced regulator enable / disable on error.drivers/iio/adc/ad7124.c+13 -160 replies
2/12iio: adc: ad7124: Fix potential overflow due to non sequential channel numbersdrivers/iio/adc/ad7124.c+7 -00 replies
3/12iio: adc: ad7192: Avoid disabling a clock that was never enabled.drivers/iio/adc/ad7192.c+6 -20 replies
4/12iio: adc: ad7192: handle regulator voltage error firstdrivers/iio/adc/ad7192.c+4 -71 reply
5/12iio: adc: ad_sigma_delta: introduct devm_ad_sd_setup_buffer_and_trigger()drivers/iio/adc/ad_sigma_delta.c include/linux/iio/adc/ad_sigma_delta.h+63 -00 replies
6/12iio: adc: ad7793: convert to device-managed functionsdrivers/iio/adc/ad7793.c+15 -380 replies
7/12iio: adc: ad7791: convert to device-managed functionsdrivers/iio/adc/ad7791.c+13 -310 replies
8/12iio: adc: ad7780: convert to device-managed functionsdrivers/iio/adc/ad7780.c+10 -280 replies
9/12iio: adc: ad7192: use devm_clk_get_optional() for mclkdrivers/iio/adc/ad7192.c+3 -30 replies
10/12iio: adc: ad7192: convert to device-managed functionsdrivers/iio/adc/ad7192.c+36 -530 replies
11/12iio: adc: ad7124: Use devm_ managed calls for all of probe() + drop remove()drivers/iio/adc/ad7124.c+15 -330 replies
12/12iio: adc: ad_sigma_delta: remove ad_sd_{setup,cleanup}_buffer_and_trigger()drivers/iio/adc/ad_sigma_delta.c include/linux/iio/adc/ad_sigma_delta.h+0 -890 replies

Reviews trailers per patch

4 of 12 patches have a Reviewed-by or Acked-by.

PatchAlexandru Ardelean
1/12R-b
2/12R-b
3/12R-b
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12R-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/12] ad_sigma_delta: convert all drivers to device-managed

Well, for lack of a better title that's what this series does.
It merges Jonathan's patches from:
* https://lore.kernel.org/linux-iio/[email protected]/
Patch 3/3 was a polished a bit with my comments from that review and also to use the devm_ad_sd_setup_buffer_and_trigger() function.
* https://lore.kernel.org/linux-iio/[email protected]/
Added only to base the conversion to devm_

The AD Sigma Delta family of ADC drivers share a lot of the logic in the ad_sigma_delta lib-driver.

This set introduces a devm_ad_sd_setup_buffer_and_trigger() call, which aims to replace the 'ad_sd_{setup,cleanup}_buffer_and_trigger()' pair.

This helps with converting the AD7780, AD7791, AD7793 and AD7192 drivers use be fully converted to device-managed functions.

Changelog v3 -> v4:
* https://lore.kernel.org/linux-iio/[email protected]/
* patch 'iio: adc: ad7192: handle zero Avdd regulator value'
is now 'iio: adc: ad7192: handle regulator voltage error first'
- now checking the regulator_voltage() return first for an error

Changelog v2 -> v3:
* https://lore.kernel.org/linux-iio/[email protected]/
* patch 'iio: adc: ad7192: handle zero Avdd regulator value as error' is now 'iio: adc: ad7192: handle zero Avdd regulator value' essentially just doing a simple 'if (voltage_uv >= 0)' check now

Changelog v1 -> v2:
* https://lore.kernel.org/linux-iio/[email protected]/
* add my S-o-b tags on all patches; with @deviqon.com email
- Note: I'm a little unsure about the correctness of these tags; there are a few mixed-in, with Reviewed-by & Signed-off-by; I'm fine if Jonathan tweaks these as needed;
* added patch 'iio: adc: ad7192: handle zero Avdd regulator value as error'
* all Fixes patches should be now at the beginning of the series

Alexandru Ardelean (8):
iio: adc: ad7192: handle regulator voltage error first
iio: adc: ad_sigma_delta: introduct
devm_ad_sd_setup_buffer_and_trigger()
iio: adc: ad7793: convert to device-managed functions
iio: adc: ad7791: convert to device-managed functions
iio: adc: ad7780: convert to device-managed functions
iio: adc: ad7192: use devm_clk_get_optional() for mclk
iio: adc: ad7192: convert to device-managed functions
iio: adc: ad_sigma_delta: remove
ad_sd_{setup,cleanup}_buffer_and_trigger()

Jonathan Cameron (4):
iio: adc: ad7124: Fix missbalanced regulator enable / disable on
error.
iio: adc: ad7124: Fix potential overflow due to non sequential channel
numbers
iio: adc: ad7192: Avoid disabling a clock that was never enabled.
iio: adc: ad7124: Use devm_ managed calls for all of probe() + drop
remove()

 drivers/iio/adc/ad7124.c               | 84 +++++++++-------------
 drivers/iio/adc/ad7192.c               | 98 +++++++++++---------------
 drivers/iio/adc/ad7780.c               | 38 +++-------
 drivers/iio/adc/ad7791.c               | 44 ++++--------
 drivers/iio/adc/ad7793.c               | 53 ++++----------
 drivers/iio/adc/ad_sigma_delta.c       | 82 ++++++++-------------
 include/linux/iio/adc/ad_sigma_delta.h |  4 +-
 7 files changed, 144 insertions(+), 259 deletions(-)
Signature · 1 line
2.31.1