Skip to content

block: add error handling for *add_disk*()

Luis Chamberlain linux-block lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 11 repliesIn review
  2. v18 patches 16 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6block: refcount the request_queue early in __device_add_disk()block/genhd.c+9 -91 reply
2/6block: move disk announce work from register_disk() to a helperblock/genhd.c+10 -42 replies
3/6block: move disk invalidation from del_gendisk() into a helperblock/genhd.c+26 -211 reply
4/6block: move disk unregistration work from del_gendisk() to a helperblock/genhd.c+26 -180 replies
5/6block: add initial error handling for *add_disk()* and friendsblock/blk-integrity.c block/blk-sysfs.c block/blk.h +3 more+112 -521 reply
6/6block: skip queue if NULL on blk_cleanup_queue()block/blk-core.c+3 -04 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/6R-b
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] block: add error handling for *add_disk*()

This v2 has the following changes:

- rebases onto a fresh linux-next which includes Christoph's latest cleanups
- dropping error injection as I inspect ebpf and other alternatives, yet I still tested this series with that patch and the only change needed was the last one.
- adds a new patch, the last one, to adjust to our preference now to always wish for users to call a cleanup like blk_cleanup_disk() when add_disk() fails.
- dropped driver conversion

Although I've dropped driver conversion at this point I've converted all drivers over, but that series is about 80 patches... and so should be dealt with after this basic core work is reviewed and merged.

Luis Chamberlain (6):
block: refcount the request_queue early in __device_add_disk()
block: move disk announce work from register_disk() to a helper
block: move disk invalidation from del_gendisk() into a helper
block: move disk unregistration work from del_gendisk() to a helper
block: add initial error handling for *add_disk()* and friends
block: skip queue if NULL on blk_cleanup_queue()

 block/blk-core.c      |   3 +
 block/blk-integrity.c |  12 ++-
 block/blk-sysfs.c     |   5 +-
 block/blk.h           |   7 +-
 block/disk-events.c   |   8 +-
 block/genhd.c         | 229 +++++++++++++++++++++++++++---------------
 include/linux/genhd.h |  14 +--
 7 files changed, 180 insertions(+), 98 deletions(-)
Signature · 1 line
2.27.0