Skip to content

vmalloc() vs bulk allocator v2

Uladzislau Rezki (Sony) linux-mm lkml 1 version Applied

Status from this message: [merged] mm-vmalloc-print-a-warning-message-first-on-failure.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesApplied 3/3

V1 -> V2 from the cover letter

- Switch to the alloc_pages_bulk_array_node() helper so the NUMA_NO_NODE is correctly handled(similar to alloc_pages_node() API func).
- Use "while()" loop instead of "for()" for high-order pages and increase number of allocated pages after actual alloc.

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3mm/page_alloc: Add an alloc_pages_bulk_array_node() helperinclude/linux/gfp.h+9 -00 repliesApplied
2/3mm/vmalloc: Switch to bulk allocator in __vmalloc_area_node()mm/vmalloc.c+42 -348 repliesApplied
3/3mm/vmalloc: Print a warning message first on failuremm/vmalloc.c+1 -10 repliesApplied

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchMel Gorman
1/3A-b
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] vmalloc() vs bulk allocator v2

Hi.

There are three patches in this small series. This is a second iteration. First one was buggy and leaded to kernel panic due to passing NUMA_NO_NODE as "nid" to the bulk allocator(it assumes to have a valid node).

Therefore the patch number [1] adds an extra helper that guarantees a correct numa node ID if it is not specified. Basically saying when it is invoked with NUMA_NO_NODE.

A patch [2] has been slightly updated, the change-log is below.

V1 -> V2:
- Switch to the alloc_pages_bulk_array_node() helper so the NUMA_NO_NODE is correctly handled(similar to alloc_pages_node() API func).
- Use "while()" loop instead of "for()" for high-order pages and increase number of allocated pages after actual alloc.

Uladzislau Rezki (Sony) (3):

[1]  mm/page_alloc: Add an alloc_pages_bulk_array_node() helper
[2]  mm/vmalloc: Switch to bulk allocator in __vmalloc_area_node()
[3]  mm/vmalloc: Print a warning message first on failure
 include/linux/gfp.h |  9 ++++++
 mm/vmalloc.c        | 78 +++++++++++++++++++++++++--------------------
 2 files changed, 52 insertions(+), 35 deletions(-)

--
2.20.1