Skip to content

block: publish backup-top filter

Vladimir Sementsov-Ogievskiy qemu-devel 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest34 patches 11 repliesIn review
  2. v733 patches 13 repliesSuperseded
  3. v633 patches 0 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v535 patches0 repliesSuperseded
v435 patches3 repliesSuperseded
v335 patches1 replySuperseded
v233 patches28 repliesSuperseded
v121 patches43 repliesSuperseded

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/34block: introduce bdrv_replace_child_bs()block.c include/block/block.h+33 -00 replies
2/34block: introduce blk_replace_bsblock/block-backend.c include/sysemu/block-backend.h+9 -00 replies
3/34qdev-properties: PropertyInfo: add realized_set_allowed fieldhw/core/qdev-properties.c include/hw/qdev-properties.h+4 -30 replies
4/34qdev: allow setting drive property for realized devicehw/core/qdev-properties-system.c+31 -120 replies
5/34block: rename backup-top to copy-before-writeMAINTAINERS block/backup.c block/copy-before-write.c +4 more+95 -1000 replies
6/34block-copy: move detecting fleecing scheme to block-copyblock/backup.c block/block-copy.c block/copy-before-write.c +2 more+26 -280 replies
7/34block/block-copy: introduce block_copy_set_copy_opts()block/block-copy.c include/block/block-copy.h+32 -201 reply
8/34block/backup: set copy_range and compress after filter insertionblock/backup.c block/copy-before-write.c block/copy-before-write.h+3 -50 replies
9/34block/backup: move cluster size calculation to block-copyblock/backup.c block/block-copy.c block/copy-before-write.c +2 more+66 -632 replies
10/34block/copy-before-write: relax permission requirements when no parentsblock/copy-before-write.c tests/qemu-iotests/283.out+6 -40 replies
11/34block/copy-before-write: drop extra bdrv_unref on failure pathblock/copy-before-write.c+0 -10 replies
12/34block/copy-before-write: use file child instead of backingblock/copy-before-write.c+22 -170 replies
13/34block/copy-before-write: bdrv_cbw_append(): replace child at lastblock/copy-before-write.c+11 -220 replies
14/34block/copy-before-write: introduce cbw_init()block/copy-before-write.c+41 -280 replies
15/34block/copy-before-write: cbw_init(): rename variablesblock/copy-before-write.c+14 -150 replies
16/34block/copy-before-write: cbw_init(): use file child after attachingblock/copy-before-write.c+7 -70 replies
17/34block/copy-before-write: bdrv_cbw_append(): drop unused compress argblock/backup.c block/copy-before-write.c block/copy-before-write.h+4 -60 replies
18/34block/copy-before-write: cbw_init(): use optionsblock/copy-before-write.c+15 -140 replies
19/34block/copy-before-write: initialize block-copy bitmapblock/backup.c block/copy-before-write.c+11 -90 replies
20/34block/block-copy: make setting progress optionalblock/block-copy.c+11 -70 replies
21/34block/copy-before-write: make public block driverblock/copy-before-write.c+28 -320 replies
22/34qapi: publish copy-before-write filterqapi/block-core.json+23 -20 replies
23/34python/qemu/machine.py: refactor _qemu_args()python/qemu/machine/machine.py+8 -100 replies
24/34python/qemu/machine: QEMUMachine: improve qmp() methodpython/qemu/machine/machine.py+11 -10 replies
25/34python:QEMUMachine: template typing for self returning methodspython/qemu/machine/machine.py+7 -31 reply
26/34iotests/222: fix pylint and mypy complainstests/qemu-iotests/222 tests/qemu-iotests/297+12 -100 replies
27/34iotests/222: constantly use single quotes for stringstests/qemu-iotests/222+34 -340 replies
28/34iotests: move 222 to tests/image-fleecingtests/qemu-iotests/tests/image-fleecing tests/qemu-iotests/tests/image-fleecing.out+0 -04 replies
29/34iotests.py: hmp_qemu_io: support qdevtests/qemu-iotests/iotests.py+3 -20 replies
30/34iotests/image-fleecing: proper source devicetests/qemu-iotests/tests/image-fleecing tests/qemu-iotests/tests/image-fleecing.out+9 -50 replies
31/34iotests/image-fleecing: rename tgt_nodetests/qemu-iotests/tests/image-fleecing+7 -70 replies
32/34iotests/image-fleecing: prepare for adding new test-casetests/qemu-iotests/tests/image-fleecing+13 -60 replies
33/34iotests/image-fleecing: add test-case for copy-before-write filtertests/qemu-iotests/tests/image-fleecing tests/qemu-iotests/tests/image-fleecing.out+107 -150 replies
34/34block/block-copy: block_copy_state_new(): drop extra argumentsblock/block-copy.c block/copy-before-write.c include/block/block-copy.h+3 -51 reply

Reviews trailers per patch

All 34 patches have a Reviewed-by or Acked-by.

PatchMax ReitzHanna ReitzJohn SnowMarkus Armbruster
1/34R-b
2/34R-b
3/34R-b
4/34R-b
5/34R-b
6/34R-b
7/34R-b
8/34R-b
9/34R-b
10/34R-b
11/34R-b
12/34R-b
13/34R-b
14/34R-b
15/34R-b
16/34R-b
17/34R-b
18/34R-b
19/34R-b
20/34R-b
21/34R-b
22/34R-b A-b
23/34R-b R-b
24/34R-b R-b
25/34R-b
26/34R-b
27/34R-b
28/34R-b
29/34R-b R-b
30/34R-b
31/34R-b
32/34R-b
33/34R-b
34/34R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v8 thread

Cover letter [PATCH v8 00/34] block: publish backup-top filter

Hi all!

v8:

06: add Hanna's r-b
07: keep is_fleecing detection in _new() function
08,17,18: add Hanna's r-b
19: wording, s/6.1/6.2/, add Markus's a-b
25: new
29: add John's r-b
34: new

Patches without r-b: 07, 25, 34

Vladimir Sementsov-Ogievskiy (34):
block: introduce bdrv_replace_child_bs()
block: introduce blk_replace_bs
qdev-properties: PropertyInfo: add realized_set_allowed field
qdev: allow setting drive property for realized device
block: rename backup-top to copy-before-write
block-copy: move detecting fleecing scheme to block-copy block/block-copy: introduce block_copy_set_copy_opts() block/backup: set copy_range and compress after filter insertion block/backup: move cluster size calculation to block-copy block/copy-before-write: relax permission requirements when no parents block/copy-before-write: drop extra bdrv_unref on failure path block/copy-before-write: use file child instead of backing block/copy-before-write: bdrv_cbw_append(): replace child at last block/copy-before-write: introduce cbw_init() block/copy-before-write: cbw_init(): rename variables block/copy-before-write: cbw_init(): use file child after attaching block/copy-before-write: bdrv_cbw_append(): drop unused compress arg block/copy-before-write: cbw_init(): use options block/copy-before-write: initialize block-copy bitmap block/block-copy: make setting progress optional block/copy-before-write: make public block driver
qapi: publish copy-before-write filter python/qemu/machine.py: refactor _qemu_args() python/qemu/machine: QEMUMachine: improve qmp() method python:QEMUMachine: template typing for self returning methods iotests/222: fix pylint and mypy complains
iotests/222: constantly use single quotes for strings
iotests: move 222 to tests/image-fleecing
iotests.py: hmp_qemu_io: support qdev iotests/image-fleecing: proper source device iotests/image-fleecing: rename tgt_node iotests/image-fleecing: prepare for adding new test-case iotests/image-fleecing: add test-case for copy-before-write filter block/block-copy: block_copy_state_new(): drop extra arguments

 qapi/block-core.json                        |  25 +-
 block/{backup-top.h => copy-before-write.h} |  25 +-
 include/block/block-copy.h                  |   6 +-
 include/block/block.h                       |   2 +
 include/hw/qdev-properties.h                |   1 +
 include/sysemu/block-backend.h              |   1 +
 block.c                                     |  31 +++
 block/backup-top.c                          | 253 -------------------
 block/backup.c                              | 116 ++-------
 block/block-backend.c                       |   8 +
 block/block-copy.c                          | 135 ++++++++---
 block/copy-before-write.c                   | 256 ++++++++++++++++++++
 hw/core/qdev-properties-system.c            |  43 +++-
 hw/core/qdev-properties.c                   |   6 +-
 MAINTAINERS                                 |   4 +-
 block/meson.build                           |   2 +-
 python/qemu/machine/machine.py              |  40 +--
 tests/qemu-iotests/222                      | 159 ------------
 tests/qemu-iotests/222.out                  |  67 -----
 tests/qemu-iotests/283                      |  35 ++-
 tests/qemu-iotests/283.out                  |   4 +-
 tests/qemu-iotests/297                      |   2 +-
 tests/qemu-iotests/iotests.py               |   5 +-
 tests/qemu-iotests/tests/image-fleecing     | 192 +++++++++++++++
 tests/qemu-iotests/tests/image-fleecing.out | 139 +++++++++++
 25 files changed, 885 insertions(+), 672 deletions(-)
 rename block/{backup-top.h => copy-before-write.h} (56%)
 delete mode 100644 block/backup-top.c
 create mode 100644 block/copy-before-write.c
 delete mode 100755 tests/qemu-iotests/222
 delete mode 100644 tests/qemu-iotests/222.out
 create mode 100755 tests/qemu-iotests/tests/image-fleecing
 create mode 100644 tests/qemu-iotests/tests/image-fleecing.out
Signature · 1 line
2.29.2