Skip to content

x86: switch to generic syscall{tbl,hdr}.sh with various syscall code cleanups

Masahiro Yamada linux-um lkml 1 version Applied

Status from this message: The following commit has been merged into the x86/entry branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 0 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6x86/entry/x32: rename __x32_compat_sys_* to __x64_compat_sys_*arch/x86/entry/syscall_x32.c arch/x86/include/asm/syscall_wrapper.h+7 -190 replies
2/6x86/syscalls: switch to generic syscalltbl.sharch/x86/entry/syscall_32.c arch/x86/entry/syscall_64.c arch/x86/entry/syscall_x32.c +5 more+34 -760 replies
3/6x86/syscalls: stop filling syscall arrays with *_sys_ni_syscallarch/x86/entry/syscall_32.c arch/x86/entry/syscall_64.c arch/x86/entry/syscall_x32.c +2 more+6 -360 replies
4/6x86/unistd: define X32_NR_syscalls only for 64-bit kernelarch/x86/include/asm/unistd.h+1 -10 replies
5/6x86/syscalls: use __NR_syscalls instead of __NR_syscall_maxarch/um/kernel/skas/syscall.c arch/x86/entry/syscalls/syscallhdr.sh arch/x86/include/asm/unistd.h+6 -60 replies
6/6x86/syscalls: switch to generic syscallhdr.sharch/x86/entry/syscalls/Makefile arch/x86/entry/syscalls/syscallhdr.sh+13 -480 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RESEND PATCH 0/6] x86: switch to generic syscall{tbl,hdr}.sh with various syscall code cleanups

Previously, many architectures duplicated similar scripts to generate syscall headers.

For v5.11:

  $ find  arch  -name syscalltbl.sh
  arch/parisc/kernel/syscalls/syscalltbl.sh
  arch/alpha/kernel/syscalls/syscalltbl.sh
  arch/microblaze/kernel/syscalls/syscalltbl.sh
  arch/powerpc/kernel/syscalls/syscalltbl.sh
  arch/arm/tools/syscalltbl.sh
  arch/sparc/kernel/syscalls/syscalltbl.sh
  arch/sh/kernel/syscalls/syscalltbl.sh
  arch/xtensa/kernel/syscalls/syscalltbl.sh
  arch/ia64/kernel/syscalls/syscalltbl.sh
  arch/x86/entry/syscalls/syscalltbl.sh
  arch/mips/kernel/syscalls/syscalltbl.sh
  arch/m68k/kernel/syscalls/syscalltbl.sh
  $ find  arch  -name  syscallhdr.sh
  arch/parisc/kernel/syscalls/syscallhdr.sh
  arch/alpha/kernel/syscalls/syscallhdr.sh
  arch/microblaze/kernel/syscalls/syscallhdr.sh
  arch/powerpc/kernel/syscalls/syscallhdr.sh
  arch/arm/tools/syscallhdr.sh
  arch/sparc/kernel/syscalls/syscallhdr.sh
  arch/sh/kernel/syscalls/syscallhdr.sh
  arch/xtensa/kernel/syscalls/syscallhdr.sh
  arch/ia64/kernel/syscalls/syscallhdr.sh
  arch/x86/entry/syscalls/syscallhdr.sh
  arch/mips/kernel/syscalls/syscallhdr.sh
  arch/m68k/kernel/syscalls/syscallhdr.sh

They were mostly consolidated by the time of v5.13-rc1:

Now:

  $ find  arch  -name syscalltbl.sh
  arch/x86/entry/syscalls/syscalltbl.sh
  $ find  arch  -name  syscallhdr.sh
  arch/x86/entry/syscalls/syscallhdr.sh

x86 is a remaining bit because x86 maintainers did not respond.

This patch series makes a lot of cleanups. We can remove a lot of lines.
The code diff is attractive.

No code change since the previous submission. (Only 1/7 was applied, so dropped from the series)

https://lore.kernel.org/lkml/[email protected]/

Masahiro Yamada (6):
x86/entry/x32: rename __x32_compat_sys_* to __x64_compat_sys_* x86/syscalls: switch to generic syscalltbl.sh x86/syscalls: stop filling syscall arrays with *_sys_ni_syscall x86/unistd: define X32_NR_syscalls only for 64-bit kernel x86/syscalls: use __NR_syscalls instead of __NR_syscall_max x86/syscalls: switch to generic syscallhdr.sh

 arch/um/kernel/skas/syscall.c          |  2 +-
 arch/x86/entry/syscall_32.c            | 20 +++++------
 arch/x86/entry/syscall_64.c            | 17 +++-------
 arch/x86/entry/syscall_x32.c           | 35 ++++----------------
 arch/x86/entry/syscalls/Makefile       | 36 +++++++++++---------
 arch/x86/entry/syscalls/syscallhdr.sh  | 35 --------------------
 arch/x86/entry/syscalls/syscalltbl.sh  | 46 --------------------------
 arch/x86/include/asm/Kbuild            |  1 +
 arch/x86/include/asm/syscall_wrapper.h | 10 +++---
 arch/x86/include/asm/unistd.h          |  8 ++---
 arch/x86/um/sys_call_table_32.c        | 14 +++-----
 arch/x86/um/sys_call_table_64.c        | 15 ++-------
 12 files changed, 60 insertions(+), 179 deletions(-)
 delete mode 100644 arch/x86/entry/syscalls/syscallhdr.sh
 delete mode 100644 arch/x86/entry/syscalls/syscalltbl.sh
Signature · 7 lines
2.27.0


_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um