block-copy: protect block-copy internal structures
Status from this message: Thanks, applied to the jobs branch
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest5 patches 2 repliesApplied
- v46 patches 23 repliesSuperseded
- v35 patches 13 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 7 patches | 40 replies | Superseded |
Changes in v5 from the cover letter
* Squash patch 3 (improve comments) with patch 5 (add CoMutex).
* Better comments in block-copy, drop IN/OUT/State categories
* Remove some load_acquire in patch 6, replace them with atomic reads
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | block-copy: small refactor in block_copy_task_entry and block_copy_commonblock/ | +8 | 0 replies | |
| 2/5 | block-copy: streamline choice of copy_range vs. read/writeblock/ | +90 | 0 replies | |
| 3/5 | block-copy: move progress_set_remaining in block_copy_task_endblock/ | +3 | 0 replies | |
| 4/5 | block-copy: add CoMutex lockblock/ | +116 | 0 replies | |
| 5/5 | block-copy: atomic .cancelled and .finished fields in BlockCopyCallStateblock/ include/ | +24 | 0 replies |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Vladimir Sementsov-Ogievskiy |
|---|---|
| Series | R-b |
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/5] block-copy: protect block-copy internal structures
This serie of patches aims to reduce the usage of the AioContexlock in block-copy, by introducing smaller granularity locks thus on making the block layer thread safe.
This serie depends on my previous serie that brings thread safety to the smaller API used by block-copy, like ratelimit, progressmeter abd co-shared-resource.
What's missing for block-copy to be fully thread-safe is fixing the CoSleep API to allow cross-thread sleep and wakeup. Paolo is working on it.
Patch 1 provides a small refactoring, patch 2 introduces the .method field in BlockCopyState, to be used instead of .use_copy_range, .copy_size and .zeros.
Patch 3 provide a refactoring in preparation to
the lock added in patch 4 on BlockCopyTask, BlockCopyCallState and BlockCopyState. Patch 5 uses load_acquire/store_release to make sure BlockCopyCallState OUT fields are updated before finished is set to true.
Based-on: <[email protected]>
---
v5:
* Squash patch 3 (improve comments) with patch 5 (add CoMutex).
* Better comments in block-copy, drop IN/OUT/State categories
* Remove some load_acquire in patch 6, replace them with atomic reads
Emanuele Giuseppe Esposito (4):
block-copy: small refactor in block_copy_task_entry and
block_copy_common
block-copy: move progress_set_remaining in block_copy_task_end
block-copy: add CoMutex lock
block-copy: atomic .cancelled and .finished fields in
BlockCopyCallState
Paolo Bonzini (1):
block-copy: streamline choice of copy_range vs. read/write
include/block/block-copy.h | 2 + block/block-copy.c | 368 +++++++++++++++++++++++-------------- 2 files changed, 231 insertions(+), 139 deletions(-)
Signature · 1 line
2.31.1