Skip to content

iio: accel: mma9551/mma9553 Cleanup and update

Jonathan Cameron linux-iio 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 2 repliesIn review
  2. v2 posting 2/25 patches 1 replySuperseded
  3. v2 posting 1/25 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches9 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5iio: accel: mma9551/mma9553: Drop explicit ACPI match supportdrivers/iio/accel/mma9551.c drivers/iio/accel/mma9553.c+0 -420 replies
2/5iio: accel: mma9551/mma9553: Simplify pm logicdrivers/iio/accel/mma9551.c drivers/iio/accel/mma9553.c+8 -670 replies
3/5iio: accel: mma9551: Add support to get irqs directly from fwnodedrivers/iio/accel/mma9551.c+10 -202 replies
4/5iio: accel: mma9551: Use devm managed functions to tidy up probe()drivers/iio/accel/mma9551.c+38 -330 replies
5/5iio: accel: mma9553: Use devm managed functions to tidy up probe()drivers/iio/accel/mma9553.c+37 -330 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchAndy ShevchenkoAlexandru ArdeleanHans de Goede
1/5A-b R-b A-b
2/5R-b
3/5
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/5] iio: accel: mma9551/mma9553 Cleanup and update

From: Jonathan Cameron <[email protected]>

Whilst testing would be ideal, getting some eyes on this should be sufficient if we can't find anyone with a test part. Note that patch 3 needs most attention as it currently has no review tags.

v3: Updated commit log for patch 3 which didn't reflect the v2 changes (oops).
Picked up Hans' tag for patch 1 (thanks)
v2: mma9551: Drop the gpio based irq support as not known to be used
and adds complexity which is nice to get rid of.

This series came about because I was looking to write a dt-binding for these two (currently missing entirely) and I discovered the mma9551 driver in particular was doing some unusual things.

Note however, I've only tested the fwnode_irq_get() patch using a hacked up version of QEMU and stubbing out some error paths because I'm too lazy to emulate it properly ;)

The ACPI entries seem unlikely, but please shout if anyone knows of them being used in the wild.

It would be particularly helpful if anyone who has either of these parts could both give this a spin and let me know so I can ask for testing in future.

Jonathan Cameron (5):
iio: accel: mma9551/mma9553: Drop explicit ACPI match support
iio: accel: mma9551/mma9553: Simplify pm logic
iio: accel: mma9551: Add support to get irqs directly from fwnode
iio: accel: mma9551: Use devm managed functions to tidy up probe()
iio: accel: mma9553: Use devm managed functions to tidy up probe()

 drivers/iio/accel/mma9551.c | 151 ++++++++++++------------------------
 drivers/iio/accel/mma9553.c | 121 +++++++++--------------------
 2 files changed, 85 insertions(+), 187 deletions(-)
Signature · 1 line
2.34.1