Skip to content

media: fix zero-length USB control requests

Johan Hovold linux-media linux-usb lkml stable 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- keep the rtl28xxu zero-length read request which is needed for proper type detection (Eero)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3media: gspca/gl860: fix zero-length control requestsdrivers/media/usb/gspca/gl860/gl860.c+2 -20 replies
2/3media: gspca/sunplus: fix zero-length control requestsdrivers/media/usb/gspca/sunplus.c+6 -20 replies
3/3media: rtl28xxu: fix zero-length control requestdrivers/media/usb/dvb-usb-v2/rtl28xxu.c+10 -10 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchEero Lehtinen
1/3
2/3
3/3T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] media: fix zero-length USB control requests

The direction of the pipe argument must match the request-type direction bit or control requests may fail depending on the host-controller-driver implementation.

Control transfers without a data stage are treated as OUT requests by the USB stack and should be using usb_sndctrlpipe(). Failing to do so will now trigger a warning.

This series fixes the three media drivers that got this wrong.

Johan

Changes in v2
- keep the rtl28xxu zero-length read request which is needed for proper type detection (Eero)

Johan Hovold (3):
media: gspca/gl860: fix zero-length control requests
media: gspca/sunplus: fix zero-length control requests
media: rtl28xxu: fix zero-length control request

 drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 11 ++++++++++-
 drivers/media/usb/gspca/gl860/gl860.c   |  4 ++--
 drivers/media/usb/gspca/sunplus.c       |  8 ++++++--
 3 files changed, 18 insertions(+), 5 deletions(-)
Signature · 1 line
2.31.1