Skip to content

Fix memory ordering errors in queues

Bob Pearson linux-rdma 2 versions – Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 5 repliesApplied
  2. v22 patches 3 repliesSuperseded

Changes in v3 from the cover letter

Protected kernel index in shared queues from modification by user space. Pass queue type to allow compiler to optimize queue methods.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3RDMA/rxe: Add a type flag to rxe_queue structsdrivers/infiniband/sw/rxe/rxe_cq.c drivers/infiniband/sw/rxe/rxe_qp.c drivers/infiniband/sw/rxe/rxe_queue.c +2 more+28 -132 replies
2/3RDMA/rxe: Protect user space index loads/storesdrivers/infiniband/sw/rxe/rxe_queue.h+117 -510 replies
3/3RDMA/rxe: Protext kernel index from user spacedrivers/infiniband/sw/rxe/rxe_comp.c drivers/infiniband/sw/rxe/rxe_cq.c drivers/infiniband/sw/rxe/rxe_qp.c +7 more+305 -980 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH for-next v3 0/3] Fix memory ordering errors in queues

These patches optimize the memory ordering in rxe_queue.h so that user space and not kernel space indices are protected for loads with smp_load_acquire() and stores with smp_store_release(). The original implementation of this did not apply to all index references which has recently caused test case errors traced to stale memory loads. These patches fix those errors and also protect kernel indices from malicious modification by user space.

Fixes d21a1240f516 ("RDMA/rxe: Use acquire/release for memory ordering")

---
v3:
Protected kernel index in shared queues from modification by user space. Pass queue type to allow compiler to optimize queue methods.
v2:
Add a way to distinguish between user and kernel indices.
v1:
Add missing smp_load_acquire() calls.
---
Bob Pearson (3):
RDMA/rxe: Add a type flag to rxe_queue structs
RDMA/rxe: Protect user space index loads/stores
RDMA/rxe: Protext kernel index from user space

 drivers/infiniband/sw/rxe/rxe_comp.c  |  31 ++-
 drivers/infiniband/sw/rxe/rxe_cq.c    |  32 ++-
 drivers/infiniband/sw/rxe/rxe_qp.c    |  22 ++-
 drivers/infiniband/sw/rxe/rxe_queue.c |  21 +-
 drivers/infiniband/sw/rxe/rxe_queue.h | 272 ++++++++++++++++++++------
 drivers/infiniband/sw/rxe/rxe_req.c   |  46 +++--
 drivers/infiniband/sw/rxe/rxe_resp.c  |  44 ++++-
 drivers/infiniband/sw/rxe/rxe_srq.c   |   5 +-
 drivers/infiniband/sw/rxe/rxe_verbs.c |  80 ++++++--
 drivers/infiniband/sw/rxe/rxe_verbs.h |   5 +-
 10 files changed, 423 insertions(+), 135 deletions(-)
Signature · 1 line
2.30.2