Skip to content

xfs: buffer bulk page allocation and cleanups

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10xfs: split up xfs_buf_allocate_memoryfs/xfs/xfs_buf.c+74 -522 replies
2/10xfs: use xfs_buf_alloc_pages for uncached buffersfs/xfs/libxfs/xfs_ag.c fs/xfs/xfs_buf.c+6 -221 reply
3/10xfs: use alloc_pages_bulk_array() for buffersfs/xfs/xfs_buf.c+24 -382 replies
4/10xfs: merge _xfs_buf_get_pages()fs/xfs/xfs_buf.c+14 -341 reply
5/10xfs: move page freeing into _xfs_buf_free_pages()fs/xfs/xfs_buf.c+23 -381 reply
6/10xfs: remove ->b_offset handling for page backed buffersfs/xfs/xfs_buf.c fs/xfs/xfs_buf.h+5 -62 replies
7/10xfs: simplify the b_page_count calculationfs/xfs/xfs_buf.c+3 -112 replies
8/10xfs: get rid of xb_to_gfp()fs/xfs/xfs_buf.c+6 -41 reply
9/10xfs: cleanup error handling in xfs_buf_get_mapfs/xfs/xfs_buf.c+7 -81 reply
10/10xfs: merge xfs_buf_allocate_memoryfs/xfs/xfs_buf.c+13 -311 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchDarrick J. Wong
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] xfs: buffer bulk page allocation and cleanups

Hi folks,

This is a rework of my original patch posted here:

https://lore.kernel.org/linux-xfs/[email protected]/

and combines the cleanups proposed by Christoph in this patchset:

https://lore.kernel.org/linux-xfs/[email protected]/

THe code largely ends up in the same place and structure, just takes a less convoluted route to get there. The first two patches are refactoring buffer memory allocation and converting the uncached buffer path to use the same page allocation path, followed by converting the page allocation path to use bulk allocation.

The rest of the patches are then consolidation of the page allocation and freeing code to simplify the code and remove a chunk of unnecessary abstraction. This largely follows the changes the Christoph made.

This passes fstests on default settings, and mostly passes with a directory block size of 64kB (16 pages bulk allocation at a time). THere are recent regressions in 64kB directory block functionality in 5.13-rc1 - none of which appear to be a result of this patch set so I'm posting it for review anyway.

Cheers,

Dave.