xfs: buffer bulk page allocation and cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | xfs: split up xfs_buf_allocate_memoryfs/ | +74 | 2 replies | |
| 2/10 | xfs: use xfs_buf_alloc_pages for uncached buffersfs/ fs/ | +6 | 1 reply | |
| 3/10 | xfs: use alloc_pages_bulk_array() for buffersfs/ | +24 | 2 replies | |
| 4/10 | xfs: merge _xfs_buf_get_pages()fs/ | +14 | 1 reply | |
| 5/10 | xfs: move page freeing into _xfs_buf_free_pages()fs/ | +23 | 1 reply | |
| 6/10 | xfs: remove ->b_offset handling for page backed buffersfs/ fs/ | +5 | 2 replies | |
| 7/10 | xfs: simplify the b_page_count calculationfs/ | +3 | 2 replies | |
| 8/10 | xfs: get rid of xb_to_gfp()fs/ | +6 | 1 reply | |
| 9/10 | xfs: cleanup error handling in xfs_buf_get_mapfs/ | +7 | 1 reply | |
| 10/10 | xfs: merge xfs_buf_allocate_memoryfs/ | +13 | 1 reply |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Darrick J. Wong |
|---|---|
| 1/10 | R-b |
| 2/10 | R-b |
| 3/10 | R-b |
| 4/10 | R-b |
| 5/10 | R-b |
| 6/10 | R-b |
| 7/10 | R-b |
| 8/10 | R-b |
| 9/10 | R-b |
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/10] xfs: buffer bulk page allocation and cleanups
Hi folks,
This is a rework of my original patch posted here:
https://lore.kernel.org/linux-xfs/[email protected]/
and combines the cleanups proposed by Christoph in this patchset:
https://lore.kernel.org/linux-xfs/[email protected]/
THe code largely ends up in the same place and structure, just takes a less convoluted route to get there. The first two patches are refactoring buffer memory allocation and converting the uncached buffer path to use the same page allocation path, followed by converting the page allocation path to use bulk allocation.
The rest of the patches are then consolidation of the page allocation and freeing code to simplify the code and remove a chunk of unnecessary abstraction. This largely follows the changes the Christoph made.
This passes fstests on default settings, and mostly passes with a directory block size of 64kB (16 pages bulk allocation at a time). THere are recent regressions in 64kB directory block functionality in 5.13-rc1 - none of which appear to be a result of this patch set so I'm posting it for review anyway.
Cheers,
Dave.