Skip to content

Enhance pipe color support for multi segmented luts

Uma Shankar dri-devel intel-gfx oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm: Add gamma mode propertydrivers/gpu/drm/drm_atomic_uapi.c drivers/gpu/drm/drm_color_mgmt.c include/drm/drm_color_mgmt.h +2 more+145 -03 replies
2/9drm/i915/xelpd: Define color lut range structuredrivers/gpu/drm/i915/display/intel_color.c+246 -40 replies
3/9drm/i915/xelpd: Add support for Logarithmic gamma modedrivers/gpu/drm/i915/display/intel_color.c drivers/gpu/drm/i915/i915_reg.h include/drm/drm_crtc.h+110 -50 replies
4/9drm/i915/xelpd: Attach gamma mode propertydrivers/gpu/drm/i915/display/intel_color.c+1 -00 replies
5/9drm: Add Client Cap for advance gamma modedrivers/gpu/drm/drm_atomic_uapi.c drivers/gpu/drm/drm_ioctl.c include/drm/drm_atomic.h +3 more+33 -02 replies
6/9drm/i915/xelpd: logarithmic gamma enabled only with advance gamma modedrivers/gpu/drm/i915/display/intel_color.c+9 -50 replies
7/9drm/i915/xelpd: Enable Pipe Degammadrivers/gpu/drm/i915/display/intel_color.c+9 -30 replies
8/9drm/i915/xelpd: Add Pipe Color Lut caps to platform configdrivers/gpu/drm/i915/i915_pci.c+2 -10 replies
9/9drm/i915/xelpd: Enable XE_LPD Gamma Lut readoutdrivers/gpu/drm/i915/display/intel_color.c drivers/gpu/drm/i915/i915_reg.h+78 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] Enhance pipe color support for multi segmented luts

Modern hardwares have multi segmented lut approach to prioritize the darker regions of the spectrum. This series introduces a new UAPI to define the lut ranges supported by the respective hardware.

This also enables Pipe Color Management Support for Intel's XE_LPD hw. Enable Support for Pipe Degamma with the increased lut samples supported by hardware. This also adds support for newly introduced Logarithmic Gamma for XE_LPD. Also added the gamma readout support.

The Logarithmic gamma implementation on XE_LPD is non linear and adds 25 segments with non linear lut samples in each segment. The expectation is userspace will create the luts as per this distribution and pass the final samples to driver to be programmed in hardware.

+-----+------------------------------+
| x   |  2 pow x segment|No of Entries
|     |  0              | 1          |
| 0   |  1              | 1          |
| 1   |  2              | 2          |
| 2   |  4              | 2          |
| 3   |  8              | 2          |
| 4   |  16             | 2          |
| 5   |  32             | 4          |
| 6   |  64             | 4          |
| 7   |  128            | 4          |
| 8   |  256            | 8          |
| 9   |  512            | 8          |
| 10  |  1024           | 8          |
| 11  |  2048           | 16         |
| 12  |  4096           | 16         |
| 13  |  8192           | 16         |
| 14  |  16384          | 32         |
| 15  |  32768          | 32         |
| 16  |  65536          | 64         |
| 17  |  131072         | 64         |
| 18  |  262144         | 64         |
| 19  |  524288         | 32         |
| 20  |  1048576        | 32         |
| 21  |  2097152        | 32         |
| 22  |  4194304        | 32         |
| 23  |  8388608        | 32         |
| 24  |  16777216       | 1          |
|     | Total Entries   | 511        |

-----+-----------------+------------+

Credits: Special mention and credits to Ville Syrjala for coming up with a design for this feature and inputs. This series is based on his original design.

Note: Userspace support for this new UAPI will be done on Chrome and plan is to get this supported on mutter as well. We will notify the list once we have that ready for review.

Uma Shankar (9):
drm: Add gamma mode property
drm/i915/xelpd: Define color lut range structure drm/i915/xelpd: Add support for Logarithmic gamma mode drm/i915/xelpd: Attach gamma mode property
drm: Add Client Cap for advance gamma mode
drm/i915/xelpd: logarithmic gamma enabled only with advance gamma mode drm/i915/xelpd: Enable Pipe Degamma
drm/i915/xelpd: Add Pipe Color Lut caps to platform config drm/i915/xelpd: Enable XE_LPD Gamma Lut readout

 drivers/gpu/drm/drm_atomic_uapi.c          |   8 +
 drivers/gpu/drm/drm_color_mgmt.c           |  75 ++++
 drivers/gpu/drm/drm_ioctl.c                |   5 +
 drivers/gpu/drm/i915/display/intel_color.c | 454 ++++++++++++++++++++-
 drivers/gpu/drm/i915/i915_pci.c            |   3 +-
 drivers/gpu/drm/i915/i915_reg.h            |   7 +
 include/drm/drm_atomic.h                   |   1 +
 include/drm/drm_color_mgmt.h               |   8 +
 include/drm/drm_crtc.h                     |  25 ++
 include/drm/drm_file.h                     |   8 +
 include/uapi/drm/drm.h                     |   8 +
 include/uapi/drm/drm_mode.h                |  43 ++
 12 files changed, 630 insertions(+), 15 deletions(-)
Signature · 1 line
2.26.2