Skip to content

XDP_TX improvements for ice

Maciej Fijalkowski bpf intel-wired-lan netdev 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest9 patches 10 repliesIn review
  2. v69 patches 1 replySuperseded
  3. v59 patches 6 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v46 patches0 repliesSuperseded
v36 patches2 repliesSuperseded
v24 patches1 replySuperseded
v12 patches6 repliesSuperseded

Changes in v7 from the cover letter

* fix compilation issues when CONFIG_NET_SWITCHDEV=y

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9ice: remove ring_active from ice_ringdrivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_main.c drivers/net/ethernet/intel/ice/ice_txrx.h+0 -51 reply
2/9ice: move ice_container_type onto ice_ring_containerdrivers/net/ethernet/intel/ice/ice_base.c drivers/net/ethernet/intel/ice/ice_ethtool.c drivers/net/ethernet/intel/ice/ice_txrx.h+23 -231 reply
3/9ice: split ice_ring onto Tx/Rx separate structsdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_base.c drivers/net/ethernet/intel/ice/ice_base.h +18 more+397 -3251 reply
4/9ice: unify xdp_rings accessesdrivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_main.c drivers/net/ethernet/intel/ice/ice_txrx_lib.c+3 -31 reply
5/9ice: do not create xdp_frame on XDP_TXdrivers/net/ethernet/intel/ice/ice_txrx.c+1 -11 reply
6/9ice: propagate xdp_ring onto rx_ringdrivers/net/ethernet/intel/ice/ice_main.c drivers/net/ethernet/intel/ice/ice_txrx.c drivers/net/ethernet/intel/ice/ice_txrx.h +3 more+35 -291 reply
7/9ice: optimize XDP_TX workloadsdrivers/net/ethernet/intel/ice/ice_main.c drivers/net/ethernet/intel/ice/ice_txrx.c drivers/net/ethernet/intel/ice/ice_txrx.h +1 more+88 -251 reply
8/9ice: introduce XDP_TX fallback pathdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_main.c +3 more+75 -91 reply
9/9ice: make use of ice_for_each_* macrosdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_arfs.c drivers/net/ethernet/intel/ice/ice_dcb_lib.c +3 more+30 -271 reply

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMagnus KarlssonGeorge KuruvinakunnelGurucharan G
SeriesA-b
1/9T-b
2/9T-b
3/9T-b
4/9T-b
5/9T-b
6/9T-b
7/9T-b
8/9T-b
9/9T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 intel-next 0/9] XDP_TX improvements for ice

I didn't realize that on v6 I didn't have CONFIG_NET_SWITCHDEV option set in the kernel config. I removed ice_eswitch_remap_ring but didn't adjust the q_vector's ring pointer to the new Rx/Tx union.

Hope that it's the last time of embarrassment :)

v6->v7:
* fix compilation issues when CONFIG_NET_SWITCHDEV=y

v5->v6:
* rebase set on Tony's dev-queue
* adjust switchdev code to ring split
* compile with W=1 C=2 and fix outstanding kdoc issues

v4->v5:
* fix issues pointed by lkp; variables used for updating ring stats could be un-inited
* s/ice_ring/ice_rx_ring; it looks now symmetric given that we have ice_tx_ring struct dedicated for Tx ring
* go through the code and use ice_for_each_* macros; it was spotted by Brett that there was a place around that code that this set is touching that was not using the ice_for_each_txq. Turned out that there were more such places
* take care of coalesce related code; carry the info about type of ring container in ice_ring_container
* pull out getting rid of @ring_active onto separate patch, as suggested by Brett

v3->v4:
* fix lkp issues;

v2->v3:
* improve XDP_TX in a proper way
* split ice_ring
* propagate XDP ring pointer to Rx ring

v1->v2:
* try to improve XDP_TX processing

v6 : https://lore.kernel.org/bpf/20210818135916.25007-1-maciej.fijalkowski at intel.com/ v5 : https://lore.kernel.org/bpf/20210818075256.GA16780 at ranger.igk.intel.com/ v4 : https://lore.kernel.org/bpf/20210806095539.34423-1-maciej.fijalkowski at intel.com/ v3 : https://lore.kernel.org/bpf/20210805230046.28715-1-maciej.fijalkowski at intel.com/ v2 : https://lore.kernel.org/bpf/20210705164338.58313-1-maciej.fijalkowski at intel.com/ v1 : https://lore.kernel.org/bpf/20210601113236.42651-1-maciej.fijalkowski at intel.com/

Thanks!
Maciej

Maciej Fijalkowski (9):
ice: remove ring_active from ice_ring
ice: move ice_container_type onto ice_ring_container
ice: split ice_ring onto Tx/Rx separate structs
ice: unify xdp_rings accesses
ice: do not create xdp_frame on XDP_TX
ice: propagate xdp_ring onto rx_ring
ice: optimize XDP_TX workloads
ice: introduce XDP_TX fallback path
ice: make use of ice_for_each_* macros

 drivers/net/ethernet/intel/ice/ice.h          |  41 +++-
 drivers/net/ethernet/intel/ice/ice_arfs.c     |   2 +-
 drivers/net/ethernet/intel/ice/ice_base.c     |  59 +++---
 drivers/net/ethernet/intel/ice/ice_base.h     |   8 +-
 drivers/net/ethernet/intel/ice/ice_dcb_lib.c  |   9 +-
 drivers/net/ethernet/intel/ice/ice_dcb_lib.h  |  10 +-
 drivers/net/ethernet/intel/ice/ice_eswitch.c  |  35 ++--
 drivers/net/ethernet/intel/ice/ice_eswitch.h  |   4 +-
 drivers/net/ethernet/intel/ice/ice_ethtool.c  |  95 +++++----
 drivers/net/ethernet/intel/ice/ice_lib.c      |  92 +++++----
 drivers/net/ethernet/intel/ice/ice_lib.h      |   6 +-
 drivers/net/ethernet/intel/ice/ice_main.c     | 145 +++++++++-----
 drivers/net/ethernet/intel/ice/ice_ptp.c      |   2 +-
 drivers/net/ethernet/intel/ice/ice_ptp.h      |   4 +-
 drivers/net/ethernet/intel/ice/ice_trace.h    |  28 +--
 drivers/net/ethernet/intel/ice/ice_txrx.c     | 183 +++++++++++-------
 drivers/net/ethernet/intel/ice/ice_txrx.h     | 126 +++++++-----
 drivers/net/ethernet/intel/ice/ice_txrx_lib.c |  98 ++++++++--
 drivers/net/ethernet/intel/ice/ice_txrx_lib.h |  14 +-
 .../net/ethernet/intel/ice/ice_virtchnl_pf.c  |   2 +-
 drivers/net/ethernet/intel/ice/ice_xsk.c      |  70 ++++---
 drivers/net/ethernet/intel/ice/ice_xsk.h      |  20 +-
 22 files changed, 629 insertions(+), 424 deletions(-)
Signature · 1 line
2.20.1