Introduce BR2_ENABLE_RUNTIME_DEBUG
Get series with b4
b4 am 20210601205427.GF168928@scaerVersions newest first
- v4 Latest7 of 16 patches 0 repliesNew
7 of 16 patches are in this archive. The cover letter announces 16.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | core: introduce BR2_ENABLE_RUNTIME_DEBUG | +0 | 0 replies | |
| 2/16 | core: enable 'NDEBUG' unless BR2_ENABLE_RUNTIME_DEBUG is set | +0 | 2 replies | |
| 2/16 | core: enable 'NDEBUG' unless BR2_ENABLE_RUNTIME_DEBUG is set | +0 | 0 replies | |
| 2/16 | core: enable 'NDEBUG' unless BR2_ENABLE_RUNTIME_DEBUG is set | +0 | 0 replies | |
| 2/16 | core: enable 'NDEBUG' unless BR2_ENABLE_RUNTIME_DEBUG is set | +0 | 0 replies | |
| 3/16 | package/pkg-cmake.mk: determine CMAKE_BUILD_TYPE depending on BR2_ENABLE_RUNTIME_DEBUG | +0 | 0 replies | |
| 15/16 | package/pkg-meson.mk: determine 'buildtype' based on BR2_ENABLE_RUNTIME_DEBUG iso BR2_ENABLE_DEBUG | +0 | 1 reply |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Yann E. MORIN |
|---|---|
| 1/16 | R-b |
| 2/16 | R-b |
| 2/16 | R-b |
| 2/16 | R-b |
| 2/16 | R-b |
| 3/16 | R-b |
| 15/16 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCHv4 00/16] Introduce BR2_ENABLE_RUNTIME_DEBUG
Thomas, All,
On 2021-06-01 16:34 +0200, Thomas De Schampheleire spake thusly:
Quoted 7 lines
This patch series started with as main goal to fix the performance degradation found when testing gRPC in combination with
BR2_ENABLE_DEBUG.Its implementation strives to settle a discussion that has happened several times, regarding the
CMAKE_BUILD_TYPEthat Buildroot should set, by not forcing anything upon the user but allowing the choice.
Quoted 5 lines
Additionally, it cleans up some related changes done in specific packages.
After this series, there are still packages that set
CMAKE_BUILD_TYPEexplicitly, but the associated comments indicate that they are needed to avoid build failures, so they are not touched.
I had started to add my rev-tag to individual commits, until Arnout just suggested I apply the full series instead. So I did just that: applied to next, thanks.
However, please see a little comment about the penultimate commit in your series, about the meson package infra...
Regards,
Yann E. MORIN.
Quoted 58 lines
v2: fix sysrepo after comment by Jan Kundr?t (thanks!)
v3:
- new patch setting -g0 (Arnout)
- don't set -DNDEBUG globally anymore, and drop related libjson change
- flare-engine, supertux: retain disabling of -pg option (Arnout)
- sysrepo: new patch for host-sysrepo, disable tests for target (Arnout)
- update several packages to useBR2_ENABLE_RUNTIME_DEBUGinstead ofBR2_ENABLE_DEBUG
v4:
- drop uclibc patch (Arnout)
- reintroduce global -DNDEBUG
- sofia-sip: fix then remove the handling of NDEBUG
- zmqpp: change buildtype to 'buildroot' in case ofBR2_ENABLE_RUNTIME_DEBUGThomas De Schampheleire (16):
core: introduceBR2_ENABLE_RUNTIME_DEBUG
core: enable 'NDEBUG' unlessBR2_ENABLE_RUNTIME_DEBUGis setpackage/pkg-cmake.mk: determineCMAKE_BUILD_TYPEdepending on
BR2_ENABLE_RUNTIME_DEBUG
package/flare-engine: disable effect ofCMAKE_BUILD_TYPEpackage/sysrepo: use defaultCMAKE_BUILD_TYPEfor host package package/sysrepo: remove explicit setting ofCMAKE_BUILD_TYPEpackage/boost: useBR2_ENABLE_RUNTIME_DEBUGisoBR2_ENABLE_DEBUGpackage/oracle-mysql: useBR2_ENABLE_RUNTIME_DEBUGiso
BR2_ENABLE_DEBUG
package/qt5: useBR2_ENABLE_RUNTIME_DEBUGisoBR2_ENABLE_DEBUGpackage/ripgrep: useBR2_ENABLE_RUNTIME_DEBUGisoBR2_ENABLE_DEBUGpackage/sofia-sip: correct passing of '--enable-ndebug' package/sofia-sip: don't set 'NDEBUG' explicitly package/zmqpp: don't set CONFIG=debug
package/zmqpp: useBR2_ENABLE_RUNTIME_DEBUGisoBR2_ENABLE_DEBUGpackage/pkg-meson.mk: determine 'buildtype' based on
BR2_ENABLE_RUNTIME_DEBUGisoBR2_ENABLE_DEBUG
utils/genrandconfig: also testBR2_ENABLE_RUNTIME_DEBUGConfig.in | 13 +++++++++++++ docs/manual/adding-packages-cmake.txt | 2 +- package/Makefile.in | 3 +++ package/boost/boost.mk | 2 +- package/flare-engine/flare-engine.mk | 12 ++++-------- package/oracle-mysql/oracle-mysql.mk | 2 +- package/pkg-cmake.mk | 2 +- package/pkg-meson.mk | 2 +- package/qt5/qt5base/qt5base.mk | 2 +- package/ripgrep/ripgrep.mk | 2 +- package/sofia-sip/sofia-sip.mk | 4 ---- package/sysrepo/sysrepo.mk | 9 ++++++--- package/zmqpp/zmqpp.mk | 2 +- utils/genrandconfig | 2 ++ 14 files changed, 36 insertions(+), 23 deletions(-)Signature · 6 lines
2.26.3 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'