Skip to content

pgo: Fix allocate_node() handling of non-vmlinux nodes

Jarmo Tiitto lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1pgo: Fix allocate_node() handling of non-vmlinux nodes.kernel/pgo/instrument.c+4 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] pgo: Fix allocate_node() handling of non-vmlinux nodes

Currently allocate_node() will reserve nodes even if *p doesn't point into __llvm_prf_data_start - __llvm_prf_data_end range.

This is wrong:

Any instrumented modules that are not part of vmlinux (built-in) will "steal" available nodes away from vmlinux. This can result in exhaustion of nodes for vmlinux and less accurate profile data.

Either way, any profiling data generated by loaded modules, if any, is unusable from vmlinux.profraw.
So just filtter them out.

Jarmo Tiitto (1):
pgo: Fix allocate_node() handling of non-vmlinux nodes.

 kernel/pgo/instrument.c | 4 ++++
 1 file changed, 4 insertions(+)
Signature · 1 line
2.31.1