Skip to content

modules: add metadata database

Gerd Hoffmann qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest18 patches 31 repliesIn review
  2. v1 RFC9 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18modules: add metadata macros, add qxl module annotationshw/display/qxl.c include/qemu/module.h+26 -00 replies
2/18qapi: add ModuleInfo schemaqapi/meson.build qapi/modules.json qapi/qapi-schema.json+38 -03 replies
3/18modules: add qemu-modinfo utilitymeson.build qemu-modinfo.c+281 -014 replies
4/18modules: add virtio-gpu module annotationshw/display/vhost-user-gpu-pci.c hw/display/vhost-user-gpu.c hw/display/vhost-user-vga.c +7 more+18 -00 replies
5/18modules: add chardev module annotationschardev/baum.c chardev/spice.c+5 -00 replies
6/18modules: add audio module annotationsaudio/spiceaudio.c+2 -00 replies
7/18modules: add usb-redir module annotationshw/usb/redirect.c+1 -00 replies
8/18modules: add ccid module annotationshw/usb/ccid-card-emulated.c hw/usb/ccid-card-passthru.c+2 -00 replies
9/18modules: add ui module annotationsui/egl-headless.c ui/gtk.c ui/sdl2.c +2 more+20 -00 replies
10/18modules: add s390x module annotationshw/s390x/virtio-ccw-gpu.c+3 -00 replies
11/18modules: add block module annotationsblock/iscsi-opts.c+1 -00 replies
12/18modules: add module_load_path_init helperutil/module.c+34 -240 replies
13/18modules: load modinfo.jsonutil/module.c util/trace-events+57 -00 replies
14/18modules: use modinfo for dependenciesutil/module.c+21 -340 replies
15/18modules: use modinfo for qom loadutil/module.c+30 -530 replies
16/18modules: use modinfo for qemu opts loadsoftmmu/vl.c stubs/module-opts.c util/module.c+19 -210 replies
17/18modules: check arch and block load on mismatchinclude/qemu/module.h softmmu/vl.c util/module.c+19 -09 replies
18/18module_load_modinfoutil/module.c+3 -31 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/18] modules: add metadata database

This patch series adds support for module metadata. Here are the pieces of the puzzle:

(1) Macros are added to store metadata in a .modinfo elf section (idea stolen from the linux kernel).
(2) A utility to scan modules, collect metadata from the .modinfo sections, store it in a file (modinfo.json) for later consumption by qemu. Can also be easily inspected using 'jq'.
(3) Adding annotations to the modules we have.
(4) Drop hard-coded lists from utils/module.c

take care,
Gerd

Gerd Hoffmann (18):
modules: add metadata macros, add qxl module annotations
qapi: add ModuleInfo schema
modules: add qemu-modinfo utility
modules: add virtio-gpu module annotations
modules: add chardev module annotations
modules: add audio module annotations
modules: add usb-redir module annotations
modules: add ccid module annotations
modules: add ui module annotations
modules: add s390x module annotations
modules: add block module annotations
modules: add module_load_path_init helper
modules: load modinfo.json
modules: use modinfo for dependencies
modules: use modinfo for qom load
modules: use modinfo for qemu opts load
modules: check arch and block load on mismatch [fixup] module_load_modinfo

 include/qemu/module.h           |  23 +++
 audio/spiceaudio.c              |   2 +
 block/iscsi-opts.c              |   1 +
 chardev/baum.c                  |   1 +
 chardev/spice.c                 |   4 +
 hw/display/qxl.c                |   4 +
 hw/display/vhost-user-gpu-pci.c |   1 +
 hw/display/vhost-user-gpu.c     |   1 +
 hw/display/vhost-user-vga.c     |   1 +
 hw/display/virtio-gpu-base.c    |   1 +
 hw/display/virtio-gpu-gl.c      |   3 +
 hw/display/virtio-gpu-pci-gl.c  |   3 +
 hw/display/virtio-gpu-pci.c     |   2 +
 hw/display/virtio-gpu.c         |   1 +
 hw/display/virtio-vga-gl.c      |   3 +
 hw/display/virtio-vga.c         |   2 +
 hw/s390x/virtio-ccw-gpu.c       |   3 +
 hw/usb/ccid-card-emulated.c     |   1 +
 hw/usb/ccid-card-passthru.c     |   1 +
 hw/usb/redirect.c               |   1 +
 qemu-modinfo.c                  | 270 ++++++++++++++++++++++++++++++
 softmmu/vl.c                    |  20 +--
 stubs/module-opts.c             |   4 -
 ui/egl-headless.c               |   4 +
 ui/gtk.c                        |   4 +
 ui/sdl2.c                       |   4 +
 ui/spice-app.c                  |   3 +
 ui/spice-core.c                 |   5 +
 util/module.c                   | 282 +++++++++++++++++++-------------
 meson.build                     |  11 ++
 qapi/meson.build                |   1 +
 qapi/modules.json               |  36 ++++
 qapi/qapi-schema.json           |   1 +
 util/trace-events               |   3 +
 34 files changed, 576 insertions(+), 131 deletions(-)
 create mode 100644 qemu-modinfo.c
 create mode 100644 qapi/modules.json
Signature · 1 line
2.31.1