Skip to content

Support compressed firmwares

David Marchand dpdk-dev 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 1 replyIn review
  2. v42 patches 0 repliesSuperseded
  3. v32 patches 14 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches6 repliesSuperseded
v12 patches10 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net/ice: factorize firmware loadingdrivers/net/ice/base/ice_osdep.h drivers/net/ice/ice_dcf_parent.c drivers/net/ice/ice_ethdev.c +1 more+88 -1790 replies
2/2eal: handle compressed firmware.github/workflows/build.yml .travis.yml config/meson.build +10 more+270 -1420 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchHaiyue WangIgor RusskikhAaron Conole
1/2A-b
2/2T-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [dpdk-dev] [PATCH v5 0/2] Support compressed firmwares

Fedora 34 only provides compressed firmwares.

Introduce an internal driver helper to handle transparently compression.

I chose libarchive for decompressing as it seems widely available and DPDK had used it in the past.

Windows support only matters for net/ice and firmware loading was skipped in this driver before this series. Since I don't know if/how we want to load firmwares on Windows, I let an empty stub for this OS.

This series has been compile tested on Linux (I'll trust the CI for others OSes).
I only tested basic init with a net/ice device (no DCF test).

So please drivers maintainers, check nothing is broken.

Signature · 41 lines
David Marchand

Changes since v4:
- unexport header,
- s/firmwares/firmware/ from Bruce,

Changes since v3:
- add release note update,

Changes since v2:
- update comment on libarchive link dependency,

Changes since v1:
- address comments on patch2,

David Marchand (2):
  net/ice: factorize firmware loading
  eal: handle compressed firmware

 .github/workflows/build.yml            |   1 +
 .travis.yml                            |   1 +
 config/meson.build                     |  10 ++
 doc/guides/rel_notes/release_21_08.rst |   6 +
 drivers/net/bnx2x/bnx2x.c              |  36 ++---
 drivers/net/ice/base/ice_osdep.h       |   6 -
 drivers/net/ice/ice_dcf_parent.c       |  97 ++------------
 drivers/net/ice/ice_ethdev.c           | 176 ++++++++++---------------
 drivers/net/ice/ice_ethdev.h           |   3 +-
 drivers/net/nfp/nfp_net.c              |  58 ++------
 drivers/net/qede/qede_main.c           |  46 +++----
 lib/eal/common/eal_firmware.h          |  32 +++++
 lib/eal/unix/eal_firmware.c            | 150 +++++++++++++++++++++
 lib/eal/unix/meson.build               |   1 +
 lib/eal/version.map                    |   1 +
 lib/eal/windows/eal.c                  |   9 ++
 16 files changed, 335 insertions(+), 298 deletions(-)
 create mode 100644 lib/eal/common/eal_firmware.h
 create mode 100644 lib/eal/unix/eal_firmware.c

-- 
2.23.0