Skip to content

Fix a bunch of static analyzer warnings

Phil Sutter netfilter-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9libxtables: Drop leftover variable in xtables_numeric_to_ip6addr()libxtables/xtables.c+1 -20 replies
2/9extensions: libebt_ip6: Drop unused variablesextensions/libebt_ip6.c+2 -40 replies
3/9libxtables: Fix memleak in xtopt_parse_hostmask()libxtables/xtoptions.c+1 -00 replies
4/9nft: Avoid memleak in error path of nft_cmd_new()iptables/nft-cmd.c+3 -10 replies
5/9nft: Avoid buffer size warnings copying iface namesiptables/nft-ipv4.c iptables/nft-ipv6.c+4 -40 replies
6/9iptables-apply: Drop unused variableiptables/iptables-apply+0 -10 replies
7/9extensions: libebt_ip6: Use xtables_ip6parse_any()extensions/libebt_ip6.c+10 -640 replies
8/9libxtables: Introduce xtables_strdup() and use it everywhereextensions/libebt_ip.c extensions/libebt_ip6.c extensions/libebt_stp.c +23 more+60 -730 replies
9/9extensions: libxt_string: Avoid buffer size warning for strncpy()extensions/libxt_string.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [iptables PATCH 0/9] Fix a bunch of static analyzer warnings

These fixes vary in severity, ranging from unused variables to memleaks.

Phil Sutter (9):
libxtables: Drop leftover variable in xtables_numeric_to_ip6addr()
extensions: libebt_ip6: Drop unused variables
libxtables: Fix memleak in xtopt_parse_hostmask()
nft: Avoid memleak in error path of nft_cmd_new()
nft: Avoid buffer size warnings copying iface names
iptables-apply: Drop unused variable
extensions: libebt_ip6: Use xtables_ip6parse_any()
libxtables: Introduce xtables_strdup() and use it everywhere
extensions: libxt_string: Avoid buffer size warning for strncpy()

 extensions/libebt_ip.c          |  3 +-
 extensions/libebt_ip6.c         | 78 +++++----------------------------
 extensions/libebt_stp.c         |  3 +-
 extensions/libip6t_DNAT.c       |  4 +-
 extensions/libip6t_SNAT.c       |  4 +-
 extensions/libip6t_dst.c        |  8 ++--
 extensions/libip6t_hbh.c        |  7 ++-
 extensions/libip6t_ipv6header.c |  2 +-
 extensions/libip6t_mh.c         |  2 +-
 extensions/libip6t_rt.c         |  7 ++-
 extensions/libipt_DNAT.c        |  8 +---
 extensions/libipt_SNAT.c        |  4 +-
 extensions/libxt_dccp.c         |  2 +-
 extensions/libxt_hashlimit.c    |  5 +--
 extensions/libxt_iprange.c      |  4 +-
 extensions/libxt_multiport.c    |  6 +--
 extensions/libxt_sctp.c         |  4 +-
 extensions/libxt_set.h          |  4 +-
 extensions/libxt_string.c       |  2 +-
 extensions/libxt_tcp.c          |  4 +-
 include/xtables.h               |  1 +
 iptables/iptables-apply         |  1 -
 iptables/iptables-xml.c         |  4 +-
 iptables/nft-cache.c            |  4 +-
 iptables/nft-cmd.c              | 17 ++++---
 iptables/nft-ipv4.c             |  4 +-
 iptables/nft-ipv6.c             |  4 +-
 iptables/xshared.c              |  2 +-
 libxtables/xtables.c            | 15 ++++++-
 libxtables/xtoptions.c          | 15 ++-----
 30 files changed, 80 insertions(+), 148 deletions(-)
Signature · 1 line
2.31.1