Skip to content

GuC CTBs changes + a few misc patches

Matthew Brost dri-devel intel-gfx oe-kbuild-all 1 version Applied

Status from this message: Applied all up to this, except the Kconfig one.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 13 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/20drm/i915/guc: skip disabling CTBs before sanitizing the GuCdrivers/gpu/drm/i915/gt/uc/intel_uc.c+1 -70 replies
2/20drm/i915/guc: use probe_error log for CT enablement failuredrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+25 -230 replies
3/20drm/i915/guc: enable only the user interrupt when using GuC submissiondrivers/gpu/drm/i915/gt/intel_gt_irq.c drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c+11 -380 replies
4/20drm/i915/guc: Remove sample_forcewake h2g actiondrivers/gpu/drm/i915/gt/uc/intel_guc.c drivers/gpu/drm/i915/gt/uc/intel_guc.h drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h +1 more+0 -250 replies
5/20drm/i915/guc: Keep strict GuC ABI definitionsdrivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h drivers/gpu/drm/i915/gt/uc/abi/guc_communication_mmio_abi.h +3 more+250 -1970 replies
6/20drm/i915/guc: Drop guc->interrupts.enableddrivers/gpu/drm/i915/gt/uc/intel_guc.c drivers/gpu/drm/i915/gt/uc/intel_guc.h+9 -190 replies
7/20drm/i915/guc: Stop using fence/status from CTB descriptordrivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+6 -700 replies
8/20drm/i915: Promote ptrdiff() to i915_utils.hdrivers/gpu/drm/i915/i915_utils.h drivers/gpu/drm/i915/i915_vma.h+5 -53 replies
9/20drm/i915/guc: Only rely on own CTB sizedrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h+43 -140 replies
10/20drm/i915/guc: Don't repeat CTB layout calculationsdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+10 -60 replies
11/20drm/i915/guc: Replace CTB array with explicit membersdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h+30 -237 replies
12/20drm/i915/guc: Update sizes of CTB buffersdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+32 -280 replies
13/20drm/i915/guc: Relax CTB response timeoutdrivers/gpu/drm/i915/Kconfig.profile drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+14 -13 replies
14/20drm/i915/guc: Start protecting access to CTB descriptorsdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h+14 -21 reply
15/20drm/i915/guc: Ensure H2G buffer updates visible before tail updatedrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+28 -03 replies
16/20drm/i915/guc: Stop using mutex while sending CTB messagesdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+0 -40 replies
17/20drm/i915/guc: Don't receive all G2H messages in irq handlerdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h+50 -200 replies
18/20drm/i915/guc: Always copy CT message to new allocationdrivers/gpu/drm/i915/gt/uc/intel_guc_ct.c+120 -600 replies
19/20drm/i915/guc: Early initialization of GuC send registersdrivers/gpu/drm/i915/gt/uc/intel_guc.c+9 -90 replies
20/20drm/i915/guc: Use guc_class instead of engine_class in fw interfacedrivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h+42 -102 replies

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by.

PatchJohn HarrisonMichal WajdeczkoMatthew BrostMichał Winiarski
1/20R-b
2/20R-b
3/20R-b
4/20A-b R-b
5/20R-b
6/20R-b
7/20R-b
8/20R-b
9/20R-b
10/20R-b
11/20R-b R-b R-b R-b R-b
12/20R-b
13/20R-b
14/20R-b
15/20R-b
16/20R-b
17/20R-b
18/20R-b
19/20R-b
20/20R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/20] GuC CTBs changes + a few misc patches

Single series to merge the following series that have been reviewed / passed CI:
https://patchwork.freedesktop.org/series/90633/
https://patchwork.freedesktop.org/series/90552/

Daniele Ceraolo Spurio (4):
drm/i915/guc: skip disabling CTBs before sanitizing the GuC drm/i915/guc: use probe_error log for CT enablement failure drm/i915/guc: enable only the user interrupt when using GuC submission drm/i915/guc: Use guc_class instead of engine_class in fw interface

Matthew Brost (2):
drm/i915/guc: Drop guc->interrupts.enabled drm/i915/guc: Ensure H2G buffer updates visible before tail update

Michal Wajdeczko (13):
drm/i915/guc: Keep strict GuC ABI definitions drm/i915/guc: Stop using fence/status from CTB descriptor drm/i915: Promote ptrdiff() to i915_utils.h drm/i915/guc: Only rely on own CTB size drm/i915/guc: Don't repeat CTB layout calculations drm/i915/guc: Replace CTB array with explicit members drm/i915/guc: Update sizes of CTB buffers drm/i915/guc: Relax CTB response timeout drm/i915/guc: Start protecting access to CTB descriptors drm/i915/guc: Stop using mutex while sending CTB messages drm/i915/guc: Don't receive all G2H messages in irq handler drm/i915/guc: Always copy CT message to new allocation drm/i915/guc: Early initialization of GuC send registers

Rodrigo Vivi (1):
drm/i915/guc: Remove sample_forcewake h2g action

 drivers/gpu/drm/i915/Kconfig.profile          |  10 +
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |   6 +-
 drivers/gpu/drm/i915/gt/intel_gt_irq.c        |  18 +-
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |  51 ++
 .../gt/uc/abi/guc_communication_ctb_abi.h     | 106 ++++
 .../gt/uc/abi/guc_communication_mmio_abi.h    |  52 ++
 .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |  14 +
 .../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h |  21 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |  61 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   2 -
 drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c    |  20 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c     | 537 +++++++++++-------
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h     |  14 +-
 drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h   | 233 ++------
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  31 -
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |  10 -
 drivers/gpu/drm/i915/i915_utils.h             |   5 +
 drivers/gpu/drm/i915/i915_vma.h               |   5 -
 18 files changed, 667 insertions(+), 529 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
 create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
 create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_communication_mmio_abi.h
 create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_errors_abi.h
 create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
Signature · 6 lines
2.28.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx