GuC CTBs changes + a few misc patches
Status from this message: Applied all up to this, except the Kconfig one.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | drm/i915/guc: skip disabling CTBs before sanitizing the GuCdrivers/ | +1 | 0 replies | |
| 2/20 | drm/i915/guc: use probe_error log for CT enablement failuredrivers/ | +25 | 0 replies | |
| 3/20 | drm/i915/guc: enable only the user interrupt when using GuC submissiondrivers/ drivers/ | +11 | 0 replies | |
| 4/20 | drm/i915/guc: Remove sample_forcewake h2g actiondrivers/ drivers/ drivers/ +1 more | +0 | 0 replies | |
| 5/20 | drm/i915/guc: Keep strict GuC ABI definitionsdrivers/ drivers/ drivers/ +3 more | +250 | 0 replies | |
| 6/20 | drm/i915/guc: Drop guc->interrupts.enableddrivers/ drivers/ | +9 | 0 replies | |
| 7/20 | drm/i915/guc: Stop using fence/status from CTB descriptordrivers/ drivers/ | +6 | 0 replies | |
| 8/20 | drm/i915: Promote ptrdiff() to i915_utils.hdrivers/ drivers/ | +5 | 3 replies | |
| 9/20 | drm/i915/guc: Only rely on own CTB sizedrivers/ drivers/ | +43 | 0 replies | |
| 10/20 | drm/i915/guc: Don't repeat CTB layout calculationsdrivers/ | +10 | 0 replies | |
| 11/20 | drm/i915/guc: Replace CTB array with explicit membersdrivers/ drivers/ | +30 | 7 replies | |
| 12/20 | drm/i915/guc: Update sizes of CTB buffersdrivers/ | +32 | 0 replies | |
| 13/20 | drm/i915/guc: Relax CTB response timeoutdrivers/ drivers/ | +14 | 3 replies | |
| 14/20 | drm/i915/guc: Start protecting access to CTB descriptorsdrivers/ drivers/ | +14 | 1 reply | |
| 15/20 | drm/i915/guc: Ensure H2G buffer updates visible before tail updatedrivers/ | +28 | 3 replies | |
| 16/20 | drm/i915/guc: Stop using mutex while sending CTB messagesdrivers/ | +0 | 0 replies | |
| 17/20 | drm/i915/guc: Don't receive all G2H messages in irq handlerdrivers/ drivers/ | +50 | 0 replies | |
| 18/20 | drm/i915/guc: Always copy CT message to new allocationdrivers/ | +120 | 0 replies | |
| 19/20 | drm/i915/guc: Early initialization of GuC send registersdrivers/ | +9 | 0 replies | |
| 20/20 | drm/i915/guc: Use guc_class instead of engine_class in fw interfacedrivers/ drivers/ drivers/ | +42 | 2 replies |
Reviews trailers per patch
All 20 patches have a Reviewed-by or Acked-by.
| Patch | John Harrison | Michal Wajdeczko | Matthew Brost | Michał Winiarski |
|---|---|---|---|---|
| 1/20 | R-b | |||
| 2/20 | R-b | |||
| 3/20 | R-b | |||
| 4/20 | A-b | R-b | ||
| 5/20 | R-b | |||
| 6/20 | R-b | |||
| 7/20 | R-b | |||
| 8/20 | R-b | |||
| 9/20 | R-b | |||
| 10/20 | R-b | |||
| 11/20 | R-b R-b R-b R-b R-b | |||
| 12/20 | R-b | |||
| 13/20 | R-b | |||
| 14/20 | R-b | |||
| 15/20 | R-b | |||
| 16/20 | R-b | |||
| 17/20 | R-b | |||
| 18/20 | R-b | |||
| 19/20 | R-b | |||
| 20/20 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH 00/20] GuC CTBs changes + a few misc patches
Single series to merge the following series that have been reviewed / passed CI:
https://patchwork.freedesktop.org/series/90633/
https://patchwork.freedesktop.org/series/90552/
Daniele Ceraolo Spurio (4):
drm/i915/guc: skip disabling CTBs before sanitizing the GuC drm/i915/guc: use probe_error log for CT enablement failure drm/i915/guc: enable only the user interrupt when using GuC submission drm/i915/guc: Use guc_class instead of engine_class in fw interface
Matthew Brost (2):
drm/i915/guc: Drop guc->interrupts.enabled drm/i915/guc: Ensure H2G buffer updates visible before tail update
Michal Wajdeczko (13):
drm/i915/guc: Keep strict GuC ABI definitions drm/i915/guc: Stop using fence/status from CTB descriptor drm/i915: Promote ptrdiff() to i915_utils.h drm/i915/guc: Only rely on own CTB size drm/i915/guc: Don't repeat CTB layout calculations drm/i915/guc: Replace CTB array with explicit members drm/i915/guc: Update sizes of CTB buffers drm/i915/guc: Relax CTB response timeout drm/i915/guc: Start protecting access to CTB descriptors drm/i915/guc: Stop using mutex while sending CTB messages drm/i915/guc: Don't receive all G2H messages in irq handler drm/i915/guc: Always copy CT message to new allocation drm/i915/guc: Early initialization of GuC send registers
Rodrigo Vivi (1):
drm/i915/guc: Remove sample_forcewake h2g action
drivers/gpu/drm/i915/Kconfig.profile | 10 + drivers/gpu/drm/i915/gt/intel_engine_cs.c | 6 +- drivers/gpu/drm/i915/gt/intel_gt_irq.c | 18 +- .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 51 ++ .../gt/uc/abi/guc_communication_ctb_abi.h | 106 ++++ .../gt/uc/abi/guc_communication_mmio_abi.h | 52 ++ .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 14 + .../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 21 + drivers/gpu/drm/i915/gt/uc/intel_guc.c | 61 +- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 - drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 20 +- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 537 +++++++++++------- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 14 +- drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 233 ++------ .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 31 - drivers/gpu/drm/i915/gt/uc/intel_uc.c | 10 - drivers/gpu/drm/i915/i915_utils.h | 5 + drivers/gpu/drm/i915/i915_vma.h | 5 - 18 files changed, 667 insertions(+), 529 deletions(-) create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_communication_mmio_abi.h create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_errors_abi.h create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h
Signature · 6 lines
2.28.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx