Skip to content

PCI/ACPI: Simplify PCIe _OSC feature negotiation

Joerg Roedel linux-acpi linux-pci lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 10 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v11 patch 7 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4PCI/ACPI: Remove OSC_PCI_SUPPORT_MASKS and OSC_PCI_CONTROL_MASKSdrivers/acpi/pci_root.c include/linux/acpi.h+3 -81 reply
2/4PCI/ACPI: Move supported and control calculations to separaten functionsdrivers/acpi/pci_root.c+55 -381 reply
3/4PCI/ACPI: Move _OSC query checks to separate functiondrivers/acpi/pci_root.c+19 -91 reply
4/4PCI/ACPI: Check for _OSC support in acpi_pci_osc_control_set()drivers/acpi/pci_root.c+32 -491 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchRafael J. Wysocki
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] PCI/ACPI: Simplify PCIe _OSC feature negotiation

From: Joerg Roedel <[email protected]>

Hi,

here is the third version of my patches to simplify the _OSC negotiation of PCIe features between Linux and the firmware.

This version is a complete rewrite, so there is no changelog to the previous version. Patches 1-3 are cleanups and small restructurings of the code as a preparation for patch 4.

The last patch gets rid of the dedicated _OSC query to check for _OSC support and merges that functionality into acpi_pci_osc_control_set().

This allows to simplify and/or remove other functions and consilidate error handling in negotiate_os_control().

I have tested the patches with and without 'pcie_ports=compat' and found no regressions on my test machine.

Please review.

Thanks,

Joerg

Joerg Roedel (4):
PCI/ACPI: Remove OSC_PCI_SUPPORT_MASKS and OSC_PCI_CONTROL_MASKS PCI/ACPI: Move supported and control calculations to separaten
functions
PCI/ACPI: Move _OSC query checks to separate function PCI/ACPI: Check for _OSC support in acpi_pci_osc_control_set()

 drivers/acpi/pci_root.c | 161 +++++++++++++++++++++-------------------
 include/linux/acpi.h    |   2 -
 2 files changed, 84 insertions(+), 79 deletions(-)
Signature · 1 line
2.32.0