Skip to content

Fix IPsec crypto offloads with vxlan tunnel

Huy Nguyen netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 2 repliesIn review
  2. v43 patches 1 replySuperseded
  3. v33 patches 2 repliesSuperseded

Changes in v5 from the cover letter

- Fix double initialization of xo in xfrm_get_inner_ipproto

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net/mlx5: Optimize mlx5e_feature_checks for non IPsec packetdrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.h drivers/net/ethernet/mellanox/mlx5/core/en_main.c+14 -90 replies
2/3net/xfrm: Add inner_ipproto into sec_pathinclude/net/xfrm.h net/xfrm/xfrm_output.c+41 -11 reply
3/3net/mlx5: Fix checksum issue of VXLAN and IPsec crypto offloaddrivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.h+70 -190 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchSteffen Klassert
1/3
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH net-next v5 0/3] Fix IPsec crypto offloads with vxlan tunnel

v4 -> v5:
- Fix double initialization of xo in xfrm_get_inner_ipproto

v3 -> v4:
- Check explicitly for skb->ecapsulation before calling xfrm_get_inner_ipproto.
- Move patche set to net-next

v2 -> v3:
- Fix bug in patch 003 when checking for xo null pointer in mlx5e_ipsec_feature_check
- Fix bug of accidentally commenting out memset in patch 003

v1 -> v2:
- Move inner_ipproto into xfrm_offload structure.
- Fix static code analysis errors.
- skip checking for skb->encapsulation to be more flexible for vendor

This small series fixes ipsec TX offloads with vxlan overlay on top of the offloaded ipsec packet, the driver (mlx5) was lacking such information and the skb->encapsulation bit wasn't enough as indication to reach the vxlan inner headers, as a solution we mark the tunnel in the offloaded context of ipsec.

Huy Nguyen (3):
net/mlx5: Optimize mlx5e_feature_checks for non IPsec packet net/xfrm: Add inner_ipproto into sec_path
net/mlx5: Fix checksum issue of VXLAN and IPsec crypto offload

 .../mellanox/mlx5/core/en_accel/ipsec_rxtx.c  | 65 ++++++++++++++-----
 .../mellanox/mlx5/core/en_accel/ipsec_rxtx.h  | 37 ++++++++---
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  8 ++-
 include/net/xfrm.h                            |  1 +
 net/xfrm/xfrm_output.c                        | 41 +++++++++++-
 5 files changed, 124 insertions(+), 28 deletions(-)
Signature · 1 line
2.24.1