Skip to content

hw/nvme: reimplement all multi-aio commands with custom aiocbs

Klaus Jensen qemu-devel 2 versions – Applied

Status from this message: Applied to nvme-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 4 repliesApplied
  2. v1 RFC11 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- dropped RFC
- fixed flush cancel from being unintentially a noop (Vladimir)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/11hw/nvme: reimplement flush to allow cancellationhw/nvme/ctrl.c hw/nvme/nvme.h hw/nvme/trace-events+130 -840 replies
2/11hw/nvme: add nvme_block_status_all helperhw/nvme/ctrl.c+28 -130 replies
3/11hw/nvme: reimplement dsm to allow cancellationhw/nvme/ctrl.c hw/nvme/trace-events+162 -750 replies
4/11hw/nvme: save reftag when generating pihw/nvme/ctrl.c hw/nvme/dif.c hw/nvme/nvme.h+18 -180 replies
5/11hw/nvme: remove assert from nvme_get_zone_by_slbahw/nvme/ctrl.c+14 -40 replies
6/11hw/nvme: use prinfo directly in nvme_check_prinfo and nvme_dif_checkhw/nvme/ctrl.c hw/nvme/dif.c hw/nvme/nvme.h +1 more+57 -660 replies
7/11hw/nvme: add dw0/1 to the req completion trace eventhw/nvme/ctrl.c hw/nvme/trace-events+3 -10 replies
8/11hw/nvme: reimplement the copy command to allow aio cancellationhw/nvme/ctrl.c hw/nvme/trace-events+394 -3350 replies
9/11hw/nvme: reimplement zone reset to allow cancellationhw/nvme/ctrl.c hw/nvme/trace-events+169 -1210 replies
10/11hw/nvme: reimplement format nvm to allow cancellationhw/nvme/ctrl.c hw/nvme/trace-events+156 -1370 replies
11/11Partially revert "hw/block/nvme: drain namespaces on sq deletion"hw/nvme/ctrl.c+2 -172 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKeith Busch
SeriesR-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/11] hw/nvme: reimplement all multi-aio commands with custom aiocbs

From: Klaus Jensen <[email protected]>

This series reimplements flush, dsm, copy, zone reset and format nvm to allow cancellation. I posted an RFC back in March ("hw/block/nvme:
convert ad-hoc aio tracking to aiocb") and I've applied some feedback from Stefan and reimplemented the remaining commands.

The basic idea is to define custom AIOCBs for these commands. The custom AIOCB takes care of issuing all the "nested" AIOs one by one instead of blindly sending them off simultaneously without tracking the returned aiocbs.

v2:
- dropped RFC
- fixed flush cancel from being unintentially a noop (Vladimir)

Klaus Jensen (11):
hw/nvme: reimplement flush to allow cancellation
hw/nvme: add nvme_block_status_all helper
hw/nvme: reimplement dsm to allow cancellation
hw/nvme: save reftag when generating pi
hw/nvme: remove assert from nvme_get_zone_by_slba hw/nvme: use prinfo directly in nvme_check_prinfo and nvme_dif_check hw/nvme: add dw0/1 to the req completion trace event hw/nvme: reimplement the copy command to allow aio cancellation hw/nvme: reimplement zone reset to allow cancellation hw/nvme: reimplement format nvm to allow cancellation Partially revert "hw/block/nvme: drain namespaces on sq deletion"

 hw/nvme/nvme.h       |   10 +-
 include/block/nvme.h |    8 +
 hw/nvme/ctrl.c       | 1883 ++++++++++++++++++++++++------------------
 hw/nvme/dif.c        |   64 +-
 hw/nvme/trace-events |   21 +-
 5 files changed, 1124 insertions(+), 862 deletions(-)
Signature · 1 line
2.32.0